Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0048091 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Modules] Tax Report Launcher | minor | have not tried | 2021-11-17 14:31 | 2022-01-24 15:07 | |||
| Reporter | vmromanos | View Status | public | |||||
| Assigned To | mgonzalezh | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Regression date | ||||||||
| Regression introduced by commit | ||||||||
| Regression level | ||||||||
| Review Assigned To | ||||||||
| Regression introduced in release | ||||||||
| Summary | 0048091: SPLP: Several modules from functional/omni team are using bad logging (System.out,System.err println or printStackTrace) | |||||||
| Description | This issue focus only on the SPLP related modules: 2 mods/org.openbravo.module.taxreportlauncher 3 pmods/org.openbravo.module.aeat190.es 3 pmods/org.openbravo.module.aeat347apr.es 7 pmods/org.openbravo.module.aeat390.es 1 pmods/org.openbravo.module.intrastat 23 pmods/org.openbravo.module.sii | |||||||
| Steps To Reproduce | In any workspace having the relevant modules run to get the overview: grep -IrE "System.out|System.err|printStackTrace" | grep -v buildvalidation | grep -v modulescript | grep -v src-test | cut -d'/' -f1-2 | sort | uniq -c To get the full list (including code in question): grep -IrE "System.out|System.err|printStackTrace" | grep -v buildvalidation | grep -v modulescript | grep -v src-test | cut -d'/' -f1-2 | sort | uniq -c | |||||||
| Proposed Solution | Review and move the logging to proper log4j usage. While doing that check if: - stackTrace is really wanted - Logging is really useful (and not developer leftover) | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||||
|
|||||||||||||||||
 Relationships |
|
Notes |
|
|
(0133378) hgbot (developer) 2021-11-26 00:51 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.aeat190.es/-/merge_requests/7 [^] |
|
(0133379) hgbot (developer) 2021-11-26 01:06 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.aeat347apr.es/-/merge_requests/1 [^] |
|
(0133380) hgbot (developer) 2021-11-26 01:07 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.aeat390.es/-/merge_requests/5 [^] |
|
(0133381) hgbot (developer) 2021-11-26 01:08 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.intrastat/-/merge_requests/2 [^] |
|
(0133382) hgbot (developer) 2021-11-26 01:09 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii/-/merge_requests/29 [^] |
|
(0133390) hgbot (developer) 2021-11-26 13:35 |
Merge Request created: https://gitlab.com/openbravo/product/mods/org.openbravo.module.taxreportlauncher/-/merge_requests/1 [^] |
|
(0134516) hgbot (developer) 2022-01-24 14:40 |
Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.module.taxreportlauncher [^] Changeset: 9e3ec94b0085e7b08ddbfc05a600a25697b2534e Author: Maykel Gonzalez <maykel.gonzalez@smfconsulting.es> Date: 24-01-2022 13:40:15 URL: https://gitlab.com/openbravo/product/mods/org.openbravo.module.taxreportlauncher/-/commit/9e3ec94b0085e7b08ddbfc05a600a25697b2534e [^] Fixes BUG-48091: move the logging to proper log4j usage --- M src-db/database/sourcedata/AD_MODULE.xml M src/org/openbravo/module/taxreportlauncher/Utility/OBTL_Utility.java M src/org/openbravo/module/taxreportlauncher/erpCommon/ad_reports/OBTL_TaxReportLauncher.java --- |
|
(0134517) hgbot (developer) 2022-01-24 14:40 |
Merge request merged: https://gitlab.com/openbravo/product/mods/org.openbravo.module.taxreportlauncher/-/merge_requests/1 [^] |
|
(0134518) hgbot (developer) 2022-01-24 14:45 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii [^] Changeset: 9a0d8a44de2d254bcbc93bf43ed2ebc204ae0fa6 Author: Maykel Gonzalez <maykel.gonzalez@smfconsulting.es> Date: 24-01-2022 13:45:14 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii/-/commit/9a0d8a44de2d254bcbc93bf43ed2ebc204ae0fa6 [^] Fixes BUG-48091: move the logging to proper log4j usage --- M src-db/database/sourcedata/AD_MODULE.xml M src/org/openbravo/module/sii/process/ConsultaFactura.java M src/org/openbravo/module/sii/process/MultiEnvioFactura.java M src/org/openbravo/module/sii/process/PaymentSending.java M src/org/openbravo/module/sii/process/UpdateInvoicesPreSii.java M src/org/openbravo/module/sii/process/background/SendInvoicesGroupsToAEAT.java --- |
|
(0134519) hgbot (developer) 2022-01-24 14:45 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.sii/-/merge_requests/29 [^] |
|
(0134520) hgbot (developer) 2022-01-24 14:52 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.aeat390.es/-/merge_requests/5 [^] |
|
(0134521) hgbot (developer) 2022-01-24 14:52 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.aeat390.es [^] Changeset: 8f2c3dfdf88885ba03da6d01bcf9bb9d8a097abd Author: Maykel Gonzalez <maykel.gonzalez@smfconsulting.es> Date: 24-01-2022 13:52:13 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.aeat390.es/-/commit/8f2c3dfdf88885ba03da6d01bcf9bb9d8a097abd [^] Fixes BUG-48091: move the logging to proper log4j usage --- M src-db/database/sourcedata/AD_MODULE.xml M src/org/openbravo/module/aeat390/es/csv/AEAT390CSV.java M src/org/openbravo/module/aeat390/es/utility/AEAT390ReflectionUtility.java M src/org/openbravo/module/aeat390/es/utility/AEAT390Utility.java --- |
|
(0134522) hgbot (developer) 2022-01-24 14:52 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.aeat347apr.es/-/merge_requests/1 [^] |
|
(0134523) hgbot (developer) 2022-01-24 14:52 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.aeat347apr.es [^] Changeset: cc2736d7186589962b70edb87b7468899b41b288 Author: Maykel Gonzalez <maykel.gonzalez@smfconsulting.es> Date: 24-01-2022 13:52:48 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.aeat347apr.es/-/commit/cc2736d7186589962b70edb87b7468899b41b288 [^] Fixes BUG-48091: move the logging to proper log4j usage --- M src-db/database/sourcedata/AD_MODULE.xml M src/org/openbravo/module/aeat347apr/es/AEAT347ReportAPR.java M src/org/openbravo/module/aeat347apr/es/AEAT347ReportAPRDao.java M src/org/openbravo/module/aeat347apr/es/csv/AEAT347CSV.java --- |
|
(0134524) hgbot (developer) 2022-01-24 14:56 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.aeat190.es [^] Changeset: ab97e1b3cda80434eb4d630dd4a6cce38415d7d6 Author: Maykel Gonzalez <maykel.gonzalez@smfconsulting.es> Date: 24-01-2022 13:56:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.aeat190.es/-/commit/ab97e1b3cda80434eb4d630dd4a6cce38415d7d6 [^] Fixes BUG-48091: move the logging to proper log4j usage --- M src-db/database/sourcedata/AD_MODULE.xml M src/org/openbravo/module/aeat190/es/report/AEAT190ReportDao.java --- |
|
(0134525) hgbot (developer) 2022-01-24 14:56 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.aeat190.es/-/merge_requests/7 [^] |
|
(0134526) hgbot (developer) 2022-01-24 15:07 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.intrastat [^] Changeset: 7520f5cb92a5c40699a49c9b73a901a1ec27f9ee Author: Maykel Gonzalez <maykel.gonzalez@smfconsulting.es> Date: 24-01-2022 14:07:41 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.intrastat/-/commit/7520f5cb92a5c40699a49c9b73a901a1ec27f9ee [^] Fixes BUG-48091: move the logging to proper log4j usage --- M src-db/database/sourcedata/AD_MODULE.xml M src/org/openbravo/module/intrastat/exception/IntrastatExceptionHandler.java --- |
|
(0134527) hgbot (developer) 2022-01-24 15:07 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.intrastat/-/merge_requests/2 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-11-17 14:31 | vmromanos | New Issue | |
| 2021-11-17 14:31 | vmromanos | Assigned To | => Triage Finance |
| 2021-11-17 14:31 | vmromanos | Issue generated from | 0047974 |
| 2021-11-17 14:31 | vmromanos | Relationship added | related to 0047974 |
| 2021-11-17 14:31 | vmromanos | Relationship added | blocks 0036162 |
| 2021-11-17 15:01 | psanjuan | Assigned To | Triage Finance => Jorge Bravo |
| 2021-11-19 10:07 | Jorge Bravo | Assigned To | Jorge Bravo => juabaez |
| 2021-11-26 00:51 | hgbot | Note Added: 0133378 | |
| 2021-11-26 01:06 | hgbot | Note Added: 0133379 | |
| 2021-11-26 01:07 | hgbot | Note Added: 0133380 | |
| 2021-11-26 01:08 | hgbot | Note Added: 0133381 | |
| 2021-11-26 01:09 | hgbot | Note Added: 0133382 | |
| 2021-11-26 13:35 | hgbot | Note Added: 0133390 | |
| 2021-12-07 14:13 | Jorge Bravo | Assigned To | juabaez => mgonzalezh |
| 2021-12-07 14:13 | Jorge Bravo | Assigned To | mgonzalezh => juabaez |
| 2021-12-07 14:13 | Jorge Bravo | Assigned To | juabaez => mgonzalezh |
| 2022-01-24 14:40 | hgbot | Resolution | open => fixed |
| 2022-01-24 14:40 | hgbot | Status | new => resolved |
| 2022-01-24 14:40 | hgbot | Note Added: 0134516 | |
| 2022-01-24 14:40 | hgbot | Note Added: 0134517 | |
| 2022-01-24 14:45 | hgbot | Note Added: 0134518 | |
| 2022-01-24 14:45 | hgbot | Note Added: 0134519 | |
| 2022-01-24 14:52 | hgbot | Note Added: 0134520 | |
| 2022-01-24 14:52 | hgbot | Note Added: 0134521 | |
| 2022-01-24 14:52 | hgbot | Note Added: 0134522 | |
| 2022-01-24 14:52 | hgbot | Note Added: 0134523 | |
| 2022-01-24 14:56 | hgbot | Note Added: 0134524 | |
| 2022-01-24 14:56 | hgbot | Note Added: 0134525 | |
| 2022-01-24 15:07 | hgbot | Status | resolved => closed |
| 2022-01-24 15:07 | hgbot | Note Added: 0134526 | |
| 2022-01-24 15:07 | hgbot | Note Added: 0134527 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |