Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0047969

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Modules] SAP Connector

minor

have not tried

2021-11-03 14:58

2021-11-11 09:39

Reporter

shuehner

View Status

public

Assigned To

caristu

Priority

normal

Resolution

fixed

Fixed in Version

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Regression date

Regression introduced by commit

Regression level

Review Assigned To

Regression introduced in release

Summary

0047969: org.openbravo.service.integration.sapecc use bad debug logging (System.out.println)

Description

That logging looks like developer debugging code.

It should be moved to proper log4j usage to avoid bad code example

Steps To Reproduce

pmods/org.openbravo.service.integration.sapecc/src/org/openbravo/service/integration/sapecc/communication/jco/JCoErrorListener.java: System.out
pmods/org.openbravo.service.integration.sapecc/src/org/openbravo/service/integration/sapecc/communication/jco/JCoErrorListener.java: System.out
pmods/org.openbravo.service.integration.sapecc/src/org/openbravo/service/integration/sapecc/communication/jco/JCoTidHandler.java: System.out.println("checkTID called for TID=" + tid);
pmods/org.openbravo.service.integration.sapecc/src/org/openbravo/service/integration/sapecc/communication/jco/JCoTidHandler.java: System.out.println("commit called for TID=" + tid);
pmods/org.openbravo.service.integration.sapecc/src/org/openbravo/service/integration/sapecc/communication/jco/JCoTidHandler.java: System.out.println("confirmTID called for TID=" + tid);
pmods/org.openbravo.service.integration.sapecc/src/org/openbravo/service/integration/sapecc/communication/jco/JCoTidHandler.java: System.out.print("rollback called for TID=" + tid);

Tags

No tags attached.

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

design defect

acknowledged

Triage Platform Base

Openbravo ERP

clean up openbravo.log

Notes
(0132895) hgbot (developer) 2021-11-09 09:18	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.sapecc/-/merge_requests/3 [^]

(0132954) hgbot (developer) 2021-11-11 09:39	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.sapecc [^] Changeset: 88963a4cca21a26aab49de564a030fd2b8bef3b9 Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 2021-11-09T09:15:52+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.sapecc/-/commit/88963a4cca21a26aab49de564a030fd2b8bef3b9 [^] fixes ISSUE-47969: use correct way of logging --- M src/org/openbravo/service/integration/sapecc/communication/jco/JCoErrorListener.java M src/org/openbravo/service/integration/sapecc/communication/jco/JCoTidHandler.java ---

(0132955) hgbot (developer) 2021-11-11 09:39	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.sapecc/-/merge_requests/3 [^]

Issue History
Date Modified	Username	Field	Change
2021-11-03 14:58	shuehner	New Issue
2021-11-03 14:58	shuehner	Assigned To	=> platform
2021-11-03 14:58	shuehner	Relationship added	blocks 0036162
2021-11-05 09:12	alostale	Assigned To	platform => caristu
2021-11-09 09:18	hgbot	Note Added: 0132895
2021-11-11 09:39	hgbot	Resolution	open => fixed
2021-11-11 09:39	hgbot	Status	new => closed
2021-11-11 09:39	hgbot	Note Added: 0132954
2021-11-11 09:39	hgbot	Note Added: 0132955

Copyright © 2000 - 2009 MantisBT Group