Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0047968 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Web POS | minor | have not tried | 2021-11-03 14:55 | 2021-12-10 07:51 | |||
Reporter | shuehner | View Status | public | |||||
Assigned To | rqueralta | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0047968: org.openbravo.retail.avalaraconnector: uses bad logging (System.out.println and printStrace | |||||||
Description | The PreOrderLoader has apparently some leftover developer debugging code https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.avalaraconnector/-/blob/master/src/org/openbravo/retail/avalaraconnector/hooks/PreOrderLoader.java#L40 [^] That should either be deleted to not have bad code example or alternatively moved to be log4j.debug also is uses printStrace in 2 catch blocks to be moved to log4j.error | |||||||
Steps To Reproduce | https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.avalaraconnector/-/blob/master/src/org/openbravo/retail/avalaraconnector/hooks/PreOrderLoader.java#L40 [^] pmods/org.openbravo.retail.avalaraconnector/src/org/openbravo/retail/avalaraconnector/edl/OBAVCODataProcessor.java: e.printStackTrace(); pmods/org.openbravo.retail.avalaraconnector/src/org/openbravo/retail/avalaraconnector/edl/OBAVCODataProcessor.java: e.printStackTrace(); | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |||||||||
|
Notes | |
(0133593) hgbot (developer) 2021-12-10 04:18 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.avalaraconnector/-/merge_requests/1 [^] |
(0133594) hgbot (developer) 2021-12-10 07:51 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.avalaraconnector [^] Changeset: e7bcd02fc193956323c14a1793a4ed675cebd570 Author: Rafael Queralta <rafaelcuba81@gmail.com> Date: 2021-12-09T14:53:26-05:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.avalaraconnector/-/commit/e7bcd02fc193956323c14a1793a4ed675cebd570 [^] Fixed BUG-47968: Removed bad logging and replace printStrace by log4j.error --- M src/org/openbravo/retail/avalaraconnector/edl/OBAVCODataProcessor.java M src/org/openbravo/retail/avalaraconnector/hooks/PreOrderLoader.java --- |
(0133595) hgbot (developer) 2021-12-10 07:51 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.avalaraconnector/-/merge_requests/1 [^] |
Issue History | |||
Date Modified | Username | Field | Change |
2021-11-03 14:55 | shuehner | New Issue | |
2021-11-03 14:55 | shuehner | Assigned To | => Retail |
2021-11-03 14:55 | shuehner | Triggers an Emergency Pack | => No |
2021-11-03 14:56 | shuehner | Relationship added | blocks 0036162 |
2021-11-03 15:01 | shuehner | Summary | org.openbravo.retail.avalaraconnector: uses bad logging (System.out.println in commented out code) => org.openbravo.retail.avalaraconnector: uses bad logging (System.out.println and printStrace |
2021-11-03 15:01 | shuehner | Description Updated | View Revisions |
2021-11-03 15:01 | shuehner | Steps to Reproduce Updated | View Revisions |
2021-11-04 08:17 | marvintm | Status | new => scheduled |
2021-11-04 08:17 | marvintm | Assigned To | Retail => justin_patterson |
2021-11-10 15:54 | marvintm | Assigned To | justin_patterson => Retail |
2021-11-16 16:42 | rqueralta | Assigned To | Retail => rqueralta |
2021-11-26 07:57 | marvintm | Status | scheduled => acknowledged |
2021-11-26 07:57 | marvintm | Status | acknowledged => scheduled |
2021-11-26 07:57 | marvintm | Status | scheduled => feedback |
2021-11-26 07:58 | marvintm | Assigned To | rqueralta => Retail |
2021-11-26 07:58 | marvintm | Status | feedback => new |
2021-12-01 15:58 | rqueralta | Assigned To | Retail => rqueralta |
2021-12-10 04:18 | hgbot | Note Added: 0133593 | |
2021-12-10 07:51 | hgbot | Resolution | open => fixed |
2021-12-10 07:51 | hgbot | Status | new => closed |
2021-12-10 07:51 | hgbot | Note Added: 0133594 | |
2021-12-10 07:51 | hgbot | Note Added: 0133595 |
Copyright © 2000 - 2009 MantisBT Group |