Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0047922 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] Core | major | have not tried | 2021-10-22 13:18 | 2021-11-18 16:24 | |||
| Reporter | javierRodriguez | View Status | public | |||||
| Assigned To | jarmendariz | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0047922: BaseKeypad only accept integers and decimal values | |||||||
| Description | Due to some changes in BaseKeypad, this component only accept integer and decimal numbers. Previously, this component had the capacity to print any value (numbers or characters) so, for example, it was possible to create different keypads to allow different kind of values like fractions. | |||||||
| Steps To Reproduce | Check the validation in BaseKeypad component | |||||||
| Proposed Solution | Refactor BaseKeypad to just give us the UI and change ComposedKeymad to have the validation which is currently in BaseKeypad to only allow integers and decimals. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0132767) hgbot (developer) 2021-10-29 17:01 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/659 [^] |
|
(0132909) hgbot (developer) 2021-11-09 11:40 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/730 [^] |
|
(0133177) hgbot (developer) 2021-11-18 15:45 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 9511c8d94f6d633e79d58ee7e264ba4716d753df Author: Javier Armendáriz <javier.armendariz@openbravo.com> Date: 2021-11-18T15:03:54+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/9511c8d94f6d633e79d58ee7e264ba4716d753df [^] Related to ISSUE-47922: Adding input validation to inputs that requires it after refactor --- M web-jspack/org.openbravo.pos2/src/components/Cashup/CountingToolDialog/CountingTool/AddRowPopover/AddRowPopover.jsx M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentKeypad/PaymentKeypad.jsx --- |
|
(0133178) hgbot (developer) 2021-11-18 15:45 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/730 [^] |
|
(0133193) hgbot (developer) 2021-11-18 16:24 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: 49e783307db20b66cc0196485f645d80899ee13c Author: Javier Armendáriz <javier.armendariz@openbravo.com> Date: 2021-11-18T16:20:07+01:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/49e783307db20b66cc0196485f645d80899ee13c [^] Fixed ISSUE-47922: Refactored BaseKeypad to not to process values received on input --- M web-jspack/org.openbravo.core2/src/components/BaseKeypad/BaseKeypad.jsx M web-jspack/org.openbravo.core2/src/components/ComposedKeypad/ComposedKeypad.jsx --- |
|
(0133194) hgbot (developer) 2021-11-18 16:24 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/659 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-10-22 13:18 | javierRodriguez | New Issue | |
| 2021-10-22 13:18 | javierRodriguez | Assigned To | => platform |
| 2021-10-22 13:18 | javierRodriguez | Triggers an Emergency Pack | => No |
| 2021-10-25 11:21 | guilleaer | Status | new => acknowledged |
| 2021-10-29 17:01 | hgbot | Note Added: 0132767 | |
| 2021-11-05 00:29 | guilleaer | Status | acknowledged => scheduled |
| 2021-11-05 00:29 | guilleaer | Assigned To | platform => jarmendariz |
| 2021-11-09 11:40 | hgbot | Note Added: 0132909 | |
| 2021-11-18 15:45 | hgbot | Note Added: 0133177 | |
| 2021-11-18 15:45 | hgbot | Note Added: 0133178 | |
| 2021-11-18 16:24 | hgbot | Resolution | open => fixed |
| 2021-11-18 16:24 | hgbot | Status | scheduled => closed |
| 2021-11-18 16:24 | hgbot | Note Added: 0133193 | |
| 2021-11-18 16:24 | hgbot | Note Added: 0133194 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |