0047771: Remove usages of menuItemPosition

Description

As part of 0047516 and 0047506, a positionInMenu variable were added to be able to identify more reliably a product within a menu, but there are places where the old menuItemPosition is still used and it'd be nice to refactor this code to use only one position variable.

Steps To Reproduce

See changeset of 0047516 and 0047506 and look for places where we still use menuItemPosition and try removing it.

Proposed Solution

Try to use the output of getSelectedProductsByCategory(menuItems) instead of Ticket.line.menuItems directly because in this structure we have a positionInMenu property associated to each product and we will take into consideration the 'gaps' when no product is selected for a menu slot.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0047516		closed	jarmendariz	Editing a product configuration on a duplicated menu item, will apply it always to the last one
depends on	defect	0047506		closed	jarmendariz	Duplicated menu items in a menu sometimes don't allow opening the popover of the item

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2021-09-28 17:20	jarmendariz	New Issue
2021-09-28 17:20	jarmendariz	Assigned To	=> Retail
2021-09-28 17:20	jarmendariz	Triggers an Emergency Pack	=> No
2021-09-28 17:20	jarmendariz	Relationship added	related to 0047516
2021-09-28 17:21	jarmendariz	Relationship added	depends on 0047506
2021-10-18 11:27	guilleaer	Status	new => acknowledged
2024-01-04 07:17	Daria_Sh	Issue Monitored: Daria_Sh
2024-01-04 07:17	Daria_Sh	Issue End Monitor: Daria_Sh