Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0047754 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [POS2] POS | major | always | 2021-09-24 10:40 | 2022-05-24 09:31 | |||
Reporter | jmelin | View Status | public | |||||
Assigned To | AtulOpenbravo | |||||||
Priority | high | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0047754: JIRA 707 - Product are grouped when "Consolidate" is not checked | |||||||
Description | When, at Org level, the "Consolidate products in Buy template" or "Consolidate products in Buy template" is not checked we should print one ticket per product/quantity. | |||||||
Steps To Reproduce | If I have the following products with notification : - 2 product A (prepare ticket link to HMW A) - 1 product B (prepare ticket link to HMW B) If "Consolidate products in Buy template" is not checked Then we print 1 ticket for each product A and 1 ticket for product B (3 tickets in total) If "Consolidate products in Buy template" is checked Then we print 1 ticket for all the products If "Consolidate products in Prepare template" is not checked Then we print 1 ticket for each product A and 1 ticket for product B (3 tickets in total on their respective HMW configured) If "Consolidate products in Prepare template" is checked Then we print 1 ticket per HMW linked (1 ticket on HMW A with all product A and 1 ticket on HMW B with all product B) | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | ||||||||
|
Notes | |
(0132100) hgbot (developer) 2021-10-01 14:22 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/692 [^] |
(0132101) AtulOpenbravo (developer) 2021-10-01 14:39 |
Test Plan - Configure following products with notification : - Cheese Cake with HMW A - Brownie with HMW A - Carbonara Pizza with HWM B - Set Vall Blanca Store with "Consolidate products in Buy template" = No - Create ticket and add above all products with below quantities - Cheese Cake 2 - Brownie 1 - Carbonara Pizza 2 Pay and Complete the ticket. - Realize that local printer has 5 notification tickets with below product and quantities - Ticket 1 - Cheese Cake Qty 1 - Ticket 2 - Cheese Cake Qty 1 - Ticket 3 - Brownie Qty 1 - Ticket 4 - Carbonara Pizza Qty 1 - Ticket 5 - Carbonara Pizza Qty 1 - Set Vall Blanca Store with "Consolidate products in Buy template" = Yes - Create ticket and add above all products with below quantities - Cheese Cake 2 - Brownie 1 - Carbonara Pizza 2 Pay and Complete the ticket. - Realize that local printer has 2 notification tickets with below product and quantities - Ticket 1 - Cheese Cake Qty 2 - - Brownie Qty 1 - Ticket 2 - Carbonara Pizza Qty 2 - Set Vall Blanca Store with "Consolidate products in Prepare template" = No - Realize that HWM A has 3 notification tickets with below product and quantities - Ticket 1 - Cheese Cake Qty 1 - Ticket 2 - Cheese Cake Qty 1 - Ticket 3 - Brownie Qty 1 - Realize that HWM B has 2 notification tickets with below product and quantities - Ticket 1 - Carbonara Pizza Qty 1 - Ticket 2 - Carbonara Pizza Qty 1 - Set Vall Blanca Store with "Consolidate products in Prepare template" = Yes - Realize that HWM A has 2 notification tickets with below product and quantities - Ticket 1 - Cheese Cake Qty 2 - Brownie Qty 1 - Realize that HWM B has 1 notification tickets with below product and quantities - Ticket 1 - Carbonara Pizza Qty 2 |
(0132179) hgbot (developer) 2021-10-06 07:46 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/80 [^] |
(0132217) hgbot (developer) 2021-10-07 07:07 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 55d6d65cdb3a96324feb8373d3f4ff9b6f399d76 Author: Atul Gaware <atul.gaware@openbravo.com> Date: 2021-10-07T10:36:23+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/55d6d65cdb3a96324feb8373d3f4ff9b6f399d76 [^] Fixes BUG-0047754: JIRA 707 - Product are grouped when "Consolidate" is not checked **In CompleteTicketAction preparation, payload has information about consolidated as well as non consolidated products in productNotifications object, this information is passed to getLocalPrintNotifications func inorder to have proper notification tickets as per consolidation flag set in Store. **Unlike remote hardware manager notification tickets, hardware manager wise separate tickets are created using buy templates. --- M web-jspack/org.openbravo.pos2/src/model/ticket/actions/CompleteTicketActionPreparation.js M web-jspack/org.openbravo.pos2/src/services/pager/PagerUtils.js --- |
(0132218) hgbot (developer) 2021-10-07 07:07 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 74cbb1833df647543b65414c2be981fb08c60e49 Author: Martin Taal <martin.taal@openbravo.com> Date: 2021-10-07T10:36:23+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/74cbb1833df647543b65414c2be981fb08c60e49 [^] Fixes BUG-0047754: code review --- M web-jspack/org.openbravo.pos2/src/model/ticket/actions/CompleteTicketActionPreparation.js M web-jspack/org.openbravo.pos2/src/model/ticket/actions/GetProductNotificationMessages.js --- |
(0132219) hgbot (developer) 2021-10-07 07:07 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: a41d9fe8bdced050362b4df4fd6224275b4d93f9 Author: Atul Gaware <atul.gaware@openbravo.com> Date: 2021-10-07T10:36:23+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/a41d9fe8bdced050362b4df4fd6224275b4d93f9 [^] Related to BUG-0047754: JIRA 707 - Product are grouped when "Consolidate" is not checked **In order to print local message when generate notification flag is set as Yes and notification tab is empty, use hardwareURL as LocalMsgsOnly **Avoid remote messages when URL is set as LocalMsgsOnly **Handle menu products properly in CompleteTicketActionPreparation when printline data is received from RestaurantPagerUtils --- M web-jspack/org.openbravo.pos2/src/model/ticket/actions/CompleteTicketActionPreparation.js M web-jspack/org.openbravo.pos2/src/model/ticket/actions/GetProductNotificationMessages.js --- |
(0132220) hgbot (developer) 2021-10-07 07:07 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 04b6de2f68317115e5ee16bcd721ce66d43e18b7 Author: Atul Gaware <atul.gaware@openbravo.com> Date: 2021-10-07T10:36:23+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/04b6de2f68317115e5ee16bcd721ce66d43e18b7 [^] Related To BUG-0047754: JIRA 707 - Product are grouped when "Consolidate" is not checked **Fix product notification tests by removing menu products from POS2 module and move them to Restaurant module --- M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/ProductNotification.test.js --- |
(0132221) hgbot (developer) 2021-10-07 07:07 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: dd020488367195f6b16d395e92cd99c317cad688 Author: Atul Gaware <atul.gaware@openbravo.com> Date: 2021-10-07T10:36:23+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/dd020488367195f6b16d395e92cd99c317cad688 [^] Related To BUG-0047754: JIRA 707 - Product are grouped when "Consolidate" is not checked **Move local msg generation in GetProductNotificationMessages from PagerUtils **Cleanup code by removing TODO comments --- M web-jspack/org.openbravo.pos2/src/model/ticket/ProductNotificationTicketExtension.js M web-jspack/org.openbravo.pos2/src/model/ticket/actions/CompleteTicketActionPreparation.js M web-jspack/org.openbravo.pos2/src/model/ticket/actions/GetProductNotificationMessages.js M web-jspack/org.openbravo.pos2/src/services/pager/PagerUtils.js --- |
(0132222) hgbot (developer) 2021-10-07 07:07 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: a7533c2fc2ea6d9a37490358106dff1a7424e1ff Author: Atul Gaware <atul.gaware@openbravo.com> Date: 2021-10-07T10:36:23+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/a7533c2fc2ea6d9a37490358106dff1a7424e1ff [^] Related To BUG-0047754: JIRA 707 - Product are grouped when "Consolidate" is not checked **Fix product notification tests, **Add test to avoid local and remote notification msgs when buy/ prepare templates are not configured. **Add test when only notification flag is set as Yes and notification setting is not configured, in this case only generates local msg. **Avoid remote msgs if prepare template is not configured. --- M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/ProductNotification.test.js M web-jspack/org.openbravo.pos2/src/model/ticket/actions/GetProductNotificationMessages.js --- |
(0132228) hgbot (developer) 2021-10-07 07:42 |
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/692 [^] |
(0132230) hgbot (developer) 2021-10-07 09:14 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^] Changeset: b3d4bfe7f1756ed8949932d75264bbf2b0affb0a Author: Atul Gaware <atul.gaware@openbravo.com> Date: 2021-10-07T12:43:08+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/b3d4bfe7f1756ed8949932d75264bbf2b0affb0a [^] Related To BUG-0047754: JIRA 707 - Product are grouped when "Consolidate" is not checked **Moved tests related to mdenu products in Restaurant Module --- A web-jspack/org.openbravo.pos2.restaurant/src/model/ticket/actions/__test__/MenuProductNotification.test.js --- |
(0132231) hgbot (developer) 2021-10-07 09:14 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^] Changeset: 1f7afb0195fce391916693c484d0bd6da6fd5386 Author: Martin Taal <martin.taal@openbravo.com> Date: 2021-10-07T12:43:08+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/1f7afb0195fce391916693c484d0bd6da6fd5386 [^] Related to ISSUE-47754: use id of menuItem product --- M web-jspack/org.openbravo.pos2.restaurant/src/services/pager/RestaurantPagerUtils.js --- |
(0132232) hgbot (developer) 2021-10-07 09:14 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^] Changeset: 31361aa31e03c03a9a59814953773346e68a029c Author: atul.gaware <atul.gaware@openbravo.com> Date: 2021-10-07T12:43:08+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/31361aa31e03c03a9a59814953773346e68a029c [^] Revert "Related to ISSUE-47754: use id of menuItem product" This reverts commit 77de933ccdfb85a70743762ea65479abac86ec3f. --- M web-jspack/org.openbravo.pos2.restaurant/src/services/pager/RestaurantPagerUtils.js --- |
(0132233) hgbot (developer) 2021-10-07 09:14 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^] Changeset: d9240b93d0323b2ea845a431ab6e1282e944d530 Author: Atul Gaware <atul.gaware@openbravo.com> Date: 2021-10-07T12:43:08+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/d9240b93d0323b2ea845a431ab6e1282e944d530 [^] Related To BUG-0047754: JIRA 707 - Product are grouped when "Consolidate" is not checked **Remove menuProductId from printLines data object inorder to fetch the notification configuration for menuItem product --- M web-jspack/org.openbravo.pos2.restaurant/src/services/pager/RestaurantPagerUtils.js --- |
(0137660) hgbot (developer) 2022-05-24 09:31 |
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/80 [^] |
Issue History | |||
Date Modified | Username | Field | Change |
2021-09-24 10:40 | jmelin | New Issue | |
2021-09-24 10:40 | jmelin | Assigned To | => Retail |
2021-09-24 10:40 | jmelin | Triggers an Emergency Pack | => No |
2021-10-01 09:17 | AtulOpenbravo | Assigned To | Retail => AtulOpenbravo |
2021-10-01 09:17 | AtulOpenbravo | Status | new => scheduled |
2021-10-01 14:22 | hgbot | Note Added: 0132100 | |
2021-10-01 14:39 | AtulOpenbravo | Note Added: 0132101 | |
2021-10-06 07:46 | hgbot | Note Added: 0132179 | |
2021-10-06 09:57 | AtulOpenbravo | Status | scheduled => feedback |
2021-10-06 09:57 | AtulOpenbravo | Status | feedback => scheduled |
2021-10-07 07:07 | hgbot | Resolution | open => fixed |
2021-10-07 07:07 | hgbot | Status | scheduled => closed |
2021-10-07 07:07 | hgbot | Note Added: 0132217 | |
2021-10-07 07:07 | hgbot | Note Added: 0132218 | |
2021-10-07 07:07 | hgbot | Note Added: 0132219 | |
2021-10-07 07:07 | hgbot | Note Added: 0132220 | |
2021-10-07 07:07 | hgbot | Note Added: 0132221 | |
2021-10-07 07:07 | hgbot | Note Added: 0132222 | |
2021-10-07 07:42 | hgbot | Note Added: 0132228 | |
2021-10-07 09:14 | hgbot | Note Added: 0132230 | |
2021-10-07 09:14 | hgbot | Note Added: 0132231 | |
2021-10-07 09:14 | hgbot | Note Added: 0132232 | |
2021-10-07 09:14 | hgbot | Note Added: 0132233 | |
2022-05-24 09:31 | hgbot | Note Added: 0137660 |
Copyright © 2000 - 2009 MantisBT Group |