Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0047753 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] Core | major | always | 2021-09-24 10:29 | 2021-09-27 13:51 | |||
| Reporter | vmromanos | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0047753: POS2 only: component providers declared within a JAR are not detected | |||||||
| Description | When a component provider is declared into src/ (normal escenario), the POS 2 compilation process properly detects it. However, if the same component provider is distributed under a compiled JAR file in lib/runtime/, it's not detected by the compilation process and the js resources are not considered. In old POS the component providers in a JAR file were properly detected (because we used CDI in tomcat). | |||||||
| Steps To Reproduce | In a POS 2 environment: Clone the https://gitlab.com/openbravo/product/pmods/org.openbravo.certification.france [^] in release/20Q4 branch, which is ready to work with POS 2 Clone also its dependency https://gitlab.com/openbravo/product/mods/org.openbravo.utility.opencsv [^] Run ant smartbuild -Dlocal=no In core2 folder run "ant" Restart tomcat Try to login into the new POS (either using tomcat or the development server). An error is raised because some of the JS in the french fiscal module are not found. | |||||||
| Proposed Solution | Instead of looking at the src/ folder, try to find the Component Providers available in the classpath. https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/src/org/openbravo/core2/build/ModuleInfoGenerator.java#L358 [^] | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0132013) hgbot (developer) 2021-09-27 11:33 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/637 [^] |
|
(0132028) hgbot (developer) 2021-09-27 13:51 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/637 [^] |
|
(0132029) hgbot (developer) 2021-09-27 13:51 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: 731fcd0c4f9112c6c43a7d46b81fa20b5d876639 Author: Asier Lostalé <asier.lostale@openbravo.com> Date: 2021-09-27T11:51:11+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/731fcd0c4f9112c6c43a7d46b81fa20b5d876639 [^] fixed ISSUE-47753: ComponentProviders within jars are not included ComponentProviders that were deployed in jars were not included in generated JavaScript. In POS1, ComponentProviders are injected by CDI at runtime, POS2 requieres them at build time when there is no CDI. It was checking java files within src directory which does not handle jars. This has been replaced by looking at the classpath including both compiled classes in build/classes and any jar from modules/**/lib/runtime. --- M src/org/openbravo/core2/build/ModuleInfoGenerator.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-09-24 10:29 | vmromanos | New Issue | |
| 2021-09-24 10:29 | vmromanos | Assigned To | => alostale |
| 2021-09-24 10:29 | vmromanos | Triggers an Emergency Pack | => No |
| 2021-09-27 11:33 | hgbot | Note Added: 0132013 | |
| 2021-09-27 13:51 | hgbot | Note Added: 0132028 | |
| 2021-09-27 13:51 | hgbot | Resolution | open => fixed |
| 2021-09-27 13:51 | hgbot | Status | new => closed |
| 2021-09-27 13:51 | hgbot | Note Added: 0132029 | |
| 2021-09-27 15:11 | alostale | Relationship added | has duplicate 0047752 |
| 2021-09-28 08:14 | alostale | Relationship added | related to 0047763 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |