Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0047670
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Discounts and Promotionsmajoralways2021-09-10 12:092021-09-15 16:22
ReporterjetxarriView Statuspublic 
Assigned Torqueralta 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0047670: Backend discounts executor not ordering properly the discount rules

DescriptionBackend discounts executor not ordering properly the discount rules.

Null values should go first and with same priority, should be ordered by id.

 * OB.Discounts.Pos.ruleImpls: array with not manual discounts and promotions including children filters, filtered by current role and sorted by priority and id (null priorities first).
Steps To Reproduce-Create 2 discounts
-First discount priority 10
-Second one priority null

Go to web pos and create a ticket that applies 2 discounts. Discount without priority is applied first and later the other one

Use the endpoint ../ws/org.openbravo.discounts.discount. Discount with priority is applied first and later the other one
Proposed SolutionAttached file
TagsNOR
Attached Filesdiff file icon patch.diff [^] (1,050 bytes) 2021-09-10 12:09 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0131780)
hgbot (developer)
2021-09-14 13:08

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/merge_requests/11 [^]
(0131822)
hgbot (developer)
2021-09-15 16:22

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/merge_requests/11 [^]
(0131823)
hgbot (developer)
2021-09-15 16:22

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts [^]
Changeset: 9a0758229ea5a0de988086e1546dda1517269570
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 2021-09-14T07:06:03-04:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts/-/commit/9a0758229ea5a0de988086e1546dda1517269570 [^]

Fixed BUG-47670: Filtered by current role and sorted by priority and id

---
M src/org/openbravo/discounts/engine/DiscountJSExecutor.java
---

- Issue History
Date Modified Username Field Change
2021-09-10 12:09 jetxarri New Issue
2021-09-10 12:09 jetxarri Assigned To => Retail
2021-09-10 12:09 jetxarri File Added: patch.diff
2021-09-10 12:09 jetxarri Triggers an Emergency Pack => No
2021-09-10 12:10 jetxarri Tag Attached: NOR
2021-09-13 21:02 rqueralta Assigned To Retail => rqueralta
2021-09-13 21:02 rqueralta Status new => scheduled
2021-09-14 13:08 hgbot Note Added: 0131780
2021-09-15 16:22 hgbot Note Added: 0131822
2021-09-15 16:22 hgbot Resolution open => fixed
2021-09-15 16:22 hgbot Status scheduled => closed
2021-09-15 16:22 hgbot Note Added: 0131823


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker