0047603: Error when there is a price adjustment discount of 0

Description

When there is a bad configuration and user leaves 0 in the configuration of a price adjustemnt discount, when doing a verified return there is a red error in WEBPOs

Video: https://drive.google.com/file/d/1ZfYjBzSg-CeKbuX7fFfVcRaXwChZKhGv/view [^]

Happens in 19Q3 version

Steps To Reproduce

1. Have a price adjustemnt discount of 0
2. Add product in webpos and pay it
3. Do a verified return of above ticket, see red error:

https://drive.google.com/file/d/1ZfYjBzSg-CeKbuX7fFfVcRaXwChZKhGv/view [^]

Tags

No tags attached.

Attached Files

Fix-BUG-47603.patch [^] (1,012 bytes) 2021-09-25 13:11 [Show Content] [Hide Content]

From 0053bfed2470bcd78dd9b7a32d3db058c78592a0 Mon Sep 17 00:00:00 2001
From: Rafael Queralta <rafaelcuba81@gmail.com>
Date: Sat, 25 Sep 2021 07:09:05 -0400
Subject: [PATCH] Fix BUG-47603: Take into account amt value if
 displayedTotalAmount is undefined

---
 web/org.openbravo.retail.returns/js/modalReturnLines.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/web/org.openbravo.retail.returns/js/modalReturnLines.js b/web/org.openbravo.retail.returns/js/modalReturnLines.js
index 66fa163..c15feb0 100644
--- a/web/org.openbravo.retail.returns/js/modalReturnLines.js
+++ b/web/org.openbravo.retail.returns/js/modalReturnLines.js
@@ -152,7 +152,7 @@
                 me.$.quantity.getValue() / initialQty
               );
               p.displayedTotalAmount = OB.DEC.mul(
-                p.displayedTotalAmount,
+                p.displayedTotalAmount ? p.displayedTotalAmount : p.amt,
                 me.$.quantity.getValue() / initialQty
               );
             }
-- 
2.28.0

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0132005) rqueralta (viewer) 2021-09-25 13:12	Issue not reproducible in PI, attached fix for 19Q3

(0132011) marvintm (viewer) 2021-09-27 08:43	Issue doesn't happen in master. We have attached a patch for 19Q3.

Issue History
Date Modified	Username	Field	Change
2021-08-30 09:28	lmonreal	New Issue
2021-08-30 09:28	lmonreal	Assigned To	=> Retail
2021-08-30 09:28	lmonreal	OBNetwork customer	=> Gold
2021-08-30 09:28	lmonreal	Triggers an Emergency Pack	=> No
2021-08-30 09:28	lmonreal	Description Updated	View Revisions
2021-09-20 12:38	rqueralta	Assigned To	Retail => rqueralta
2021-09-20 12:38	rqueralta	Status	new => scheduled
2021-09-25 13:11	rqueralta	File Added: Fix-BUG-47603.patch
2021-09-25 13:12	rqueralta	Note Added: 0132005
2021-09-27 08:43	marvintm	Review Assigned To	=> marvintm
2021-09-27 08:43	marvintm	Note Added: 0132011
2021-09-27 08:43	marvintm	Status	scheduled => closed
2021-09-27 08:43	marvintm	Resolution	open => no change required