Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0047474 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | major | have not tried | 2021-07-29 19:11 | 2021-08-13 07:03 | |||
| Reporter | cberner | View Status | public | |||||
| Assigned To | Retail | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0047474: Completing a quotation is not persisted in backoffice and not available in Orders window | |||||||
| Description | When a quotation is completed, it should be persisted in backoffice, so when you close it, it is available in Orders window and in the backoffice to open again. This is probably a regression. An error appears in backoffice in Errors while importing POS Data, as part of this: "org.openbravo.base.exception.OBException: Error in OrderLoader: null at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:486)" | |||||||
| Steps To Reproduce | 1. Open and login in WebPOS 2. Click on ... button and "New Quotation" 3. Add a product to the ticket 4. Click on "Complete" and then on "Close Quotation" Check Orders window, and see that the created quotation is not there. Check backoffice and go to "Errors while importing POS Data", an error will be there, related to this quotation. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0130894) jorge-garcia (reporter) 2021-07-30 12:05 edited on: 2021-07-30 12:13 |
This issue is a regression introduced by the solution of issue 47350. The problem is located in TicketExtesion.js file from org.openbravo.pos2 module at line 51: OB.App.StateAPI.Global.completeQuotation.addPreHook(setIsPaid); Once a quotation is complete, we CANNOT set the quotation as "isPaid: true". If so, the OrderLoader thinks this document exists already in the database and tries to modify it (causing finally the error reported). The OrderLoader error is raised at line 371-372: order = OBDal.getInstance().get(Order.class, jsonorder.getString("id")); order.setDelivered(deliver); In the old POS, the decision to indicate in the UI if a quotation was in status draft or under evaluation was made checking the attribute "hasbeenpaid" instead of the "isPaid" arrtibute. |
|
(0131079) hgbot (developer) 2021-08-12 03:36 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/657 [^] |
|
(0131103) hgbot (developer) 2021-08-12 13:42 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: b650c71e0bfd7d3a2bc9646376644bf6b17fadc3 Author: hernan-dp <hernan.de.prada@smfconsulting.es> Date: 2021-08-12T08:32:51-03:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/b650c71e0bfd7d3a2bc9646376644bf6b17fadc3 [^] fixes ISSUE-47474: Removed setPaid from ticket that made it not store in backoffice. --- M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js --- |
|
(0131104) hgbot (developer) 2021-08-12 13:42 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/657 [^] |
|
(0131105) hgbot (developer) 2021-08-13 07:03 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 100ab8d470282e4cac0cf6dec719eeb48533e4ec Author: Antonio Moreno <anmorenoperez@gmail.com> Date: 2021-08-13T07:03:25+02:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/100ab8d470282e4cac0cf6dec719eeb48533e4ec [^] Related to ISSUE-47474: remove unused setIsPaid import --- M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-07-29 19:11 | cberner | New Issue | |
| 2021-07-29 19:11 | cberner | Assigned To | => Retail |
| 2021-07-29 19:11 | cberner | Triggers an Emergency Pack | => No |
| 2021-07-30 09:04 | dmiguelez | Resolution time | => 1628805600 |
| 2021-07-30 09:04 | dmiguelez | Status | new => acknowledged |
| 2021-07-30 12:00 | jorge-garcia | Relationship added | caused by 0047350 |
| 2021-07-30 12:05 | jorge-garcia | Note Added: 0130894 | |
| 2021-07-30 12:09 | jorge-garcia | Note Edited: 0130894 | View Revisions |
| 2021-07-30 12:13 | jorge-garcia | Note Edited: 0130894 | View Revisions |
| 2021-08-06 11:33 | dmiguelez | Resolution time | 1628805600 => 1629410400 |
| 2021-08-12 03:36 | hgbot | Note Added: 0131079 | |
| 2021-08-12 13:42 | hgbot | Resolution | open => fixed |
| 2021-08-12 13:42 | hgbot | Status | acknowledged => closed |
| 2021-08-12 13:42 | hgbot | Note Added: 0131103 | |
| 2021-08-12 13:42 | hgbot | Note Added: 0131104 | |
| 2021-08-13 07:03 | hgbot | Note Added: 0131105 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |