Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0047386
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Send By Emailmajoralways2021-07-13 14:352021-07-22 18:48
Reporterandrea_lopezView Statuspublic 
Assigned Torqueralta 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0047386: "Send E-mail" pop-up shows up after failure to finish payment.

DescriptionWhen using the 'Send email from web POS' module, create a ticket with a partial payment and try to finish it, the popup "Send email" is shown even though the ticket has not been completed and it should not been shown.
Steps To ReproduceInstall the Send email from web POS module (org.openbravo.retail.sendemail)
Configure an smtp server to be able to send emails (on the Client window)
Configure a customer to receive invoices via email, and configure the Touchpoint Type to send emails.

Create a ticket in Web POS, select a customer, add a product, and make a partial payment.
Click: Done and then Open.
An error popup will appear stating that is not possible to continue, click "Ok".
It should return to the ticket to either complete the payment or Delete the receipt, but instead shows the the "Send E- mail" popup.
Proposed SolutionThe popup visibility is managed with a OBPOS_PreOrderSave hook in file:
org.openbravo.retail.sendemail/web/org.openbravo.retail.sendemail/source/obsmail_hook_preordersave.js


A simple solution is to add a check to var: shouldDialogBeDisplayed, to see if the order has a pending amount to pay: currentOrder.getPending(), it is already being done but only for layway (var paidLayaway).
TagsNo tags attached.
Attached Filesdiff file icon 0047386_20Q1_BUT.diff [^] (1,085 bytes) 2021-07-14 14:19 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0130474)
andrea_lopez (developer)
2021-07-14 14:20

Attached diff for proposed solution
(0130675)
hgbot (developer)
2021-07-21 19:56

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/merge_requests/3 [^]
(0130706)
hgbot (developer)
2021-07-22 18:48

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail [^]
Changeset: e53eeb1a5a996e7cccc71facd120207c27140910
Author: Rafael Queralta <rafaelcuba81@gmail.com>
Date: 2021-07-20T23:57:54-04:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/commit/e53eeb1a5a996e7cccc71facd120207c27140910 [^]

Fixed BUG-47386: "Send E-mail" pop-up shows up after failure to finish payment

---
M web/org.openbravo.retail.sendemail/source/obsmail_hook_preordersave.js
---
(0130707)
hgbot (developer)
2021-07-22 18:48

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sendemail/-/merge_requests/3 [^]

- Issue History
Date Modified Username Field Change
2021-07-13 14:35 andrea_lopez New Issue
2021-07-13 14:35 andrea_lopez Assigned To => Retail
2021-07-13 14:35 andrea_lopez Triggers an Emergency Pack => No
2021-07-14 14:19 andrea_lopez File Added: 0047386_20Q1_BUT.diff
2021-07-14 14:20 andrea_lopez Note Added: 0130474
2021-07-19 22:51 rqueralta Assigned To Retail => rqueralta
2021-07-19 22:51 rqueralta Status new => scheduled
2021-07-21 19:56 hgbot Note Added: 0130675
2021-07-22 18:48 hgbot Resolution open => fixed
2021-07-22 18:48 hgbot Status scheduled => closed
2021-07-22 18:48 hgbot Note Added: 0130706
2021-07-22 18:48 hgbot Note Added: 0130707


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker