Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0047093
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2021-06-11 19:322021-06-14 07:19
ReportershuehnerView Statuspublic 
Assigned Toplatform 
PrioritynormalResolutionfixedFixed in VersionPR21Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0047093: Remove use of guava library in java code of backoffice

DescriptionDone to prepare eventually removing guava library entirely

List of files referencing it
src-test/src/org/openbravo/test/security/AllowedOrganizationsTest.java
src-test/src/org/openbravo/test/security/CrossOrganizationReference.java
src/org/openbravo/erpCommon/businessUtility/InitialSetupUtility.java
Steps To Reproducegrep -Ir 'com\.google\.common'
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks design defect 0047092 scheduledmeriem_azaf Remove guava library as it is no longer needed as a dependency of weld 

-  Notes
(0129419)
hgbot (developer)
2021-06-11 19:38

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/393 [^]
(0129436)
hgbot (developer)
2021-06-14 07:19

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 70f08e94b3f8fa81238d857aca4d242c2dcd0190
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 2021-06-14T07:17:11+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/70f08e94b3f8fa81238d857aca4d242c2dcd0190 [^]

fixes ISSUE-47093: Remove guava usage from java code

- InitialSetupUtility
  - Stop using Charsets.UTF_8 constants from guava library. Instead use
standard java StandardCharsets class
  - Simplify reading file by using Files.ReadString(Path,Charset)
    directly avoid the intermediate byte[]
- CrossOrganizationReference
  - Use standard Collections.reverse method instead of guava
    Lists.reverse
    Note that JDK function modify the argument in place instead of
returning a 'reversed' view. However with that usage here (cleanup after
unit-tests & .clear()-ing the list just afterwards no need to clone the
list.
- AllowedOrganizationTest
  - Change away from guava ImmutableMap.builder() replace it by standard
    java
    - Map.Of(Key,Value,Key,Value, ...) for the simple case
    - Map.ofEntries for the slightly more complex case.

---
M src-test/src/org/openbravo/test/security/AllowedOrganizationsTest.java
M src-test/src/org/openbravo/test/security/CrossOrganizationReference.java
M src/org/openbravo/erpCommon/businessUtility/InitialSetupUtility.java
---
(0129437)
hgbot (developer)
2021-06-14 07:19

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/393 [^]

- Issue History
Date Modified Username Field Change
2021-06-11 19:32 shuehner New Issue
2021-06-11 19:32 shuehner Assigned To => platform
2021-06-11 19:32 shuehner Modules => Core
2021-06-11 19:32 shuehner Triggers an Emergency Pack => No
2021-06-11 19:38 hgbot Note Added: 0129419
2021-06-11 19:39 shuehner Relationship added blocks 0047092
2021-06-14 07:19 hgbot Resolution open => fixed
2021-06-14 07:19 hgbot Status new => closed
2021-06-14 07:19 hgbot Fixed in Version => PR21Q3
2021-06-14 07:19 hgbot Note Added: 0129436
2021-06-14 07:19 hgbot Note Added: 0129437

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker