0046988: Reproducible in 19Q3 version. Deleted ticket stuck in the EWI because a NaN discount is calculated under some circumstances

From 61aff6c347ef92b40bcc84517bfdd972921d5481 Mon Sep 17 00:00:00 2001
From: Rafael Queralta <rafaelcuba81@gmail.com>
Date: Wed, 14 Jul 2021 08:42:02 -0400
Subject: [PATCH] Fixed BUG-46988: If roundedDiscount variable is undefined,
 amt is equal to 'TotalRoundedDiscount' property value.

---
 .../js/promotion-manual-by-total-utils.js                 | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/web/com.openbravo.decathlon.retail.discounts.bytotal/js/promotion-manual-by-total-utils.js b/web/com.openbravo.decathlon.retail.discounts.bytotal/js/promotion-manual-by-total-utils.js
index bf0a837..3b1b9cd 100644
--- a/web/com.openbravo.decathlon.retail.discounts.bytotal/js/promotion-manual-by-total-utils.js
+++ b/web/com.openbravo.decathlon.retail.discounts.bytotal/js/promotion-manual-by-total-utils.js
@@ -271,7 +271,7 @@ OB.Model.Discounts.DISCT.addTotalManualPercentageDisc = function(
           }
           var definition = {};
           definition.lastApplied = true;
-          definition.amt = roundedDiscount;
+          definition.amt = roundedDiscount || l.line.get('TotalRoundedDiscount');
           definition.discountinstance = ruleFromReceipt.get(
             'rule'
           ).discountinstance;
@@ -314,7 +314,7 @@ OB.Model.Discounts.DISCT.addTotalManualPercentageDisc = function(
                 );
                 var definition = {};
                 definition.lastApplied = true;
-                definition.amt = roundedDiscount;
+                definition.amt = roundedDiscount || l.line.get('TotalRoundedDiscount');
                 definition.discountinstance = ruleFromReceipt.get(
                   'rule'
                 ).discountinstance;
@@ -413,7 +413,7 @@ OB.Model.Discounts.DISCT.addTotalManualAmountDisc = function(
           }
           var definition = {};
           definition.lastApplied = true;
-          definition.amt = roundedDiscount;
+          definition.amt = roundedDiscount || l.line.get('TotalRoundedDiscount');
           definition.discountinstance = ruleFromReceipt.get(
             'rule'
           ).discountinstance;
@@ -456,7 +456,7 @@ OB.Model.Discounts.DISCT.addTotalManualAmountDisc = function(
                 );
                 var definition = {};
                 definition.lastApplied = true;
-                definition.amt = roundedDiscount;
+                definition.amt = roundedDiscount || l.line.get('TotalRoundedDiscount');
                 definition.discountinstance = ruleFromReceipt.get(
                   'rule'
                 ).discountinstance;
-- 
2.28.0