Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0046786
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSminorhave not tried2021-05-21 13:192021-07-29 16:30
ReportercaristuView Statuspublic 
Assigned Tohernan-dp 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0046786: OB.App.State.Configuration.setCurrentWindow should not be directly called

DescriptionWe have different places[1],[2] where the OB.App.State.Configuration.setCurrentWindow state action is being directly called. By doing this all the onExit/onEnter hook execution is skipped because they are fired from the user action layer.

It would be nice to fix all the places doing this call and replace the correct user action to switch the window.

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/SelectCurrentSchema.js#L29 [^]
[2] https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/initialCount/OpenInitialCount.js#L35 [^]
Steps To Reproduce.
Proposed SolutionUse the corresponding user action to navigate to the corresponding window/flow instead of calling OB.App.State.Configuration.setCurrentWindow. See[1]

[1] https://docs.google.com/document/d/1tuGxwiNnThguqkrSfUmv9gktmdjdlWmcIkbTPUhVV3g/edit#heading=h.ap1d4lcsowsb [^]

TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0130765)
hgbot (developer)
2021-07-26 17:48

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/609 [^]
(0130766)
hgbot (developer)
2021-07-26 17:49

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/631 [^]
(0130791)
hgbot (developer)
2021-07-27 12:47

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/609 [^]
(0130792)
hgbot (developer)
2021-07-27 12:48

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/631 [^]
(0130876)
hgbot (developer)
2021-07-29 16:28

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/649 [^]
(0130878)
hgbot (developer)
2021-07-29 16:30

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/649 [^]
(0130879)
hgbot (developer)
2021-07-29 16:30

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 39cdda1af887c96fa1d9929f016e735dba9a95b2
Author: hernan-dp <h.de.prada1@gmail.com>
Date: 2021-07-29T14:30:12+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/39cdda1af887c96fa1d9929f016e735dba9a95b2 [^]

Related to ISSUE-46786: Ejecuted setDefaultAppWindow before rest of login init actions.

---
M web-jspack/org.openbravo.pos2/src/authentication/loginInitActions.js
---

- Issue History
Date Modified Username Field Change
2021-05-21 13:19 caristu New Issue
2021-05-21 13:19 caristu Assigned To => Retail
2021-05-21 13:19 caristu Resolution time => 1625176800
2021-05-21 13:19 caristu Triggers an Emergency Pack => No
2021-05-21 18:22 guilleaer Assigned To Retail => platform
2021-05-21 18:22 guilleaer Status new => acknowledged
2021-07-14 13:26 dmiguelez Resolution time 1625176800 => 1633039200
2021-07-26 17:48 hgbot Note Added: 0130765
2021-07-26 17:49 hgbot Note Added: 0130766
2021-07-27 12:47 hgbot Note Added: 0130791
2021-07-27 12:48 hgbot Note Added: 0130792
2021-07-27 12:48 dmiguelez Status acknowledged => scheduled
2021-07-27 12:48 dmiguelez Assigned To platform => hernan-dp
2021-07-27 12:48 dmiguelez Status scheduled => resolved
2021-07-27 12:48 dmiguelez Resolution open => fixed
2021-07-27 12:48 dmiguelez Status resolved => closed
2021-07-29 16:28 hgbot Note Added: 0130876
2021-07-29 16:30 hgbot Note Added: 0130878
2021-07-29 16:30 hgbot Note Added: 0130879


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker