Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0046681
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2021-05-14 13:402021-05-18 13:57
ReportermarvintmView Statuspublic 
Assigned Tocberner 
PriorityimmediateResolutionfixedFixed in VersionPR21Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression levelProduction - QA Approved
Regression date2020-10-27
Regression introduced in releasePR21Q1
Regression introduced by commithttps://gitlab.com/openbravo/product/openbravo/-/commit/74ec2cdad81aba152fc7a704384cc96836dabde9 [^]
Triggers an Emergency PackNo
Summary

0046681: If a tab has a field for the id of the entity, it is no longer possible to create a new record in form view

DescriptionFor Application Dictionary generated windows, if a tab has a field for the id of the entity, it is no longer possible to create a new record in form view.

An example of this can be found in the "Coupons on the Fly" module.
Steps To Reproduce- Log in https://livebuilds.openbravo.com/retail_modules_pgsql_pi/, [^] using "White valley group admin" role
- Create a discount in "Discounts and promotion" window of type "Variable Amount Coupons". Make sure to check the flags "Uses coupon codes" and "Is OTF coupon"
- Go to "OTF Coupons generation rules".
- Create a new record in form view. Check the "Is variable coupon" flag. Fill all remaining mandatory fields (select the previously created discount as discount).
- Realise that you cannot save the record, because the following error is shown:

Error
Saving failed. One or more fields contain illegal values, check the errors for each field.

If the definition of the window is changed, and the field for the id is removed, then the record can be saved correctly.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0046684PR21Q2.1 closedcberner Openbravo ERP If a tab has a field for the id of the entity, it is no longer possible to create a new record in form view 
depends on backport 0046685PR21Q1.2 closedcberner Openbravo ERP If a tab has a field for the id of the entity, it is no longer possible to create a new record in form view 
depends on backport 0046702PR20Q4.4 closedcberner Openbravo ERP If a tab has a field for the id of the entity, it is no longer possible to create a new record in form view 
depends on backport 0046703TAP closedcberner POS2 If a tab has a field for the id of the entity, it is no longer possible to create a new record in form view 
caused by defect 0045301 closedcberner Openbravo ERP Sales Order header can be saved without Invoice Address although it is mandatory 
related to defect 0046680 closedplatform POS2 [21Q2] [Restaurants] An error is shown when trying to add a Product to a menu in the Backoffice 

-  Notes
(0128206)
hgbot (developer)
2021-05-17 12:02

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/365 [^]
(0128321)
hgbot (developer)
2021-05-18 13:57

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/365 [^]
(0128322)
hgbot (developer)
2021-05-18 13:57

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 9ba983cd4aa5aea143ded1d5f48e9a872ba21641
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2021-05-18T11:54:46+00:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/9ba983cd4aa5aea143ded1d5f48e9a872ba21641 [^]

Fixes ISSUE-46681: Not possible to create a new record in form view if id is present in tab

This was due to how validation is handled in form, to avoid ISSUE-45301
a validateHiddenFields flag has been set to true to validate all hidden
fields that may be present in the form but under collapsed field groups.
This also checks all hidden fields, for example in this case identifier.
Which on new records is always undefined, until the record is saved and
an id is received.

To fix this, a check is done at validateField level, if the field is hidden and not displayed, validation will be skipped.
An alternative would be to only validate displayed fields at this level,
but this may be more prone to errors.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---

- Issue History
Date Modified Username Field Change
2021-05-14 13:40 marvintm New Issue
2021-05-14 13:40 marvintm Assigned To => platform
2021-05-14 13:40 marvintm Modules => Core
2021-05-14 13:40 marvintm Triggers an Emergency Pack => No
2021-05-14 13:53 marvintm Relationship added related to 0046680
2021-05-14 14:54 cberner Regression date => 2020-10-27
2021-05-14 14:54 cberner Regression introduced in release => PR21Q1
2021-05-14 14:54 cberner Regression introduced by commit => https://gitlab.com/openbravo/product/openbravo/-/commit/74ec2cdad81aba152fc7a704384cc96836dabde9 [^]
2021-05-14 15:00 cberner Assigned To platform => cberner
2021-05-14 15:03 cberner Status new => scheduled
2021-05-14 15:09 dmitry_mezentsev Relationship added caused by 0045301
2021-05-17 07:19 alostale Regression level => Production - QA Approved
2021-05-17 07:19 alostale Priority normal => immediate
2021-05-17 12:02 hgbot Note Added: 0128206
2021-05-18 09:52 cberner Status scheduled => acknowledged
2021-05-18 09:52 cberner Status acknowledged => scheduled
2021-05-18 09:54 cberner Relationship added depends on 0046703
2021-05-18 13:57 hgbot Resolution open => fixed
2021-05-18 13:57 hgbot Status scheduled => closed
2021-05-18 13:57 hgbot Note Added: 0128321
2021-05-18 13:57 hgbot Fixed in Version => PR21Q3
2021-05-18 13:57 hgbot Note Added: 0128322

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker