Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0046646
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[POS2] POSmajorhave not tried2021-05-12 15:342021-05-19 17:53
Reporterjorge-garciaView Statuspublic 
Assigned TojavierRodriguez 
PrioritynormalResolutionfixedFixed in Version
StatusresolvedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget VersionTAP
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0046646: Allow multiple instances per line flag for manual promotionsis not working properly

DescriptionAllow multiple instances per line allows to define the same manual promotion (m_offer_id) to be applied to the same line.

If the flag is unchecked, in old POS if a manual promotion is added to a line but this promotion was already in the line, the new added promotion overrides the previous applied promotion

If the flag is checked,every time this manual promotion is added, it will generate a new instance of the promotion (discountinstance property from promotion object)
Steps To Reproduce1) Configure Allow multiple instances per line allows flag in any way
2) The behavior is always the same
Proposed SolutionFor new POS, this is the expected behavior with "Allow multiple instances per line" flag:
  - Manual Promotion with flag CHECKED
      The promotion is added always to the ticket and the promotion object should generate a discountinstance value using an UUID
  - Manual Promotion with flag UNCHECKED
    - Ticket has not applied the promotion -> Add the promotion
    - Ticket has applied the promotion before -> A error message is shown indicating it cannot be added again

To know if a promotion is the same, we should always check the id and the discountinstance of the promotion
      
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0046645 closedjavierRodriguez Allow multiple instances per line flag for manual promotionsis not working properly 

-  Notes
(0128418)
javierRodriguez (developer)
2021-05-19 17:53
edited on: 2021-05-19 17:53

fixed in commit: https://gitlab.com/obcustomers/AGAP/org.openbravo.pos2/-/commit/50454f6649c40d31ca315daecfa9348af8a9a47b [^]

MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/469 [^]

(0128419)
javierRodriguez (developer)
2021-05-19 17:53

resolved

- Issue History
Date Modified Username Field Change
2021-05-12 15:39 guilleaer Type defect => backport
2021-05-12 15:39 guilleaer Target Version => TAP
2021-05-12 15:39 guilleaer Status scheduled => acknowledged
2021-05-19 17:45 javierRodriguez Assigned To Retail => javierRodriguez
2021-05-19 17:45 javierRodriguez Status acknowledged => scheduled
2021-05-19 17:53 javierRodriguez Note Added: 0128418
2021-05-19 17:53 javierRodriguez Note Edited: 0128418 View Revisions
2021-05-19 17:53 javierRodriguez Note Added: 0128419
2021-05-19 17:53 javierRodriguez Status scheduled => resolved
2021-05-19 17:53 javierRodriguez Resolution open => fixed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker