Anonymous | Login
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSmajorhave not tried2021-05-12 15:342021-05-19 14:06
Reporterjorge-garciaView Statuspublic 
Assigned TojavierRodriguez 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo

0046645: Allow multiple instances per line flag for manual promotionsis not working properly

DescriptionAllow multiple instances per line allows to define the same manual promotion (m_offer_id) to be applied to the same line.

If the flag is unchecked, in old POS if a manual promotion is added to a line but this promotion was already in the line, the new added promotion overrides the previous applied promotion

If the flag is checked,every time this manual promotion is added, it will generate a new instance of the promotion (discountinstance property from promotion object)
Steps To Reproduce1) Configure Allow multiple instances per line allows flag in any way
2) The behavior is always the same
Proposed SolutionFor new POS, this is the expected behavior with "Allow multiple instances per line" flag:
  - Manual Promotion with flag CHECKED
      The promotion is added always to the ticket and the promotion object should generate a discountinstance value using an UUID
  - Manual Promotion with flag UNCHECKED
    - Ticket has not applied the promotion -> Add the promotion
    - Ticket has applied the promotion before -> A error message is shown indicating it cannot be added again

To know if a promotion is the same, we should always check the id and the discountinstance of the promotion
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 0046646TAP closedjavierRodriguez Allow multiple instances per line flag for manual promotionsis not working properly 

-  Notes
hgbot (developer)
2021-05-18 20:17

Merge Request created: [^]
hgbot (developer)
2021-05-19 14:06

Directly closing issue as related merge request is already approved.

Repository: [^]
Changeset: f294814d5f964995e4f86649695f72d471ddbed6
Author: Javier Rodriguez Regueiro <>
Date: 2021-05-19T14:05:17+02:00
URL: [^]

Fixed ISSUE-46645: Validate before include a new manual discount if it is allowed to include multiple instances of the same discount

A web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/SetManualDiscountToApplyActionPreparation.test.js
A web-jspack/org.openbravo.pos2/src/model/user-interface/actions/discounts/SetManualDiscountToApplyActionPreparation.js
M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountPanelGrid/DiscountPanelGrid.jsx
M web-jspack/org.openbravo.pos2/src/model/user-interface/UIExtension.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/discounts/SelectManualDiscountsToApply.js
hgbot (developer)
2021-05-19 14:06

Merge request merged: [^]

- Issue History
Date Modified Username Field Change
2021-05-12 15:34 jorge-garcia New Issue
2021-05-12 15:34 jorge-garcia Assigned To => Retail
2021-05-12 15:34 jorge-garcia Triggers an Emergency Pack => No
2021-05-12 15:36 jorge-garcia Resolution time => 1622584800
2021-05-12 15:39 guilleaer Status new => scheduled
2021-05-12 15:39 guilleaer Status scheduled => acknowledged
2021-05-18 20:17 hgbot Note Added: 0128351
2021-05-19 10:13 javierRodriguez Assigned To Retail => javierRodriguez
2021-05-19 10:13 javierRodriguez Status acknowledged => scheduled
2021-05-19 14:06 hgbot Resolution open => fixed
2021-05-19 14:06 hgbot Status scheduled => closed
2021-05-19 14:06 hgbot Note Added: 0128405
2021-05-19 14:06 hgbot Note Added: 0128406

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker