Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0046645 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | major | have not tried | 2021-05-12 15:34 | 2021-05-19 14:06 | |||
| Reporter | jorge-garcia | View Status | public | |||||
| Assigned To | javierRodriguez | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0046645: Allow multiple instances per line flag for manual promotionsis not working properly | |||||||
| Description | Allow multiple instances per line allows to define the same manual promotion (m_offer_id) to be applied to the same line. If the flag is unchecked, in old POS if a manual promotion is added to a line but this promotion was already in the line, the new added promotion overrides the previous applied promotion If the flag is checked,every time this manual promotion is added, it will generate a new instance of the promotion (discountinstance property from promotion object) | |||||||
| Steps To Reproduce | 1) Configure Allow multiple instances per line allows flag in any way 2) The behavior is always the same | |||||||
| Proposed Solution | For new POS, this is the expected behavior with "Allow multiple instances per line" flag: - Manual Promotion with flag CHECKED The promotion is added always to the ticket and the promotion object should generate a discountinstance value using an UUID - Manual Promotion with flag UNCHECKED - Ticket has not applied the promotion -> Add the promotion - Ticket has applied the promotion before -> A error message is shown indicating it cannot be added again To know if a promotion is the same, we should always check the id and the discountinstance of the promotion | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0128351) hgbot (developer) 2021-05-18 20:17 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/469 [^] |
|
(0128405) hgbot (developer) 2021-05-19 14:06 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: f294814d5f964995e4f86649695f72d471ddbed6 Author: Javier Rodriguez Regueiro <javier.rodriguez@openbravo.com> Date: 2021-05-19T14:05:17+02:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f294814d5f964995e4f86649695f72d471ddbed6 [^] Fixed ISSUE-46645: Validate before include a new manual discount if it is allowed to include multiple instances of the same discount --- A web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/SetManualDiscountToApplyActionPreparation.test.js A web-jspack/org.openbravo.pos2/src/model/user-interface/actions/discounts/SetManualDiscountToApplyActionPreparation.js M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountPanelGrid/DiscountPanelGrid.jsx M web-jspack/org.openbravo.pos2/src/model/user-interface/UIExtension.js M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/discounts/SelectManualDiscountsToApply.js --- |
|
(0128406) hgbot (developer) 2021-05-19 14:06 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/469 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-05-12 15:34 | jorge-garcia | New Issue | |
| 2021-05-12 15:34 | jorge-garcia | Assigned To | => Retail |
| 2021-05-12 15:34 | jorge-garcia | Triggers an Emergency Pack | => No |
| 2021-05-12 15:36 | jorge-garcia | Resolution time | => 1622584800 |
| 2021-05-12 15:39 | guilleaer | Status | new => scheduled |
| 2021-05-12 15:39 | guilleaer | Status | scheduled => acknowledged |
| 2021-05-18 20:17 | hgbot | Note Added: 0128351 | |
| 2021-05-19 10:13 | javierRodriguez | Assigned To | Retail => javierRodriguez |
| 2021-05-19 10:13 | javierRodriguez | Status | acknowledged => scheduled |
| 2021-05-19 14:06 | hgbot | Resolution | open => fixed |
| 2021-05-19 14:06 | hgbot | Status | scheduled => closed |
| 2021-05-19 14:06 | hgbot | Note Added: 0128405 | |
| 2021-05-19 14:06 | hgbot | Note Added: 0128406 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |