Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0046538 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [POS2] Core | trivial | always | 2021-05-06 09:09 | 2021-10-19 12:12 | |||
Reporter | migueldejuana | View Status | public | |||||
Assigned To | caristu | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0046538: Apply button in discount should be disabled by default | |||||||
Description | - In Discounts window, Apply button should be disabled till we have applied changes. | |||||||
Steps To Reproduce | n/a | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |
Notes | |
(0130590) hgbot (developer) 2021-07-19 21:13 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/614 [^] |
(0130726) hgbot (developer) 2021-07-23 12:44 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: cdeed6abf816fbc126bf132e03a26bc96ec31f37 Author: hernan-dp <h.de.prada1@gmail.com> Date: 2021-07-23T10:43:59+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/cdeed6abf816fbc126bf132e03a26bc96ec31f37 [^] fixes ISSUE-46538: Apply button in discount disabled when no changes applied. --- M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountPanel/DiscountPanel.config.json --- |
(0130727) hgbot (developer) 2021-07-23 12:44 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/614 [^] |
(0130728) dmiguelez (developer) 2021-07-23 12:45 |
Related commit: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/03ae615a813710084f6e1ba2b08cb0bab81de985 [^] |
(0130842) hgbot (developer) 2021-07-28 15:54 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/613 [^] |
(0130843) hgbot (developer) 2021-07-28 15:54 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/613 [^] |
(0130844) hgbot (developer) 2021-07-28 15:55 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/644 [^] |
(0130845) hgbot (developer) 2021-07-28 15:59 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/614 [^] |
(0130846) hgbot (developer) 2021-07-28 16:06 |
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/614 [^] |
(0130847) hgbot (developer) 2021-07-28 16:06 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/644 [^] |
(0130848) hgbot (developer) 2021-07-28 16:07 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 82ae4a92fa557d8426fe6fabc0f0fb90061e5720 Author: hernan-dp <h.de.prada1@gmail.com> Date: 2021-07-28T10:54:26-03:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/82ae4a92fa557d8426fe6fabc0f0fb90061e5720 [^] Revert "fixes ISSUE-46538: Apply button in discount disabled when no changes applied." This reverts commit cdeed6abf816fbc126bf132e03a26bc96ec31f37. --- M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountPanel/DiscountPanel.config.json --- |
(0130849) dmiguelez (developer) 2021-07-28 16:10 |
Fix has been reverted. The reason is that, even if the fix is correct, it is possible to implement a better solution that does not required to use the state to communicate both react components |
(0132264) hgbot (developer) 2021-10-08 09:55 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/701 [^] |
(0132443) hgbot (developer) 2021-10-19 12:12 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: f004d7c8604029d15e04f87827c2c0080e3548d1 Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 2021-10-19T12:10:57+02:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f004d7c8604029d15e04f87827c2c0080e3548d1 [^] fixes ISSUE-46538: Disable Apply button if there are no discounts to apply --- A web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/ApplyDiscountButton/ApplyDiscountButton.jsx A web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/ApplyDiscountButton/__test__/ApplyDiscountButton.test.jsx A web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/ApplyDiscountButton/index.js A web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountPanel/DiscountContextProvider.jsx A web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/ApplyOrderDiscountButton/ApplyOrderDiscountButton.jsx A web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/ApplyOrderDiscountButton/__test__/ApplyOrderDiscountButton.test.jsx A web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/ApplyOrderDiscountButton/index.js A web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountPanel/OrderDiscountContextProvider.jsx M src-db/database/sourcedata/AD_MESSAGE.xml M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountPanel/DiscountPanel.config.json M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountPanel/DiscountPanel.jsx M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountPanelGrid/DiscountPanelGrid.jsx M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountPanelGrid/__test__/DiscountPanelGrid.test.jsx M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountPanel/OrderDiscountPanel.config.json M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountPanel/OrderDiscountPanel.jsx M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountPanelGrid/OrderDiscountPanelGrid.jsx M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountPanelGrid/__test__/OrderDiscountPanelGrid.test.jsx M web-jspack/org.openbravo.pos2/src/ob-init.js --- |
(0132444) hgbot (developer) 2021-10-19 12:12 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/701 [^] |
Issue History | |||
Date Modified | Username | Field | Change |
2021-05-06 09:09 | migueldejuana | New Issue | |
2021-05-06 09:09 | migueldejuana | Assigned To | => Retail |
2021-05-06 09:09 | migueldejuana | Triggers an Emergency Pack | => No |
2021-05-07 12:28 | guilleaer | Resolution time | => 1625436000 |
2021-05-07 12:29 | guilleaer | Status | new => acknowledged |
2021-07-14 13:30 | dmiguelez | Resolution time | 1625436000 => 1633039200 |
2021-07-19 21:06 | hernan-dp | Assigned To | Retail => hernan-dp |
2021-07-19 21:07 | hernan-dp | Status | acknowledged => scheduled |
2021-07-19 21:13 | hgbot | Note Added: 0130590 | |
2021-07-23 12:44 | hgbot | Resolution | open => fixed |
2021-07-23 12:44 | hgbot | Status | scheduled => closed |
2021-07-23 12:44 | hgbot | Note Added: 0130726 | |
2021-07-23 12:44 | hgbot | Note Added: 0130727 | |
2021-07-23 12:45 | dmiguelez | Note Added: 0130728 | |
2021-07-28 15:54 | hgbot | Note Added: 0130842 | |
2021-07-28 15:54 | hgbot | Note Added: 0130843 | |
2021-07-28 15:55 | hgbot | Note Added: 0130844 | |
2021-07-28 15:59 | hgbot | Note Added: 0130845 | |
2021-07-28 16:06 | hgbot | Note Added: 0130846 | |
2021-07-28 16:06 | hgbot | Note Added: 0130847 | |
2021-07-28 16:07 | hgbot | Note Added: 0130848 | |
2021-07-28 16:10 | dmiguelez | Note Added: 0130849 | |
2021-07-28 16:10 | dmiguelez | Status | closed => new |
2021-07-28 16:10 | dmiguelez | Resolution | fixed => open |
2021-07-28 16:10 | dmiguelez | Status | new => acknowledged |
2021-08-30 12:45 | dmiguelez | Assigned To | hernan-dp => Retail |
2021-09-15 12:23 | guilleaer | Assigned To | Retail => prakashmurugesan88 |
2021-09-15 12:24 | guilleaer | Assigned To | prakashmurugesan88 => migueldejuana |
2021-09-16 14:18 | guilleaer | Assigned To | migueldejuana => Retail |
2021-09-24 09:04 | prakashmurugesan88 | Assigned To | Retail => prakashmurugesan88 |
2021-09-24 09:04 | prakashmurugesan88 | Status | acknowledged => scheduled |
2021-09-24 12:16 | prakashmurugesan88 | Assigned To | prakashmurugesan88 => Retail |
2021-09-24 12:16 | prakashmurugesan88 | Status | scheduled => acknowledged |
2021-10-08 09:52 | caristu | Assigned To | Retail => caristu |
2021-10-08 09:55 | hgbot | Note Added: 0132264 | |
2021-10-11 12:35 | guilleaer | Status | acknowledged => scheduled |
2021-10-19 12:12 | hgbot | Resolution | open => fixed |
2021-10-19 12:12 | hgbot | Status | scheduled => closed |
2021-10-19 12:12 | hgbot | Note Added: 0132443 | |
2021-10-19 12:12 | hgbot | Note Added: 0132444 |
Copyright © 2000 - 2009 MantisBT Group |