Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0046490
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POScriticalhave not tried2021-05-04 10:442021-05-05 08:02
ReportercaristuView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityimmediateResolutionfixedFixed in VersionRR21Q1.2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget VersionRR21Q1.2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0046490: action preparation order is modified when the action fails

DescriptionWhen an action fails, the action preparation rollback mechanism is executed[1].

This mechanism executes all the rollback functions of each action preparation in reverse order.

In order to retrieve the reversed order of rollback functions we are using the reverse function[2]. Note that reverse function mutates the original array[3].

In practice, this means that if an action fails, the next time it is executed the action preparations are executed in reversed order.

[1] http://wiki.openbravo.com/wiki/StateController#Action_Preparations [^]
[2] https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/blob/master/web/org.openbravo.mobile.core/app/model/application-state/State.js#L60 [^]
[3] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/reverse [^]
Steps To Reproduce1) Put mobile.core in this branch:
2) Execute the State.test.js which contains a reproducer for the situation described in Description
3) Note that the test fails
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0046479 closedcaristu action preparation order is modified when the action fails 

-  Notes
(0127795)
hgbot (developer)
2021-05-05 07:43

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/221 [^]
(0127805)
hgbot (developer)
2021-05-05 08:02

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/221 [^]
(0127806)
hgbot (developer)
2021-05-05 08:02

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 9f1eabc807e239e7a8e600d1d59dc9e53dc10fa7
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2021-05-04T22:27:21+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/9f1eabc807e239e7a8e600d1d59dc9e53dc10fa7 [^]

Fixed ISSUE-46490: Action preparation order is modified when the action fails

---
M web-test/model/application-state/State.test.js
M web/org.openbravo.mobile.core/app/model/application-state/State.js
---

- Issue History
Date Modified Username Field Change
2021-05-04 17:06 marvintm Type defect => backport
2021-05-04 17:06 marvintm Target Version => RR21Q1.2
2021-05-04 18:36 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2021-05-05 07:43 hgbot Note Added: 0127795
2021-05-05 08:02 hgbot Note Added: 0127805
2021-05-05 08:02 hgbot Resolution open => fixed
2021-05-05 08:02 hgbot Status scheduled => closed
2021-05-05 08:02 hgbot Fixed in Version => RR21Q1.2
2021-05-05 08:02 hgbot Note Added: 0127806

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker