Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0046489 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Retail Modules] Web POS | critical | have not tried | 2021-05-04 10:44 | 2021-05-05 08:01 | |||
| Reporter | caristu | View Status | public | |||||
| Assigned To | ranjith_qualiantech_com | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | RR21Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | RR21Q2 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0046489: action preparation order is modified when the action fails | |||||||
| Description | When an action fails, the action preparation rollback mechanism is executed[1]. This mechanism executes all the rollback functions of each action preparation in reverse order. In order to retrieve the reversed order of rollback functions we are using the reverse function[2]. Note that reverse function mutates the original array[3]. In practice, this means that if an action fails, the next time it is executed the action preparations are executed in reversed order. [1] http://wiki.openbravo.com/wiki/StateController#Action_Preparations [^] [2] https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/blob/master/web/org.openbravo.mobile.core/app/model/application-state/State.js#L60 [^] [3] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/reverse [^] | |||||||
| Steps To Reproduce | 1) Put mobile.core in this branch: 2) Execute the State.test.js which contains a reproducer for the situation described in Description 3) Note that the test fails | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0127794) hgbot (developer) 2021-05-05 07:42 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/220 [^] |
|
(0127803) hgbot (developer) 2021-05-05 08:01 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/220 [^] |
|
(0127804) hgbot (developer) 2021-05-05 08:01 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: 9e58c3cb4cd8a5e40e152a936311566b0972a0dd Author: Ranjith S R <ranjith@qualiantech.com> Date: 2021-05-04T22:27:10+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/9e58c3cb4cd8a5e40e152a936311566b0972a0dd [^] Fixed ISSUE-46489: Action preparation order is modified when the action fails --- M web-test/model/application-state/State.test.js M web/org.openbravo.mobile.core/app/model/application-state/State.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-05-04 17:06 | marvintm | Type | defect => backport |
| 2021-05-04 17:06 | marvintm | Target Version | => RR21Q2 |
| 2021-05-04 18:36 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2021-05-05 07:42 | hgbot | Note Added: 0127794 | |
| 2021-05-05 08:01 | hgbot | Resolution | open => fixed |
| 2021-05-05 08:01 | hgbot | Status | scheduled => closed |
| 2021-05-05 08:01 | hgbot | Note Added: 0127803 | |
| 2021-05-05 08:01 | hgbot | Fixed in Version | => RR21Q2 |
| 2021-05-05 08:01 | hgbot | Note Added: 0127804 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |