Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0046485
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. Platformminorhave not tried2021-05-04 14:442021-11-30 11:23
ReporteralostaleView Statuspublic 
Assigned Toplatform 
PrioritynormalResolutionfixedFixed in VersionPR21Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0046485: clean up main jUnit test suites

DescriptionCurrently there are 4 main test suites under org.openbravo.test package:
 * Run in CI:
   - AllAntTaskTests: ant run.all.tests
   - AllWebserviceTests: ant run.webservice.tests
 * Not run in CI:
   - AntTaskTests: ant run.tests
   - AllQuickAntTaskTests: ant run.quick.tests
   - AllTests: not ant task

Having 5 suites with unclear intents each of them makes it hard to maintain. Also it is unclear what is the purpose of those suites which are not executed as part of the UI.
Steps To Reproduce-
Proposed Solution* Remove the following suites as they are not executed in CI
   - AntTaskTests
   - AllQuickAntTaskTests
   - AllTests

* Remove the following ant tasks as they are not executed in CI
   - run.tests
   - run.quick.tests

* Rename the following suites to make clearer their goal, maintaining the ant task names invoking them
   - AllAntTaskTests -> StandaloneTestSuite
   - AllWebserviceTests -> WebserviceTestSuite
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0033554 scheduledTriage Platform Base Openbravo ERP some test cases not executed in CI 
related to feature request 0048176 closedcaristu Retail Modules missing jUnit standard CI test suites 

-  Notes
(0127771)
hgbot (developer)
2021-05-04 15:04

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/356 [^]
(0127877)
hgbot (developer)
2021-05-07 07:56

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/356 [^]
(0127878)
hgbot (developer)
2021-05-07 07:56

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 8ad7ea000ce77f1a92d23c8a0481e25f7e724c9d
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 2021-05-06T13:21:46+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/8ad7ea000ce77f1a92d23c8a0481e25f7e724c9d [^]

fixes FR-46485: clean up main jUnit test suites

This commit:

* Removes the following suites as they are not executed in CI
   - AntTaskTests
   - AllQuickAntTaskTests
   - AllTests

* Removes the following ant tasks as they are not executed in CI
   - run.tests
   - run.quick.tests

* Renames the following suites to make clearer their goal, maintaining the ant task names invoking them
   - AllAntTaskTests -> StandaloneTestSuite
   - AllWebserviceTests -> WebserviceTestSuite

---
A src-test/src/org/openbravo/test/StandaloneTestSuite.java
A src-test/src/org/openbravo/test/WebserviceTestSuite.java
M build.xml
M src-test/build.xml
R src-test/src/org/openbravo/test/AllQuickAntTaskTests.java
R src-test/src/org/openbravo/test/AllTests.java
R src-test/src/org/openbravo/test/AntTaskTests.java
---
(0127979)
hgbot (developer)
2021-05-11 08:26

 Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.service.external.integration.tests/-/merge_requests/1 [^]
(0127980)
hgbot (developer)
2021-05-11 08:26

 Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.service.external.integration.tests [^]
Changeset: 76baf69aa409a63531d9c998758816340acb4453
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 2021-05-11T08:25:20+02:00
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.service.external.integration.tests/-/commit/76baf69aa409a63531d9c998758816340acb4453 [^]

related to FR-46485: adds tests to CI test suite

---
A src-test/org/openbravo/service/external/integration/tests/StandaloneTestSuite.java
---
(0127981)
hgbot (developer)
2021-05-11 08:26

 Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.service.external.integration.tests/-/merge_requests/1 [^]
(0127982)
hgbot (developer)
2021-05-11 08:31

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.sapecc/-/merge_requests/2 [^]
(0127983)
hgbot (developer)
2021-05-11 08:32

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.sapecc [^]
Changeset: aa82ccbb1c30e85bf8339d327a6c7448d7ce9b44
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 2021-05-11T08:31:32+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.sapecc/-/commit/aa82ccbb1c30e85bf8339d327a6c7448d7ce9b44 [^]

related to FR-46485: adds tests to CI test suite

---
A src-test/org/openbravo/service/integration/sapecc/StandaloneTestSuite.java
---
(0127984)
hgbot (developer)
2021-05-11 08:32

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.integration.sapecc/-/merge_requests/2 [^]

- Issue History
Date Modified Username Field Change
2021-05-04 14:44 alostale New Issue
2021-05-04 14:44 alostale Assigned To => platform
2021-05-04 14:44 alostale Modules => Core
2021-05-04 14:44 alostale Triggers an Emergency Pack => No
2021-05-04 14:47 alostale Proposed Solution updated
2021-05-04 15:04 hgbot Note Added: 0127771
2021-05-05 09:56 alostale Relationship added related to 0033554
2021-05-05 10:30 shuehner Issue Monitored: shuehner
2021-05-07 07:56 hgbot Resolution open => fixed
2021-05-07 07:56 hgbot Status new => closed
2021-05-07 07:56 hgbot Note Added: 0127877
2021-05-07 07:56 hgbot Fixed in Version => PR21Q3
2021-05-07 07:56 hgbot Note Added: 0127878
2021-05-11 08:26 hgbot Note Added: 0127979
2021-05-11 08:26 hgbot Note Added: 0127980
2021-05-11 08:26 hgbot Note Added: 0127981
2021-05-11 08:31 hgbot Note Added: 0127982
2021-05-11 08:32 hgbot Note Added: 0127983
2021-05-11 08:32 hgbot Note Added: 0127984
2021-11-30 11:23 caristu Issue cloned 0048176
2021-11-30 11:23 caristu Relationship added related to 0048176

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker