Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0046479
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POScriticalhave not tried2021-05-04 10:442021-05-04 17:07
ReportercaristuView Statuspublic 
Assigned Tocaristu 
PriorityimmediateResolutionfixedFixed in VersionRR21Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0046479: action preparation order is modified when the action fails

DescriptionWhen an action fails, the action preparation rollback mechanism is executed[1].

This mechanism executes all the rollback functions of each action preparation in reverse order.

In order to retrieve the reversed order of rollback functions we are using the reverse function[2]. Note that reverse function mutates the original array[3].

In practice, this means that if an action fails, the next time it is executed the action preparations are executed in reversed order.

[1] http://wiki.openbravo.com/wiki/StateController#Action_Preparations [^]
[2] https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/blob/master/web/org.openbravo.mobile.core/app/model/application-state/State.js#L60 [^]
[3] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/reverse [^]
Steps To Reproduce1) Put mobile.core in this branch:
2) Execute the State.test.js which contains a reproducer for the situation described in Description
3) Note that the test fails
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0046489RR21Q2 closedranjith_qualiantech_com Retail Modules action preparation order is modified when the action fails 
depends on backport 0046490RR21Q1.2 closedranjith_qualiantech_com Retail Modules action preparation order is modified when the action fails 
depends on backport 0046491RR20Q4.4 closedranjith_qualiantech_com Retail Modules action preparation order is modified when the action fails 
related to backport 0046505TAP closedguilleaer POS2 action preparation order is modified when the action fails 

-  Notes
(0127765)
hgbot (developer)
2021-05-04 10:50

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/219 [^]
(0127776)
hgbot (developer)
2021-05-04 17:07

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 6e451c3c466f23d57d6b7889ea9ebcb9ef209f09
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 2021-05-04T10:58:05+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/6e451c3c466f23d57d6b7889ea9ebcb9ef209f09 [^]

fixes ISSUE-46479: action preparation order is modified when the action fails

---
M web-test/model/application-state/State.test.js
M web/org.openbravo.mobile.core/app/model/application-state/State.js
---
(0127777)
hgbot (developer)
2021-05-04 17:07

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/219 [^]

- Issue History
Date Modified Username Field Change
2021-05-04 10:44 caristu New Issue
2021-05-04 10:44 caristu Assigned To => Retail
2021-05-04 10:44 caristu OBNetwork customer => No
2021-05-04 10:44 caristu Triggers an Emergency Pack => No
2021-05-04 10:46 caristu Steps to Reproduce Updated View Revisions
2021-05-04 10:50 caristu Description Updated View Revisions
2021-05-04 10:50 hgbot Merge Request Status => open
2021-05-04 10:50 hgbot Note Added: 0127765
2021-05-04 11:23 caristu Priority urgent => immediate
2021-05-04 11:23 caristu Severity major => critical
2021-05-04 15:40 hgbot Merge Request Status open => approved
2021-05-04 17:06 marvintm Status new => scheduled
2021-05-04 17:06 marvintm Assigned To Retail => caristu
2021-05-04 17:07 hgbot Resolution open => fixed
2021-05-04 17:07 hgbot Status scheduled => closed
2021-05-04 17:07 hgbot Fixed in Version => RR21Q3
2021-05-04 17:07 hgbot Note Added: 0127776
2021-05-04 17:07 hgbot Note Added: 0127777
2021-05-05 09:33 guilleaer Relationship added related to 0046505

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker