Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0046256 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Web POS | minor | always | 2021-04-13 11:00 | 2021-04-19 07:28 | |||
Reporter | marvintm | View Status | public | |||||
Assigned To | rqueralta | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | RR21Q3 | |||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0046256: JSONProcessSimple class exec method fails if there is no request in RequestContext | |||||||
Description | In some cases we want to use the WebPOS webservices programatically, and in some of those cases there is no actual HTTP request as the code is coming from a process or integration. In all the cases inside JSONProcessSimple class, there are checks for the existance of the request, so that the relevant code is not executed if request is null. However, there is one case missing this check: the getParameterMap in the MobileCoreKernelUtils class is not doing this check, and fails if the request is null. | |||||||
Steps To Reproduce | Use the ExportOrder class programatically from an ImportEntryProcessorHook. Realise that the exec method fails because the request inside RequestContext is null | |||||||
Proposed Solution | Add the following lines to the getParameterMap in the MobileCoreKernelUtils class: if(request == null) { return parameterMap; } | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |
Notes | |
(0127334) hgbot (developer) 2021-04-16 23:38 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/211 [^] |
(0127348) hgbot (developer) 2021-04-19 07:28 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: a1b79ad879c96bee082354c5735d8575cdf63127 Author: Rafael Queralta <rafaelcuba81@gmail.com> Date: 2021-04-16T17:37:13-04:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/a1b79ad879c96bee082354c5735d8575cdf63127 [^] Fixed BUG-46256: Check if request is null from the beginning of the getParameterMap function to avoid fails if there is no request in RequestContext --- M src/org/openbravo/mobile/core/MobileCoreKernelUtils.java --- |
(0127349) hgbot (developer) 2021-04-19 07:28 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/211 [^] |
Issue History | |||
Date Modified | Username | Field | Change |
2021-04-13 11:00 | marvintm | New Issue | |
2021-04-13 11:00 | marvintm | Assigned To | => Retail |
2021-04-13 11:00 | marvintm | Resolution time | => 1619733600 |
2021-04-13 11:00 | marvintm | Triggers an Emergency Pack | => No |
2021-04-16 18:20 | rqueralta | Assigned To | Retail => rqueralta |
2021-04-16 18:20 | rqueralta | Status | new => scheduled |
2021-04-16 23:38 | hgbot | Note Added: 0127334 | |
2021-04-19 07:28 | hgbot | Resolution | open => fixed |
2021-04-19 07:28 | hgbot | Status | scheduled => closed |
2021-04-19 07:28 | hgbot | Fixed in Version | => RR21Q3 |
2021-04-19 07:28 | hgbot | Note Added: 0127348 | |
2021-04-19 07:28 | hgbot | Note Added: 0127349 |
Copyright © 2000 - 2009 MantisBT Group |