0046218: Problems adding PACK type promotions and products in the POS with different price list version

Description

In PACK-type promotions in which the products that comprise it are not in the price list used by the POS, when you want to select them in the POS there is no effect. If products continue to be added to the ticket (after having selected the promotion), both the Total of the lines and that of the ticket, both are always 0. This problem is caused by this type of promotions that have the problem mentioned above.
It should be added that this happens when a pack promotion is selected in the ticket, what I mean by this is that if a promotion of this type is selected first and then other products are added to the current ticket, the problem is clearly reflected. But also if products are added to the ticket first, they will be added in a normal way in which the amount of the line is correct and the total amount of the ticket is also, but if a pack-type promotion is added in the middle in which some of its component is not in the price list that the POS uses directly, the total of the lines such as the ticket is 0. THIS HAPPENS WHEN A PACK-TYPE PROMOTION IS ADDED THAT HAS THIS PROBLEM, IT DOESN'T MATTER THE ORDER, WHAT IT MATTERS THAT ONE OF THESE IS ADDED AT SOME TIME IN THE TICKET.

Steps To Reproduce

Open BACKEND and POS for Openbravo 3.0RR19Q4.4
Go to "Discounts and Promotions" window.
Select a pack type promotion, for example "Camping Pack".
Go to Products tab.
Select a Product.
Go to the corresponding POS Price List Version.
Delete the selected Product from the corresponding Price List Version.
Go to the POS.
Force a Full Data Load in the POS.
On a ticket (with or without previous lines), try to add the selected pack type promotion. The add will not work.
Add any other product to the same ticket. All the totals will be 0, those of the lines and those of the ticket.

Tags

No tags attached.

Attached Files

0001-Fixed-BUG-46218-Set-skipApplyPromotions-to-false.patch [^] (925 bytes) 2021-04-09 22:17 [Show Content] [Hide Content]

From fd809e03232c6d604c2b354b03c64c5e9565edca Mon Sep 17 00:00:00 2001
From: Rafael Queralta <rafaelcuba81@gmail.com>
Date: Fri, 9 Apr 2021 16:15:19 -0400
Subject: [PATCH] Fixed BUG-46218: Set skipApplyPromotions to false

---
 web/org.openbravo.retail.discounts/js/promotion-pack.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/web/org.openbravo.retail.discounts/js/promotion-pack.js b/web/org.openbravo.retail.discounts/js/promotion-pack.js
index a4b7d31..352e041 100644
--- a/web/org.openbravo.retail.discounts/js/promotion-pack.js
+++ b/web/org.openbravo.retail.discounts/js/promotion-pack.js
@@ -221,6 +221,7 @@ OB.Model.Discounts.discountRules.BE5D42E554644B6AA262CCB097753951 = {
     }
 
     function emptyCallback(error) {
+      order.set('skipApplyPromotions', false);
       OB.UTIL.showWarning(
         OB.I18N.getLabel('OBPOS_ErrorProductPack', [
           productToAdd.get('_identifier')
-- 
2.28.0

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0127630) marvintm (manager) 2021-04-29 07:04	Issue doesn't apply to latest releases. A patch with a fix for earlier releases has been attached.

Issue History
Date Modified	Username	Field	Change
2021-04-06 14:10	lbressan	New Issue
2021-04-06 14:10	lbressan	Assigned To	=> Retail
2021-04-06 14:10	lbressan	Resolution time	=> 1619474400
2021-04-06 14:10	lbressan	Triggers an Emergency Pack	=> No
2021-04-06 17:32	rqueralta	Assigned To	Retail => rqueralta
2021-04-06 17:32	rqueralta	Status	new => scheduled
2021-04-09 22:17	rqueralta	File Added: 0001-Fixed-BUG-46218-Set-skipApplyPromotions-to-false.patch
2021-04-29 07:04	marvintm	Review Assigned To	=> marvintm
2021-04-29 07:04	marvintm	Note Added: 0127630
2021-04-29 07:04	marvintm	Status	scheduled => closed
2021-04-29 07:04	marvintm	Resolution	open => no change required