Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0046154 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | have not tried | 2021-03-25 17:51 | 2021-03-26 13:41 | |||
| Reporter | AugustoMauch | View Status | public | |||||
| Assigned To | platform | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | PR21Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0046154: Eslint should ignore web-jspack folder if org.openbravo.core2 is not installed. | |||||||
| Description | Now that we support dual modules it is possible that a module contains code for both the legacy and the new version of applications. When installed in environments where the new version of the application is not available, code in web-jspack should not be taking into account. This is already true in most cases (i.e. jest tests), but eslint is still linting files in that folder. They must be ignored because those files might reference code from the new version of app, and that would result in eslint errors. | |||||||
| Steps To Reproduce | In a retail environment where org.openbravo.core2 is available, install this module [1] and then run eslint: ./modules/org.openbravo.client.kernel/jslint/jslint There should be no error, but instead it will fail with the following message: Oops! Something went wrong! :( ESLint: 7.17.0 ESLint couldn't find the config "airbnb" to extend from. Please check that the name of the config is correct. The config "airbnb" was referenced from the config file in "/home/openbravo/openbravoERP/pos1modules/openbravo [1] https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.trainingmode/ [^] | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0126934) hgbot (developer) 2021-03-25 21:30 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/338 [^] |
|
(0126949) hgbot (developer) 2021-03-26 13:41 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: f29b39b6dbf0a2b135cc94dc7aedea499c2aff48 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 2021-03-26T13:40:29+01:00 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/f29b39b6dbf0a2b135cc94dc7aedea499c2aff48 [^] Fixes ISSUE-46154: eslint ignores web-jspack if org.openbravo.core2 is not installed This is needed because files under web-jspack may potentially reference components from core2 and pos, and those dependencies are not mandatory. Now all files under web-jspack are ignored if org.openbravo.core2 is not installed. Also adds -no-error-on-unmatched-pattern to prevent errors if there are no files to lint after excluding those under the web-jspack folder. --- M modules/org.openbravo.client.kernel/jslint/jslint --- |
|
(0126950) hgbot (developer) 2021-03-26 13:41 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/338 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-03-25 17:51 | AugustoMauch | New Issue | |
| 2021-03-25 17:51 | AugustoMauch | Assigned To | => platform |
| 2021-03-25 17:51 | AugustoMauch | OBNetwork customer | => No |
| 2021-03-25 17:51 | AugustoMauch | Modules | => Core |
| 2021-03-25 17:51 | AugustoMauch | Triggers an Emergency Pack | => No |
| 2021-03-25 21:30 | hgbot | Merge Request Status | => open |
| 2021-03-25 21:30 | hgbot | Note Added: 0126934 | |
| 2021-03-26 13:34 | hgbot | Merge Request Status | open => approved |
| 2021-03-26 13:41 | hgbot | Resolution | open => fixed |
| 2021-03-26 13:41 | hgbot | Status | new => closed |
| 2021-03-26 13:41 | hgbot | Fixed in Version | => PR21Q2 |
| 2021-03-26 13:41 | hgbot | Note Added: 0126949 | |
| 2021-03-26 13:41 | hgbot | Note Added: 0126950 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |