Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0046049

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2021-03-11 12:50

2021-03-29 07:00

Reporter

ucarrion

View Status

public

Assigned To

rqueralta

Priority

normal

Resolution

duplicate

Fixed in Version

RR21Q1

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Gold

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0046049: The 'More...' button on the payment tab is not in green depending on the payment method selected

Description

Normally, whenever a payment inside the 'More...' popup is selected and then the popup is closed, that 'More...' button should be in green. This is not occurring when the payment selected is a provider group/payment provider.

Steps To Reproduce

precond: a payment provider/provider group payment must be enabled and set into a Line No so it is included into the 'More...' payment popup.

-Login the webpos
-Add a product
-Press the checkout button
-Press the 'More...' button
-In the popup select the mentioned payment
-Close the popup and check that the 'More...' button is always in grey

Tags

No tags attached.

Captura de pantalla 2021-03-22 a las 9.10.30.png [^] (29,262 bytes) 2021-03-22 09:10

0001-Fix-BUG-46049-Payment-DialogButton-should-be-updated.patch [^] (1,117 bytes) 2021-03-26 23:36 [Show Content] [Hide Content]

From 29a471a24539b4fc03765740386dd2b332b21253 Mon Sep 17 00:00:00 2001
From: Rafael Queralta <rafaelcuba81@gmail.com>
Date: Fri, 26 Mar 2021 18:35:03 -0400
Subject: [PATCH] Fix BUG-46049: Payment DialogButton should be updated with
 button command instead of searchkey

---
 .../js/pointofsale/view/keyboard-toolbars.js                    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js b/web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
index be03423e7..3c1e7c510 100644
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
@@ -310,7 +310,7 @@ enyo.kind({
       this.createComponent(btncomponent);
     } else {
       this.addSideButton(btncomponent);
-      dialogbuttons[payment.payment.searchKey] = payment.payment._identifier;
+      dialogbuttons[btncomponent.btn.command] = btncomponent.btn.label;
     }
   },
   addSideButton: function(btncomponent) {
-- 
2.28.0

Relationships [ Relation Graph ] [ Dependency Graph ]

duplicate of

defect

closed

ranjith_qualiantech_com

Payment name is not informed in "More" button with Group Providers

Notes
(0126821) marvintm (viewer) 2021-03-22 09:10	We haven't been able to reproduce this issue. When testing with terminal YS-11 in an instance with ext modules, the "More" button remains checked when a payment method inside the "More" popup is selected: https://livebuilds.openbravo.com/retail_modules_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=YS-11#retail.pointofsale [^] We attached a screenshot of this behaviour.

(0126878) ucarrion (viewer) 2021-03-24 09:28	The issue is reproduced in livebuils 19Q4 version. Check this video please: https://drive.google.com/file/d/1UtltNtDV4caTeEO57R9WyTrEKZ8eLD5F/view [^]

(0126962) marvintm (viewer) 2021-03-29 07:00	Duplicated: https://issues.openbravo.com/view.php?id=45337 [^] It seems the patch for issue 45337 should be directly applicable in 19Q3.

Issue History
Date Modified	Username	Field	Change
2021-03-11 12:50	ucarrion	New Issue
2021-03-11 12:50	ucarrion	Assigned To	=> Retail
2021-03-11 12:50	ucarrion	OBNetwork customer	=> Gold
2021-03-11 12:50	ucarrion	Resolution time	=> 1617228000
2021-03-11 12:50	ucarrion	Triggers an Emergency Pack	=> No
2021-03-11 12:51	jorgewederago	Issue Monitored: jorgewederago
2021-03-11 13:07	ucarrion	Severity	minor => major
2021-03-11 17:23	rqueralta	Assigned To	Retail => rqueralta
2021-03-11 17:23	rqueralta	Status	new => scheduled
2021-03-22 09:10	marvintm	Review Assigned To	=> marvintm
2021-03-22 09:10	marvintm	Note Added: 0126821
2021-03-22 09:10	marvintm	Status	scheduled => closed
2021-03-22 09:10	marvintm	Resolution	open => unable to reproduce
2021-03-22 09:10	marvintm	File Added: Captura de pantalla 2021-03-22 a las 9.10.30.png
2021-03-24 09:28	ucarrion	Assigned To	rqueralta => marvintm
2021-03-24 09:28	ucarrion	Note Added: 0126878
2021-03-24 09:28	ucarrion	Status	closed => new
2021-03-24 09:28	ucarrion	Resolution	unable to reproduce => open
2021-03-25 08:12	marvintm	Assigned To	marvintm => Retail
2021-03-26 23:36	rqueralta	File Added: 0001-Fix-BUG-46049-Payment-DialogButton-should-be-updated.patch
2021-03-26 23:49	rqueralta	Assigned To	Retail => rqueralta
2021-03-26 23:50	rqueralta	Status	new => scheduled
2021-03-29 07:00	marvintm	Relationship added	duplicate of 0045337
2021-03-29 07:00	marvintm	Note Added: 0126962
2021-03-29 07:00	marvintm	Status	scheduled => closed
2021-03-29 07:00	marvintm	Resolution	open => duplicate
2021-03-29 07:00	marvintm	Fixed in Version	=> RR21Q1

Copyright © 2000 - 2009 MantisBT Group