Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0045965 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Retail Modules] Web POS | minor | have not tried | 2021-02-27 07:18 | 2021-03-24 07:30 | |||
| Reporter | caristu | View Status | public | |||||
| Assigned To | ranjith_qualiantech_com | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | RR21Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0045965: Extract action preparations requesting approvals from the business logic bundle | |||||||
| Description | Extract action preparations requesting approvals (for example this one[1]) from the business logic bundle. This is needed in order to avoid having duplicated approval requests when using the new approvals infrastructure[2] [1] https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/AddProduct.js#L122 [^] [2] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/297 [^] | |||||||
| Steps To Reproduce | In description | |||||||
| Proposed Solution | Extract the action preparations which are requesting approvals into separated files which will not be included in the business logic bundle | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0126511) hgbot (developer) 2021-03-05 07:08 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/337 [^] |
|
(0126542) hgbot (developer) 2021-03-08 07:37 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 434b108e22e193e2636b8c951d7f8b778796c45e Author: Ranjith S R <ranjith@qualiantech.com> Date: 2021-03-08T06:36:51+00:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/434b108e22e193e2636b8c951d7f8b778796c45e [^] Fixed ISSUE-45965: Moved Approval from BusinessLogic to POS --- A web/org.openbravo.retail.posterminal/js/actionpreparation/AddProduct.js A web/org.openbravo.retail.posterminal/js/actionpreparation/CompleteLayaway.js A web/org.openbravo.retail.posterminal/js/actionpreparation/CompleteTicket.js A web/org.openbravo.retail.posterminal/js/actionpreparation/DeleteLine.js A web/org.openbravo.retail.posterminal/js/actionpreparation/SetLinePrice.js M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java M web-test/model/business-object/ticket/CompleteTicketUtils.test.js M web-test/model/business-object/ticket/actions/AddProduct-actionPreparation.test.js M web-test/model/business-object/ticket/actions/DeleteLine-actionPreparation.test.js M web-test/model/business-object/ticket/actions/SetLinePrice-actionPreparation.test.js M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/CompleteTicketUtils.js M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/AddProduct.js M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CompleteLayaway.js M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/DeleteLine.js M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/SetLinePrice.js --- |
|
(0126543) hgbot (developer) 2021-03-08 07:37 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/337 [^] |
|
(0126837) hgbot (developer) 2021-03-22 15:07 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/349 [^] |
|
(0126871) hgbot (developer) 2021-03-24 07:30 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: b2a0fc10042bda23a058dba458e392eb117cb5b7 Author: Ranjith S R <ranjith@qualiantech.com> Date: 2021-03-22T15:05:15+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/b2a0fc10042bda23a058dba458e392eb117cb5b7 [^] Related to ISSUE-45965: Renamed ActionPreparations js files for approval actions --- A web/org.openbravo.retail.posterminal/js/actionpreparation/AddProductApproval.js A web/org.openbravo.retail.posterminal/js/actionpreparation/CompleteLayawayApproval.js A web/org.openbravo.retail.posterminal/js/actionpreparation/CompleteTicketApproval.js A web/org.openbravo.retail.posterminal/js/actionpreparation/DeleteLineApproval.js A web/org.openbravo.retail.posterminal/js/actionpreparation/SetLinePriceApproval.js M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java --- |
|
(0126872) hgbot (developer) 2021-03-24 07:30 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/349 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2021-02-27 07:18 | caristu | New Issue | |
| 2021-02-27 07:18 | caristu | Assigned To | => Retail |
| 2021-02-27 07:18 | caristu | OBNetwork customer | => No |
| 2021-02-27 07:18 | caristu | Triggers an Emergency Pack | => No |
| 2021-03-01 10:29 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2021-03-03 14:25 | ranjith_qualiantech_com | Status | new => scheduled |
| 2021-03-05 07:08 | hgbot | Merge Request Status | => open |
| 2021-03-05 07:08 | hgbot | Note Added: 0126511 | |
| 2021-03-05 13:54 | aferraz | Issue Monitored: aferraz | |
| 2021-03-08 07:36 | hgbot | Merge Request Status | open => approved |
| 2021-03-08 07:37 | hgbot | Resolution | open => fixed |
| 2021-03-08 07:37 | hgbot | Status | scheduled => closed |
| 2021-03-08 07:37 | hgbot | Fixed in Version | => RR21Q2 |
| 2021-03-08 07:37 | hgbot | Note Added: 0126542 | |
| 2021-03-08 07:37 | hgbot | Note Added: 0126543 | |
| 2021-03-22 15:07 | hgbot | Note Added: 0126837 | |
| 2021-03-24 07:30 | hgbot | Note Added: 0126871 | |
| 2021-03-24 07:30 | hgbot | Note Added: 0126872 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |