Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0045924
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSmajoralways2021-02-16 09:592021-02-24 11:57
Reportergorka_gilView Statuspublic 
Assigned Togorka_gil 
PriorityurgentResolutionfixedFixed in VersionRR20Q4.2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget VersionRR20Q4.2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/commit/87c3e6d251f0c8db080607ba3c4739a551bde0b9 [^]
Triggers an Emergency PackNo
Summary

0045924: The background Incremental refresh is silently launching a normal incremental background

DescriptionThere are 3 types of masterdata refresh:
- full
- incremental
- incremental in background (splitted in requests and in save into db)

There are some problems with the incremental in background:
- 1) Before start the requests, a normal incremental is launched,
It is not visible because it doesn't show anything in the UI, but it can be seen in the console.
- 2) In the background incremental, the models requested are not saved into indexeddb
- 3) In the background incremental, the last refresh time is not correctly saved, so it requests always the same data (from last full or normal incremental)
- 4) In the background incremental, the requested model changes are stored in a variable called modifiedMasterdataModels, but it is storing all the model, not just the modified ones.

Note that issues 2, 3 and 4 are hidden by the first one, since the normal incremental does all the update, then when the background starts, there is nothing to update.
Steps To ReproduceIn the pos, open the console and execute:
OB.UTIL.loadModelsIncFunc()

It should start with (background incremental):
[requestIncrementalMasterdata] Starting incremental Request RefreshMasterdata

But instead, before that, it is doing a normal incremental:
[incrementalMasterdataRefresh] Starting incremental RefreshMasterdata
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0045900 closedgorka_gil The background Incremental refresh is silently launching a normal incremental background 

-  Notes
(0126330)
hgbot (developer)
2021-02-24 11:45

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/169 [^]
(0126331)
hgbot (developer)
2021-02-24 11:46

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/321 [^]
(0126338)
hgbot (developer)
2021-02-24 11:57

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 6f8e08df6a132709423c1019f7668f80a0ea6f9e
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2021-02-24T11:43:34+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/6f8e08df6a132709423c1019f7668f80a0ea6f9e [^]

Related to ISSUE-45924: if the login was offline, avoid masterdata refresh on interval

Also fix OB.UTIL.masterdataRefreshStatus when there is no masterdata to update

---
M web/org.openbravo.retail.posterminal/js/utils/ob-utilitiesuipos.js
---
(0126339)
hgbot (developer)
2021-02-24 11:57

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/321 [^]
(0126340)
hgbot (developer)
2021-02-24 11:57

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/169 [^]
(0126341)
hgbot (developer)
2021-02-24 11:57

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 6c01af00653bda89a496d492711b2c3e67a1a984
Author: Gorka Gil <gorka.gil@openbravo.com>
Date: 2021-02-24T11:42:57+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/6c01af00653bda89a496d492711b2c3e67a1a984 [^]

Fixes ISSUE-45924: Fix incremental refresh after indexeddb changes

1) Fixed the normal incremental done before the background requests
Move the indexeddb normal incremental and full, from the load models, to the login
after each of the websql full or incremental refresh is done.

This is consistent with the backgroud incremental, that also call to the
update of websql models, and when finish to the update of indexeddb models

2) Fix save into indexeddb of the background incremental
- Check for masterdataModel.data.length instead masterdataModel.length

3) Fix background incremental on indexeddb, to only load the new data
- Fixed removing the save in local store of requestTimestamp,
in a moment that we have the old request date, later is done another save
with the correct date

4) Fix background incremental on indexeddb, to only save in
 modifiedMasterdataModels only the modified models, instead all models.

5) when executig loadModels after an offline login, call to the parent callback
instead the callback, to avoid printng output of masterdata refresh done, when in
reallity it was canceled.

6) Skip load of masterdata on login, this was done in websql inside the loadModels,
but since indexeddb models are not loadded by loadModels, is needed to check
for offlineLogin also outside of loadModels

---
M web/org.openbravo.mobile.core/app/model/masterdata/MasterdataController.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---

- Issue History
Date Modified Username Field Change
2021-02-19 10:50 marvintm Type defect => backport
2021-02-19 10:50 marvintm Target Version => RR20Q4.2
2021-02-24 11:45 hgbot Note Added: 0126330
2021-02-24 11:46 hgbot Note Added: 0126331
2021-02-24 11:57 hgbot Note Added: 0126338
2021-02-24 11:57 hgbot Note Added: 0126339
2021-02-24 11:57 hgbot Resolution open => fixed
2021-02-24 11:57 hgbot Status scheduled => closed
2021-02-24 11:57 hgbot Note Added: 0126340
2021-02-24 11:57 hgbot Fixed in Version => RR20Q4.2
2021-02-24 11:57 hgbot Note Added: 0126341


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker