Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0045823
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 02. Master data managementmajoralways2021-02-01 12:202021-02-23 17:17
Reportersebastien_lironView Statuspublic 
Assigned Tomarkmm82 
PriorityhighResolutionfixedFixed in VersionPR21Q2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0045823: A hard limit exist for manually creates products variants

DescriptionA hard limit exist for manually creates products variants

if (variantNumber > 1000) {
        throw new OBException("HighRecords");
      }

Here : org.openbravo.materialmgmt.ManageVariantsDS

From product Team :
That 1000 limit was put there to prevent performance problems. If you need to increase that limit, one way to do it would be to replace the hardcoded limit with a value read from a preference (like TreeDatasourceFetchLimit does) so that clients can increase that value ONLY after checking that the performance is good enough in the worst case.

Steps To Reproduce- in the ERP
- create a variant product
- add several carac to it with a lor of values
- use the generate variant button
Proposed Solutionone way to do it would be to replace the hardcoded limit with a value read from a preference (like TreeDatasourceFetchLimit does)
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0126277)
markmm82 (developer)
2021-02-22 18:18
edited on: 2021-02-23 13:51

Test Plan:
Log in the ERP as F&B
- Go to Product window and create a variant product
- Go to Characteristic tab and add several characteristics to it with some values
- Execute "Manage Variants" process by clicking on the button.
- Notice all possible variants of selected characteristics are shown.
- Done and check process ends successfully.

- Create a new preference visible at F&B client
  Property List = false
  Attribute = ManageVariantsLimit
  Value = 3
- Go to created product and execute the "Manage Variants" process again.
- Notice an error message is shown:
  "The number of records (<number>) is too high. Please, either try to review and reduce the number of product characteristics or alternatively set the ManageVariantsLimit preference to a higher value than 3"

- Change the new preference value to 1000
- Execute "Manage Variants" process by clicking on the button.
- Notice there isn't any error message and all possible variants of selected characteristics are shown.
- Done and check process ends successfully.

(0126280)
hgbot (developer)
2021-02-22 20:56

Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/318 [^]
(0126307)
hgbot (developer)
2021-02-23 17:17

Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/318 [^]
(0126308)
hgbot (developer)
2021-02-23 17:17

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 58495fbf6ca54792acda306179b30561c24e307d
Author: Mark Orlando Molina <markmm82@gmail.com>
Date: 2021-02-23T16:17:49+00:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/58495fbf6ca54792acda306179b30561c24e307d [^]

Fixes ISSUE-45823: Created new "ManageVariantsLimit" preference limit

Currently was hard-coded a fixed limit of 1000 possible records that can be created when processing products variants.

To make more flexible this limit, a new "ManageVariantsLimit" preference is created as an attribute preference to handle this threshold in a more configurable way.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src/org/openbravo/materialmgmt/ManageVariantsDS.java
---

- Issue History
Date Modified Username Field Change
2021-02-01 12:20 sebastien_liron New Issue
2021-02-01 12:20 sebastien_liron Assigned To => Triage Finance
2021-02-01 12:20 sebastien_liron Modules => Core
2021-02-01 12:20 sebastien_liron Triggers an Emergency Pack => No
2021-02-19 11:41 vmromanos Category 06. Material requirement planning (MRP) => 02. Master data management
2021-02-19 11:41 vmromanos Type design defect => defect
2021-02-19 11:41 vmromanos Target Version PR20Q3.4 =>
2021-02-22 13:31 markmm82 Assigned To Triage Finance => markmm82
2021-02-22 13:31 markmm82 Status new => scheduled
2021-02-22 18:18 markmm82 Note Added: 0126277
2021-02-22 20:56 hgbot Note Added: 0126280
2021-02-23 13:51 markmm82 Note Edited: 0126277 View Revisions
2021-02-23 17:17 hgbot Resolution open => fixed
2021-02-23 17:17 hgbot Status scheduled => closed
2021-02-23 17:17 hgbot Note Added: 0126307
2021-02-23 17:17 hgbot Fixed in Version => PR21Q2
2021-02-23 17:17 hgbot Note Added: 0126308


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker