Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0045765
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo Localizations] Localization Portugalmajoralways2021-01-20 14:512021-09-10 14:18
ReportergsuarezView Statuspublic 
Assigned Topsanjuan 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Regression introduced in release
Summary

0045765: Limit location field in Customer to 50 characters - SAFT

DescriptionWhen validating the SAF-T file from Portugal, an error occurred in a bussiness partner because the location (town) has more than 50 characters.
Steps To ReproduceMake a sales on a WebPOS configurated with SAFT functionality selecting a business partner that have a location with more than 50 characters.

We need to stop the sales when the system identifies a location has more than 50 characters.
TagsNo tags attached.
Attached Filesdiff file icon saftptCity.diff [^] (2,452 bytes) 2021-09-01 14:26 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0126138)
lbressan (developer)
2021-02-17 11:54

anyone update?
(0126145)
psanjuan (manager)
2021-02-17 18:01

Reported
http://practicsbs.zendesk.com/hc/requests/7124 [^]
(0126847)
psanjuan (manager)
2021-03-23 11:09

Reported once again
http://practicsbs.zendesk.com/hc/requests/7771 [^]
(0131285)
psanjuan (manager)
2021-08-24 09:59

https://practicsbs.zendesk.com/hc/es/requests/10869 [^]
(0131488)
psanjuan (manager)
2021-09-01 14:26

Respuesta de Practics.
Buenas tardes Patricia,

Hemos revisado todos los campos City que puede haber en el fichero E-Fatura, y hemos limitado su contenido a 50 caracteres para que no aparezca dicho error en el validador.

La opción escogida ha sido la de comprobar si la longitud de la "ciudad" es superior a 50 caracteres, y en caso afirmativo, usar los primeros 50 caracteres para rellenar el campo.

Es la misma lógica que hemos aplicado en otros campos que nos daban el mismo error.

Os dejo el DIFF adjunto para que podáis aplicar los cambios en vuestro repositorio. El diff debe aplicarse en el path: .../modules/com.practicsbs.saftpt

Gracias,

Atentamente
(0131680)
hgbot (developer)
2021-09-09 16:12

Merge Request created: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/merge_requests/13 [^]
(0131681)
hgbot (developer)
2021-09-09 16:17

Merge Request created: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/merge_requests/14 [^]
(0131682)
hgbot (developer)
2021-09-09 16:21

Merge Request created: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/merge_requests/15 [^]
(0131683)
hgbot (developer)
2021-09-09 16:21

Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt [^]
Changeset: c35cad7480b453d326952409de45109abd9b05ba
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2021-09-09T16:16:03+02:00
URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/commit/c35cad7480b453d326952409de45109abd9b05ba [^]

Fixed ISSUE-45765: Limit city to 50 characters

In the places where a city is set, we make sure the length is always <= 50

Patch created by Practis and adapted to new versions by VMA

---
M src/com/practicsbs/saftpt/data/ExportHeader.java
M src/com/practicsbs/saftpt/data/ExportMFSupplier.java
M src/com/practicsbs/saftpt/data/Utils.java
---
(0131684)
hgbot (developer)
2021-09-09 16:21

Merge request merged: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/merge_requests/14 [^]
(0131685)
hgbot (developer)
2021-09-09 16:22

Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt [^]
Changeset: bef73a95134970c6f937c0e7a69e0a88be91733f
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2021-09-09T16:20:18+02:00
URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/commit/bef73a95134970c6f937c0e7a69e0a88be91733f [^]

Fixed ISSUE-45765: Limit city to 50 characters

In the places where a city is set, we make sure the length is always <= 50

Patch created by Practis and adapted to new versions by VMA

---
M src/com/practicsbs/saftpt/data/ExportHeader.java
M src/com/practicsbs/saftpt/data/ExportMFSupplier.java
M src/com/practicsbs/saftpt/data/Utils.java
---
(0131686)
hgbot (developer)
2021-09-09 16:22

Merge request merged: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/merge_requests/15 [^]
(0131687)
hgbot (developer)
2021-09-09 16:22

Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt [^]
Changeset: 2ab3ef1c660f1bb73e3ab4d2f4e34f2ea2427556
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2021-09-09T16:05:08+02:00
URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/commit/2ab3ef1c660f1bb73e3ab4d2f4e34f2ea2427556 [^]

Fixed ISSUE-45765: Limit city to 50 characters

In the places where a city is set, we make sure the length is always <= 50

Patch created by Practis and adapted to new versions by VMA

---
M src/com/practicsbs/saftpt/data/ExportHeader.java
M src/com/practicsbs/saftpt/data/ExportMFSupplier.java
M src/com/practicsbs/saftpt/data/Utils.java
---
(0131688)
hgbot (developer)
2021-09-09 16:22

Merge request merged: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/merge_requests/13 [^]
(0131707)
hgbot (developer)
2021-09-10 14:18

Merge Request created: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/merge_requests/16 [^]
(0131708)
hgbot (developer)
2021-09-10 14:18

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt [^]
Changeset: df7fcaaf3b85ef22d744412b1da5d7840b9599f5
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2021-09-10T14:15:55+02:00
URL: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/commit/df7fcaaf3b85ef22d744412b1da5d7840b9599f5 [^]

Fixed ISSUE-45765: Limit city to 50 characters

In the places where a city is set, we make sure the length is always <= 50

Patch created by Practis

---
M src/com/practicsbs/saftpt/data/ExportHeader.java
M src/com/practicsbs/saftpt/data/ExportMFSupplier.java
M src/com/practicsbs/saftpt/data/Utils.java
---
(0131709)
hgbot (developer)
2021-09-10 14:18

Merge request merged: https://gitlab.com/openbravo/product/pmods/com.practicsbs.saftpt/-/merge_requests/16 [^]

- Issue History
Date Modified Username Field Change
2021-01-20 14:51 gsuarez New Issue
2021-01-20 14:51 gsuarez Assigned To => Xpand-IT
2021-01-20 14:51 gsuarez Resolution time => 1581289200
2021-02-17 11:54 lbressan Note Added: 0126138
2021-02-17 16:18 egoitz Resolution time 1581289200 => 1582153200
2021-02-17 16:18 egoitz Assigned To Xpand-IT => Triage Finance
2021-02-17 18:01 psanjuan Note Added: 0126145
2021-02-23 13:13 vmromanos Status new => acknowledged
2021-03-12 13:09 psanjuan Assigned To Triage Finance => psanjuan
2021-03-23 11:09 psanjuan Note Added: 0126847
2021-08-23 10:28 aferraz Resolution time 1582153200 => 1613775600
2021-08-24 09:00 vmromanos Status acknowledged => scheduled
2021-08-24 09:59 psanjuan Note Added: 0131285
2021-09-01 14:26 psanjuan Note Added: 0131488
2021-09-01 14:26 psanjuan File Added: saftptCity.diff
2021-09-09 16:12 hgbot Note Added: 0131680
2021-09-09 16:17 hgbot Note Added: 0131681
2021-09-09 16:21 hgbot Note Added: 0131682
2021-09-09 16:21 hgbot Resolution open => fixed
2021-09-09 16:21 hgbot Status scheduled => resolved
2021-09-09 16:21 hgbot Note Added: 0131683
2021-09-09 16:21 hgbot Note Added: 0131684
2021-09-09 16:22 hgbot Note Added: 0131685
2021-09-09 16:22 hgbot Note Added: 0131686
2021-09-09 16:22 hgbot Note Added: 0131687
2021-09-09 16:22 hgbot Note Added: 0131688
2021-09-10 14:18 hgbot Note Added: 0131707
2021-09-10 14:18 hgbot Status resolved => closed
2021-09-10 14:18 hgbot Note Added: 0131708
2021-09-10 14:18 hgbot Note Added: 0131709


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker