Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0045513
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-11-25 18:162020-12-16 15:58
ReportercbernerView Statuspublic 
Assigned Tocberner 
PrioritynormalResolutionfixedFixed in VersionPR21Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0045513: FIN_BankStatementImport class should use OBCriteria instead of string building

DescriptionIn method matchBusinessPartnerByNameTokens of this class, it uses OBQuery and requires extra steps of String formatting and String building, this should be changed to OBCriteria to avoid concatenating String parameters.
Steps To ReproduceIn description.
Proposed SolutionChange OBQuery usage in method matchBusinessPartnerByNameTokens to OBCriteria and refactor what is necessary.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0038136 acknowledgedTriage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 

-  Notes
(0124622)
hgbot (developer)
2020-11-25 18:36

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/246 [^]
(0124627)
hgbot (developer)
2020-11-25 18:42

 Merge request closed: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/246 [^]
(0124886)
hgbot (developer)
2020-12-16 15:58

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/246 [^]
(0124887)
hgbot (developer)
2020-12-16 15:58

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: b901921b99e266aceec3a45a2db03aa139a23bc5
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2020-12-16T10:56:04+01:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/b901921b99e266aceec3a45a2db03aa139a23bc5 [^]

Fixes ISSUE-45513: FIN_BankStatementImport class should use OBCriteria

This class should use OBCriteria instead of OBQuery + String building,
this avoids concatenating String parameters.

Query has been refactored to use OBCriteria and String building has been
removed on this part, as it is no longer necessary.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_BankStatementImport.java
---

- Issue History
Date Modified Username Field Change
2020-11-25 18:16 cberner New Issue
2020-11-25 18:16 cberner Assigned To => cberner
2020-11-25 18:16 cberner OBNetwork customer => No
2020-11-25 18:16 cberner Modules => Core
2020-11-25 18:16 cberner Triggers an Emergency Pack => No
2020-11-25 18:17 cberner Relationship added related to 0038136
2020-11-25 18:36 hgbot Merge Request Status => open
2020-11-25 18:36 hgbot Note Added: 0124622
2020-11-25 18:42 hgbot Note Added: 0124627
2020-12-02 13:21 hgbot Merge Request Status open => approved
2020-12-16 15:58 hgbot Resolution open => fixed
2020-12-16 15:58 hgbot Status new => closed
2020-12-16 15:58 hgbot Note Added: 0124886
2020-12-16 15:58 hgbot Fixed in Version => PR21Q1
2020-12-16 15:58 hgbot Note Added: 0124887

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker