0045489: Add support for axisc3 cards : CKCSY and CKLSY

Description

Add support for two new payment method types of axisc3: CKCSY and CKLSY

Previously were only cards ACP

Now there are:
ACP
ACP with emitter CKCSY
ACP with emitter CKLSY

Steps To Reproduce

Tags

No tags attached.

Attached Files

45489-org.openbravo.retail.axisc3-ACPnewPayments.diff [^] (6,166 bytes) 2020-11-23 22:20 [Show Content] [Hide Content]

commit c681eb862e3b99bc1e77c43b0904464b3dfcc197
Author: Gorka Gil <gorka.gil@openbravo.com>
Date:   Thu Nov 19 21:46:11 2020 +0100

    Add payment method types: ACP-CKCSY and ACP-CKLSY both online and offline

diff --git a/src-db/database/sourcedata/OBPOS_PAYMENTMETHOD_TYPE.xml b/src-db/database/sourcedata/OBPOS_PAYMENTMETHOD_TYPE.xml
index 5f1ae4f..aecf9e7 100644
--- a/src-db/database/sourcedata/OBPOS_PAYMENTMETHOD_TYPE.xml
+++ b/src-db/database/sourcedata/OBPOS_PAYMENTMETHOD_TYPE.xml
@@ -22,6 +22,17 @@
 <!--08445261168B4FAC98591BC15AFAA981-->  <AD_MODULE_ID><![CDATA[6333A18A4D004A51BBF0C4D6F40754A3]]></AD_MODULE_ID>
 <!--08445261168B4FAC98591BC15AFAA981--></OBPOS_PAYMENTMETHOD_TYPE>
 
+<!--08C705E7915F4F46936590F2DB0E9D6F--><OBPOS_PAYMENTMETHOD_TYPE>
+<!--08C705E7915F4F46936590F2DB0E9D6F-->  <OBPOS_PAYMENTMETHOD_TYPE_ID><![CDATA[08C705E7915F4F46936590F2DB0E9D6F]]></OBPOS_PAYMENTMETHOD_TYPE_ID>
+<!--08C705E7915F4F46936590F2DB0E9D6F-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
+<!--08C705E7915F4F46936590F2DB0E9D6F-->  <AD_ORG_ID><![CDATA[0]]></AD_ORG_ID>
+<!--08C705E7915F4F46936590F2DB0E9D6F-->  <ISACTIVE><![CDATA[Y]]></ISACTIVE>
+<!--08C705E7915F4F46936590F2DB0E9D6F-->  <PROVIDER><![CDATA[AC3_CardProvider]]></PROVIDER>
+<!--08C705E7915F4F46936590F2DB0E9D6F-->  <VALUE><![CDATA[ACP-CKCSY.ONLINE]]></VALUE>
+<!--08C705E7915F4F46936590F2DB0E9D6F-->  <NAME><![CDATA[ACCORD PISTE CKCSY - ONLINE]]></NAME>
+<!--08C705E7915F4F46936590F2DB0E9D6F-->  <AD_MODULE_ID><![CDATA[6333A18A4D004A51BBF0C4D6F40754A3]]></AD_MODULE_ID>
+<!--08C705E7915F4F46936590F2DB0E9D6F--></OBPOS_PAYMENTMETHOD_TYPE>
+
 <!--094F6B2031064150975ACAF75419E694--><OBPOS_PAYMENTMETHOD_TYPE>
 <!--094F6B2031064150975ACAF75419E694-->  <OBPOS_PAYMENTMETHOD_TYPE_ID><![CDATA[094F6B2031064150975ACAF75419E694]]></OBPOS_PAYMENTMETHOD_TYPE_ID>
 <!--094F6B2031064150975ACAF75419E694-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
@@ -462,6 +473,17 @@
 <!--7EECDC216D754F0B86F34C782788E5DF-->  <AD_MODULE_ID><![CDATA[6333A18A4D004A51BBF0C4D6F40754A3]]></AD_MODULE_ID>
 <!--7EECDC216D754F0B86F34C782788E5DF--></OBPOS_PAYMENTMETHOD_TYPE>
 
+<!--851BB504422946279982FE971319DB5F--><OBPOS_PAYMENTMETHOD_TYPE>
+<!--851BB504422946279982FE971319DB5F-->  <OBPOS_PAYMENTMETHOD_TYPE_ID><![CDATA[851BB504422946279982FE971319DB5F]]></OBPOS_PAYMENTMETHOD_TYPE_ID>
+<!--851BB504422946279982FE971319DB5F-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
+<!--851BB504422946279982FE971319DB5F-->  <AD_ORG_ID><![CDATA[0]]></AD_ORG_ID>
+<!--851BB504422946279982FE971319DB5F-->  <ISACTIVE><![CDATA[Y]]></ISACTIVE>
+<!--851BB504422946279982FE971319DB5F-->  <PROVIDER><![CDATA[AC3_CardProvider]]></PROVIDER>
+<!--851BB504422946279982FE971319DB5F-->  <VALUE><![CDATA[ACP-CKLSY.ONLINE]]></VALUE>
+<!--851BB504422946279982FE971319DB5F-->  <NAME><![CDATA[ACCORD PISTE CKLSY - ONLINE]]></NAME>
+<!--851BB504422946279982FE971319DB5F-->  <AD_MODULE_ID><![CDATA[6333A18A4D004A51BBF0C4D6F40754A3]]></AD_MODULE_ID>
+<!--851BB504422946279982FE971319DB5F--></OBPOS_PAYMENTMETHOD_TYPE>
+
 <!--86698064A8784F4BA2B5460C1D529067--><OBPOS_PAYMENTMETHOD_TYPE>
 <!--86698064A8784F4BA2B5460C1D529067-->  <OBPOS_PAYMENTMETHOD_TYPE_ID><![CDATA[86698064A8784F4BA2B5460C1D529067]]></OBPOS_PAYMENTMETHOD_TYPE_ID>
 <!--86698064A8784F4BA2B5460C1D529067-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
@@ -495,6 +517,17 @@
 <!--9009E1719FEA45898A7FA12FAECB9954-->  <AD_MODULE_ID><![CDATA[6333A18A4D004A51BBF0C4D6F40754A3]]></AD_MODULE_ID>
 <!--9009E1719FEA45898A7FA12FAECB9954--></OBPOS_PAYMENTMETHOD_TYPE>
 
+<!--9B09FB8DF6DA454C993C6674681007B7--><OBPOS_PAYMENTMETHOD_TYPE>
+<!--9B09FB8DF6DA454C993C6674681007B7-->  <OBPOS_PAYMENTMETHOD_TYPE_ID><![CDATA[9B09FB8DF6DA454C993C6674681007B7]]></OBPOS_PAYMENTMETHOD_TYPE_ID>
+<!--9B09FB8DF6DA454C993C6674681007B7-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
+<!--9B09FB8DF6DA454C993C6674681007B7-->  <AD_ORG_ID><![CDATA[0]]></AD_ORG_ID>
+<!--9B09FB8DF6DA454C993C6674681007B7-->  <ISACTIVE><![CDATA[Y]]></ISACTIVE>
+<!--9B09FB8DF6DA454C993C6674681007B7-->  <PROVIDER><![CDATA[AC3_CardProvider]]></PROVIDER>
+<!--9B09FB8DF6DA454C993C6674681007B7-->  <VALUE><![CDATA[ACP-CKLSY.OFFLINE]]></VALUE>
+<!--9B09FB8DF6DA454C993C6674681007B7-->  <NAME><![CDATA[ACCORD PISTE CKLSY - OFFLINE]]></NAME>
+<!--9B09FB8DF6DA454C993C6674681007B7-->  <AD_MODULE_ID><![CDATA[6333A18A4D004A51BBF0C4D6F40754A3]]></AD_MODULE_ID>
+<!--9B09FB8DF6DA454C993C6674681007B7--></OBPOS_PAYMENTMETHOD_TYPE>
+
 <!--9B39615EECE145AB9D7D773FD7D9DE17--><OBPOS_PAYMENTMETHOD_TYPE>
 <!--9B39615EECE145AB9D7D773FD7D9DE17-->  <OBPOS_PAYMENTMETHOD_TYPE_ID><![CDATA[9B39615EECE145AB9D7D773FD7D9DE17]]></OBPOS_PAYMENTMETHOD_TYPE_ID>
 <!--9B39615EECE145AB9D7D773FD7D9DE17-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
@@ -803,6 +836,17 @@
 <!--E4FD999A1E4940AE8F2AE4F18F016963-->  <AD_MODULE_ID><![CDATA[6333A18A4D004A51BBF0C4D6F40754A3]]></AD_MODULE_ID>
 <!--E4FD999A1E4940AE8F2AE4F18F016963--></OBPOS_PAYMENTMETHOD_TYPE>
 
+<!--E93926E42C5D441982F9BB1057B510ED--><OBPOS_PAYMENTMETHOD_TYPE>
+<!--E93926E42C5D441982F9BB1057B510ED-->  <OBPOS_PAYMENTMETHOD_TYPE_ID><![CDATA[E93926E42C5D441982F9BB1057B510ED]]></OBPOS_PAYMENTMETHOD_TYPE_ID>
+<!--E93926E42C5D441982F9BB1057B510ED-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
+<!--E93926E42C5D441982F9BB1057B510ED-->  <AD_ORG_ID><![CDATA[0]]></AD_ORG_ID>
+<!--E93926E42C5D441982F9BB1057B510ED-->  <ISACTIVE><![CDATA[Y]]></ISACTIVE>
+<!--E93926E42C5D441982F9BB1057B510ED-->  <PROVIDER><![CDATA[AC3_CardProvider]]></PROVIDER>
+<!--E93926E42C5D441982F9BB1057B510ED-->  <VALUE><![CDATA[ACP-CKCSY.OFFLINE]]></VALUE>
+<!--E93926E42C5D441982F9BB1057B510ED-->  <NAME><![CDATA[ACCORD PISTE CKCSY - OFFLINE]]></NAME>
+<!--E93926E42C5D441982F9BB1057B510ED-->  <AD_MODULE_ID><![CDATA[6333A18A4D004A51BBF0C4D6F40754A3]]></AD_MODULE_ID>
+<!--E93926E42C5D441982F9BB1057B510ED--></OBPOS_PAYMENTMETHOD_TYPE>
+
 <!--EA5253A6599D4A09B018F8F0C3E005EA--><OBPOS_PAYMENTMETHOD_TYPE>
 <!--EA5253A6599D4A09B018F8F0C3E005EA-->  <OBPOS_PAYMENTMETHOD_TYPE_ID><![CDATA[EA5253A6599D4A09B018F8F0C3E005EA]]></OBPOS_PAYMENTMETHOD_TYPE_ID>
 <!--EA5253A6599D4A09B018F8F0C3E005EA-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>

45489-openbravohw-axisc3-ACPnewPayments.diff [^] (1,352 bytes) 2020-11-23 22:20 [Show Content] [Hide Content]

commit 515f34ac27a7e029e0454962d2a4e984d2d76110
Author: Gorka Gil <gorka.gil@openbravo.com>
Date:   Thu Nov 19 22:14:21 2020 +0100

    Add payment method types: ACP-CKCSY and ACP-CKLSY both online and offline

diff --git a/src/com/openbravo/retail/axisc3/AXISC3Library.java b/src/com/openbravo/retail/axisc3/AXISC3Library.java
index 8a0e3cd..00d7d53 100644
--- a/src/com/openbravo/retail/axisc3/AXISC3Library.java
+++ b/src/com/openbravo/retail/axisc3/AXISC3Library.java
@@ -518,7 +518,19 @@ public class AXISC3Library implements WebSocketListener, JC3ApiCallbacks {
   private String getPaymentBrand(JC3ApiC3Rspn response) {
 
     boolean onlinemode = response.getcAxisEnum() != C3OnlineModes.C3_ONLINEMODE_OFFLINE;
-    return response.getcCardTypeEnum().getTrigram() + "." + (onlinemode ? "ONLINE" : "OFFLINE");
+    String emitter;
+    if (response.getcCAIEmetteur() == "CKCSY") {
+      logger.fine("ACP-CKCSY");
+      emitter = "-CKCSY";
+    } else if (response.getcCAIEmetteur() == "CKLSY") {
+      logger.fine("ACP-CKLSY");
+      emitter = "-CKLSY";
+    } else {
+      logger.fine("ACP");
+      emitter = "";
+    }
+    return response.getcCardTypeEnum().getTrigram() + emitter + "."
+        + (onlinemode ? "ONLINE" : "OFFLINE");
   }
 
   private void printReceipt(String documentQualifier, String receipt) throws JSONException {

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0124576) gorka_gil (administrator) 2020-11-23 22:22	Uploaded proposal of fix, developed for a client, maybe needed changes for the standard. Also is not tested with physical devices.

Issue History
Date Modified	Username	Field	Change
2020-11-23 22:14	gorka_gil	New Issue
2020-11-23 22:14	gorka_gil	Assigned To	=> Retail
2020-11-23 22:14	gorka_gil	Triggers an Emergency Pack	=> No
2020-11-23 22:20	gorka_gil	File Added: 45489-org.openbravo.retail.axisc3-ACPnewPayments.diff
2020-11-23 22:20	gorka_gil	File Added: 45489-openbravohw-axisc3-ACPnewPayments.diff
2020-11-23 22:22	gorka_gil	Note Added: 0124576