Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0045447

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] A. Platform

minor

have not tried

2020-11-16 10:04

2020-12-02 13:50

Reporter

cberner

View Status

public

Assigned To

cberner

Priority

normal

Resolution

fixed

Fixed in Version

PR21Q1

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

approved

Review Assigned To

OBNetwork customer

No

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0045447: DimensionDisplayUtility uses String.format over hql to introduce certain params

Description

This class uses String.format on certain HQL query strings to replace certain params, it should instead include the params already in the query and not require usage of String.format.

Problematic format here: https://gitlab.com/openbravo/product/openbravo/-/blob/master/src/org/openbravo/erpCommon/utility/DimensionDisplayUtility.java#L427 [^]

Steps To Reproduce

In description.

Proposed Solution

Use the property, which in this case is actually a fixed String value on the HQL query.

Tags

No tags attached.

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0124404) hgbot (developer) 2020-11-16 10:07	Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/232 [^]

(0124626) hgbot (developer) 2020-11-25 18:42	Merge request closed: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/232 [^]

(0124689) hgbot (developer) 2020-12-02 13:42	Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/232 [^]

(0124690) hgbot (developer) 2020-12-02 13:42	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 6003c40d332b7f9d44d07fdaf5185023de26e44b Author: Cristian Berner <cristian.berner@openbravo.com> Date: 2020-12-02T13:34:36+01:00 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/6003c40d332b7f9d44d07fdaf5185023de26e44b [^] Fixes ISSUE-45447: DimensionDisplayUtility uses String.format over hql for params It uses String.format on certain HQL queries to introduce some params conditionally, this is not fully safe, so to avoid this it now includes the fixed String value in the HQL string. --- M src/org/openbravo/erpCommon/utility/DimensionDisplayUtility.java ---

(0124691) cberner (viewer) 2020-12-02 13:50	Test Plan: 1. Log in as Openbravo User 2. Open "Financial Account" window (Contains several Display logics that will execute the modified query) 3. Check that everything loaded as expected and there are no errors in Openbravo log.

Issue History
Date Modified	Username	Field	Change
2020-11-16 10:04	cberner	New Issue
2020-11-16 10:04	cberner	Assigned To	=> cberner
2020-11-16 10:04	cberner	OBNetwork customer	=> No
2020-11-16 10:04	cberner	Modules	=> Core
2020-11-16 10:04	cberner	Triggers an Emergency Pack	=> No
2020-11-16 10:07	hgbot	Merge Request Status	=> open
2020-11-16 10:07	hgbot	Note Added: 0124404
2020-11-25 18:42	hgbot	Note Added: 0124626
2020-12-02 13:21	hgbot	Merge Request Status	open => approved
2020-12-02 13:42	hgbot	Resolution	open => fixed
2020-12-02 13:42	hgbot	Status	new => closed
2020-12-02 13:42	hgbot	Note Added: 0124689
2020-12-02 13:42	hgbot	Fixed in Version	=> PR21Q1
2020-12-02 13:42	hgbot	Note Added: 0124690
2020-12-02 13:50	cberner	Note Added: 0124691

Copyright © 2000 - 2009 MantisBT Group