0045444: Loyalty subscription in bp edit mode uses saved data

Description

When editing a business partner, there is a new option to subscribe to a loyalty program.

The problem is that in the edit mode if you have change any data, it will not be reflected in the subscription.

Steps To Reproduce

Create a new business partner and set an email.
Save the new bp.
Click on edit
Change the email
Click on the loyalty subscription (+ symbol)
It will use the old email for the loyalty subscription

Proposed Solution

Force a save of the bp before the subscription
It should behave like the normal save,that will check all the validations, and if any validation fail the save will not happen and the subscription neither.

Tags

NOR

Attached Files

retail.loyalty.programs-45444.diff [^] (615 bytes) 2020-11-14 21:00 [Show Content] [Hide Content]

--- a/web/org.openbravo.retail.loyalty.programs/js/component/subscription-buttons.js
+++ b/web/org.openbravo.retail.loyalty.programs/js/component/subscription-buttons.js
@@ -136,6 +136,14 @@ enyo.kind({
   },
   tapAction: function() {
     if (this.checkCustomerSaved() && !this.readOnly) {
+      if (this.popup.$.footer.$.newCustomer_footer) {
+        // bp in edit mode
+        this.popup.$.footer.$.newCustomer_footer.$.newcustomersave.doSaveCustomer(
+          {
+            validations: true
+          }
+        );
+      }
       if (this.hasLoyalty) {
         this.manageLoyalty();
       } else {

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

0044505

closed

prakashmurugesan88

On webPOS it is not possible to subscribe in the business partner card on edit mode

Notes
(0124370) rafaroda (developer) 2020-11-13 14:59	This 0045444 comes from 0044505

(0124374) gorka_gil (administrator) 2020-11-14 21:00	Attached retail.loyalty.programs-45444.diff as proposal of fix

(0124575) gorka_gil (administrator) 2020-11-23 19:39	This fix will not be fixed in current pos. It implies changes in posterminal and also there is not a good way to control when and how ends the customer save, to execute after the subscription. Maybe in the new pos can be added to the then of the action to save customer, but in the pos previous to q4 it makes not worthy the effort to implement this correctly.

Issue History
Date Modified	Username	Field	Change
2020-11-13 13:34	gorka_gil	New Issue
2020-11-13 13:34	gorka_gil	Assigned To	=> Retail
2020-11-13 13:34	gorka_gil	Resolution time	=> 1607036400
2020-11-13 13:34	gorka_gil	Triggers an Emergency Pack	=> No
2020-11-13 13:37	gorka_gil	Tag Attached: NOR
2020-11-13 14:54	rafaroda	Relationship added	related to 0044505
2020-11-13 14:59	rafaroda	Note Added: 0124370
2020-11-14 21:00	gorka_gil	File Added: retail.loyalty.programs-45444.diff
2020-11-14 21:00	gorka_gil	Note Added: 0124374
2020-11-23 19:39	gorka_gil	Note Added: 0124575
2020-11-23 19:39	gorka_gil	Status	new => closed
2020-11-23 19:39	gorka_gil	Resolution	open => suspended