Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0045437
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2020-11-12 16:012020-11-24 13:14
ReportercbernerView Statuspublic 
Assigned Tocberner 
PrioritynormalResolutionfixedFixed in VersionPR21Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0045437: BaseOBObject appends parameters in hql query wrongly

DescriptionBaseOBObject appends some parameters in HQL query string incorrectly, in method getTranslation. To avoid this, OBCriteria should be used instead.
Steps To ReproduceIn description.
Proposed SolutionRefactor and use OBCriteria instead.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0038136 acknowledgedTriage Platform Base Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 

-  Notes
(0124330)
hgbot (developer)
2020-11-12 16:04

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/229 [^]
(0124584)
hgbot (developer)
2020-11-24 13:14

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/229 [^]
(0124585)
hgbot (developer)
2020-11-24 13:14

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 77234a7a40433a981bb8bf73429ea4afa35a8284
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2020-11-24T11:53:31+00:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/77234a7a40433a981bb8bf73429ea4afa35a8284 [^]

Fixes ISSUE-45437: BaseOBObject appends parameters in hql query wrongly

Method getTranslations appends some parameters in an HQL query strings
directly, this is incorrect as per our HQL style guide.
To avoid this, it has been transformed to use OBCriteria instead.

---
M src/org/openbravo/base/structure/BaseOBObject.java
---

- Issue History
Date Modified Username Field Change
2020-11-12 16:01 cberner New Issue
2020-11-12 16:01 cberner Assigned To => cberner
2020-11-12 16:01 cberner Modules => Core
2020-11-12 16:01 cberner Triggers an Emergency Pack => No
2020-11-12 16:01 cberner Relationship added related to 0038136
2020-11-12 16:04 hgbot Note Added: 0124330
2020-11-24 13:14 hgbot Resolution open => fixed
2020-11-24 13:14 hgbot Status new => closed
2020-11-24 13:14 hgbot Note Added: 0124584
2020-11-24 13:14 hgbot Fixed in Version => PR21Q1
2020-11-24 13:14 hgbot Note Added: 0124585

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker