Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0045410 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] A. Platform | minor | have not tried | 2020-11-10 16:46 | 2020-11-11 11:50 | |||
Reporter | cberner | View Status | public | |||||
Assigned To | cberner | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | PR21Q1 | |||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | approved | |||||||
Review Assigned To | ||||||||
OBNetwork customer | No | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0045410: .gitignore file ignores lib/build in ERP wrongly | |||||||
Description | lib/build is being ignored in ERP because of how .gitignore has been created. It should not ignore this folder. | |||||||
Steps To Reproduce | 1. Try to add a file within lib/build directory with git add <file>. 2. It will fail and show that you may run the same command with --force option. | |||||||
Proposed Solution | Change "build" in .gitignore to "/build", the latter only matches build directory on the top-most directory, while the former matches all build directories, independently where they come from. Probably all the other directories should also change to the same style in .gitignore. | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
![]() |
|
![]() |
|
(0124261) hgbot (developer) 2020-11-10 17:29 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/221 [^] |
(0124277) hgbot (developer) 2020-11-11 11:50 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/221 [^] |
(0124278) hgbot (developer) 2020-11-11 11:50 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 39a0b1c7219e0fefa33133d21ce6b6add2d054c0 Author: Cristian Berner <cristian.berner@openbravo.com> Date: 2020-11-11T09:59:47+01:00 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/39a0b1c7219e0fefa33133d21ce6b6add2d054c0 [^] Fixes ISSUE-45410: .gitignore file ignores lib/build when it shouldn't lib/build having build in its name was also excluded by .gitignore configuration. To fix this, an exception has been added to add this directory. --- M .gitignore --- |
![]() |
|||
Date Modified | Username | Field | Change |
2020-11-10 16:46 | cberner | New Issue | |
2020-11-10 16:46 | cberner | Assigned To | => cberner |
2020-11-10 16:46 | cberner | OBNetwork customer | => No |
2020-11-10 16:46 | cberner | Modules | => Core |
2020-11-10 16:46 | cberner | Triggers an Emergency Pack | => No |
2020-11-10 16:51 | shuehner | Issue Monitored: shuehner | |
2020-11-10 17:29 | hgbot | Merge Request Status | => open |
2020-11-10 17:29 | hgbot | Note Added: 0124261 | |
2020-11-11 11:50 | hgbot | Merge Request Status | open => approved |
2020-11-11 11:50 | hgbot | Resolution | open => fixed |
2020-11-11 11:50 | hgbot | Status | new => closed |
2020-11-11 11:50 | hgbot | Note Added: 0124277 | |
2020-11-11 11:50 | hgbot | Fixed in Version | => PR21Q1 |
2020-11-11 11:50 | hgbot | Note Added: 0124278 |
Copyright © 2000 - 2009 MantisBT Group |