Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0045331 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] 07. Sales management | major | always | 2020-10-26 15:47 | 2020-10-30 12:36 | |||
| Reporter | ngarcia | View Status | public | |||||
| Assigned To | cberner | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | PR20Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | PR20Q4 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | AugustoMauch | |||||||
| OBNetwork customer | Gold | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | 19420 | |||||||
| Regression level | Production - Confirmed Stable | |||||||
| Regression date | 2019-08-30 | |||||||
| Regression introduced in release | 3.0PR19Q3 | |||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0045331: Sales Order header can be saved without Invoice Address although it is mandatory | |||||||
| Description | Sales Order header can be saved without Invoice Address although it is mandatory. Business Partner window also has a mandatory field in a "More Information" field group, it can be saved if empty and More Information is collapsed. | |||||||
| Steps To Reproduce | As group admin role: Create a customer Add a location to it Set it as Invoicing Address = 'N' Create a Sales Order header Do not expand the More Information section Set the required fields (except Invoice Address) Click on Lines tab and check the header is saved and it shouldn't Open the More Information section Click on Lines tab Check the following error is shown: One or more fields contain illegal values, check the errors for each field. This is correct It is also reproducible in Business Partner window - Create a new BP - Open More Information collapsed field group - Empty "Credit Line Limit" field - Close More Information field group(collapse it) - Click on the Customer subtab - Check that the BP was saved, although the "Credit Line Limit" has invalid information. | |||||||
| Proposed Solution | Validate also hidden fields. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0123998) hgbot (developer) 2020-10-29 11:09 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/209 [^] |
|
(0124063) hgbot (developer) 2020-10-30 12:36 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/209 [^] |
|
(0124064) hgbot (developer) 2020-10-30 12:36 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: a473143321e3c885cc9b6fff993e66eb0187fbc2 Author: Cristian Berner <cristian.berner@openbravo.com> Date: 2020-10-29T11:08:48+01:00 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/a473143321e3c885cc9b6fff993e66eb0187fbc2 [^] Fixes ISSUE-45331: Record can be saved with missing mandatory field data If a mandatory field in a collapsed field group had no value or invalid values, the record could be saved by the auto-save when changing focus to a child tab. The approach taken here is to also validate hiddenFields that are not present because of being in a collapsed field group. form.validate method can be found in smartclient DynamicForm and it accepts as first argument a boolean indicating to validate or no hidden fields, it is now set to true on ob-view-form, fixing this issue. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-10-29 10:56 | cberner | Type | defect => backport |
| 2020-10-29 10:56 | cberner | Target Version | => PR20Q4 |
| 2020-10-29 11:09 | hgbot | Note Added: 0123998 | |
| 2020-10-30 12:27 | hgbot | Merge Request Status | open => approved |
| 2020-10-30 12:36 | hgbot | Resolution | open => fixed |
| 2020-10-30 12:36 | hgbot | Status | scheduled => closed |
| 2020-10-30 12:36 | hgbot | Note Added: 0124063 | |
| 2020-10-30 12:36 | hgbot | Fixed in Version | => PR20Q4 |
| 2020-10-30 12:36 | hgbot | Note Added: 0124064 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |