Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0045319 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] Z. Others | minor | have not tried | 2020-10-28 15:47 | 2020-10-30 13:25 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | PR21Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0045319: junit test IssuesTest.test18688 is very slow and probably obsolete in the current form | |||||||
| Description | That testcase is technically slow as it does a new hibernate/DAL initialization to register an extra SQL function. That test case was added when feature to register custom SQL functions to be used via hibernate was added (in issue 18688). However later in issue 38520 as more generic auto-registering of extra SQL functions to be use in WeldBaseTest was added. Either test18688 should be moved to register the function on startup as done in 38520. Alternatively it could be removed as the usage of functions added via 38520 is already testing the same functionality making test18688 likely obsolete | |||||||
| Steps To Reproduce | [junit] 12:34:57.996 INFO org.openbravo.test.base.OBBaseTest - *** Starting test case: org.openbravo.test.dal.IssuesTest.test18688 [junit] 12:34:57.999 INFO org.openbravo.test.base.OBBaseTest - Creating custom DAL layer initialization... [junit] 12:34:57.999 INFO org.openbravo.dal.core.DalLayerInitializer - Initializing in-memory model... [junit] 12:34:57.999 INFO org.openbravo.base.model.ModelProvider - Building runtime model [junit] 12:34:59.309 INFO org.openbravo.dal.core.DalLayerInitializer - Model read in-memory, generating mapping... [junit] 12:35:03.543 INFO org.openbravo.base.provider.OBConfigFileProvider - Found provider config file /srv/ci/workspace/try-checks-pgsql/config/provider-config.xml [junit] 12:35:03.548 INFO org.openbravo.dal.core.DalLayerInitializer - Dal layer initialized [junit] 12:35:03.575 INFO org.openbravo.test.base.OBBaseTest - *** Finished test case: org.openbravo.test.dal.IssuesTest.test18688 Shows the runtime of that single-test case to be quite slow + shows the extra DAL init. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0123990) hgbot (developer) 2020-10-29 07:30 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/206 [^] |
|
(0124066) hgbot (developer) 2020-10-30 13:25 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/206 [^] |
|
(0124067) hgbot (developer) 2020-10-30 13:25 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: c9a02ff2b3259a206bcc74e238cbdfe872574a69 Author: Asier Lostalé <asier.lostale@openbravo.com> Date: 2020-10-30T12:25:07+00:00 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/c9a02ff2b3259a206bcc74e238cbdfe872574a69 [^] fixed ISSUE-45319: IssuesTest.test18688 is slow and obsolete IssuesTest.test18688 is slow to execute (7-8s on top of DAL initialization). It is obsolete because funcion registration, which is what it tested, is already covered in other test cases. Therefore it is been deleted. --- M src-test/src/org/openbravo/test/dal/IssuesTest.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-10-28 15:47 | shuehner | New Issue | |
| 2020-10-28 15:47 | shuehner | Assigned To | => Triage Finance |
| 2020-10-28 15:47 | shuehner | Modules | => Core |
| 2020-10-28 15:47 | shuehner | Triggers an Emergency Pack | => No |
| 2020-10-28 15:50 | shuehner | Relationship added | related to 0038520 |
| 2020-10-28 15:50 | shuehner | Relationship added | related to 0018688 |
| 2020-10-28 15:56 | shuehner | Assigned To | Triage Finance => platform |
| 2020-10-29 07:24 | alostale | Assigned To | platform => alostale |
| 2020-10-29 07:30 | hgbot | Note Added: 0123990 | |
| 2020-10-30 13:25 | hgbot | Resolution | open => fixed |
| 2020-10-30 13:25 | hgbot | Status | new => closed |
| 2020-10-30 13:25 | hgbot | Note Added: 0124066 | |
| 2020-10-30 13:25 | hgbot | Fixed in Version | => PR21Q1 |
| 2020-10-30 13:25 | hgbot | Note Added: 0124067 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |