Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0045291
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Initial data loadcriticalalways2020-10-22 17:162020-10-29 16:11
Reportersebastien_lironView Statuspublic 
Assigned ToAtulOpenbravo 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version7.x
OS VersionOpenbravo Appliance 14.04Database version9.3.xAnt version1.9.x
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression levelProduction - Confirmed Stable
Review Assigned To
Regression introduced in release
Summary

0045291: import idl stock no longer works

DescriptionWe tested the import idl for stock and there is an issue with the tmp file creation.
Looking into the code, it seems that it is trying to write a tmp file already created, with no overwrite flags, so it fails.

I joined a fix, that I think should be taken, as it is a better and cleaner way to do the same thing ( and also it fixes the issue )
Steps To Reproduceget a 20q2 version of openbravo
add the org.openbravo.idl module
compile, etc ...

try to import the joint file in the import for stock

the system should tell that the tmp file is already created.
Proposed Solutionsee the diff joint.
TagsNo tags attached.
Attached Files? file icon idlDiff [^] (6,474 bytes) 2020-10-22 17:16 [Show Content]
csv file icon 20201005importSTK (1).csv [^] (94,028 bytes) 2020-10-22 17:16

- Relationships Relation Graph ] Dependency Graph ]
has duplicate defect 0045323 closedTriage Finance Not possible to import a file with more than 100 products 

-  Notes
(0123984)
hgbot (developer)
2020-10-29 04:00

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.idl/-/merge_requests/3 [^]
(0123994)
AtulOpenbravo (developer)
2020-10-29 10:07

Test Plan
- Install org.openbravo.idl module
- Login as F&B International Group Admin
- Using Enterprise module management, apply Initial Data Load dataset for F&B Espana organization
- Navigate to Import window, select file 20201005importSTK (1).csv (Attached file), Entity as Stock
- Run Validate process
- Realize that Error message related to org.apache.commons.io.FileExistsException disappears.

Note: There is another expected error about data not found for eg: Organization not found as the file content are not suitable for F&B International Group client.
(0124022)
hgbot (developer)
2020-10-29 16:11

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.idl [^]
Changeset: 0d8ccebe15ffd15c5ff8adcdceef4ac24623104a
Author: atul.gaware <atul.gaware@openbravo.com>
Date: 2020-10-29T08:16:39+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.idl/-/commit/0d8ccebe15ffd15c5ff8adcdceef4ac24623104a [^]

Related To BUG-45291:Apply Java Formatting

---
M src/org/openbravo/idl/proc/IdlService.java
---
(0124023)
hgbot (developer)
2020-10-29 16:11

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.idl [^]
Changeset: a61185a084b962ca3d6ecd6125f9411b688ef221
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 2020-10-29T08:18:36+05:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.idl/-/commit/a61185a084b962ca3d6ecd6125f9411b688ef221 [^]

Fixes BUG-45291: import idl stock no longer works

** This problem is fixed commons-fileupload but it will
be available in its next release. Internally
FileUtils.moveFile was used so it was no
longer possible to overwrite an existing file in
DiskFileItem.write(File). This is fixed by deleting
the target file, if possible.
** Same solution is applied in IdlService by deleting
destination file if it exists.

---
M src/org/openbravo/idl/proc/IdlService.java
---
(0124024)
hgbot (developer)
2020-10-29 16:11

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.idl/-/merge_requests/3 [^]

- Issue History
Date Modified Username Field Change
2020-10-22 17:16 sebastien_liron New Issue
2020-10-22 17:16 sebastien_liron Assigned To => Retail
2020-10-22 17:16 sebastien_liron File Added: idlDiff
2020-10-22 17:16 sebastien_liron Resolution time => 1604012400
2020-10-22 17:16 sebastien_liron Regression level => Production - Confirmed Stable
2020-10-22 17:16 sebastien_liron Triggers an Emergency Pack => No
2020-10-22 17:16 sebastien_liron File Added: 20201005importSTK (1).csv
2020-10-23 09:05 marvintm Project Retail Modules => Modules
2020-10-23 09:06 marvintm Category Retail API => Initial data load
2020-10-23 09:06 marvintm version RR20Q2.2 =>
2020-10-23 09:06 marvintm Target Version RR20Q2.3 =>
2020-10-23 09:06 marvintm Assigned To Retail => Triage Finance
2020-10-27 11:38 inigo_lerga Assigned To Triage Finance => inigo_lerga
2020-10-27 11:38 inigo_lerga Status new => scheduled
2020-10-28 10:50 AtulOpenbravo Assigned To inigo_lerga => AtulOpenbravo
2020-10-29 04:00 hgbot Note Added: 0123984
2020-10-29 10:07 AtulOpenbravo Note Added: 0123994
2020-10-29 13:45 dmiguelez Relationship added has duplicate 0045323
2020-10-29 16:11 hgbot Note Added: 0124022
2020-10-29 16:11 hgbot Resolution open => fixed
2020-10-29 16:11 hgbot Status scheduled => closed
2020-10-29 16:11 hgbot Note Added: 0124023
2020-10-29 16:11 hgbot Note Added: 0124024


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker