0045123: use of automatic promotion cause a crash if module discountmatrixmanagment is installed

Description

use of automatic promotion cause a crash if module discountmatrixmanagment is installed

Steps To Reproduce

have an env at 20q3 with discountmatrixmanagment module installed

configure an automatic promotion on a product ( any kind )

connect to web pos

Open a new ticket, add the auto promo product

click on checkout -> error should appear

Proposed Solution

in hookRoleDiscount.js ( in the discountmatrixmanagement module ), line 143 :
if (
              OB.Model.Discounts.discountRules[promotion.discountType].isManual
            ) {

should be something like :

  var discRule = OB.Model.Discounts.discountRules[promotion.discountType];
if (
      discRule && discRule.isManual
            ) {

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0123403) hgbot (developer) 2020-09-28 06:54	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.discountmatrixmanagement/-/merge_requests/1 [^]

(0123406) hgbot (developer) 2020-09-28 07:17	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.discountmatrixmanagement [^] Changeset: ad89d99dbd173a45be15c2e2b4935d41e899b9cd Author: Ranjith S R <ranjith@qualiantech.com> Date: 2020-09-27T21:09:21+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.discountmatrixmanagement/-/commit/ad89d99dbd173a45be15c2e2b4935d41e899b9cd [^] Fixed ISSUE-45123: Updated Validation of DiscountType in PaymentApproval Hook --- M web/org.openbravo.retail.discounts.discountmatrixmanagement/js/hookRoleDiscounts.js ---

(0123407) hgbot (developer) 2020-09-28 07:17	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.discountmatrixmanagement/-/merge_requests/1 [^]

Issue History
Date Modified	Username	Field	Change
2020-09-23 12:59	sebastien_liron	New Issue
2020-09-23 12:59	sebastien_liron	Assigned To	=> Retail
2020-09-23 12:59	sebastien_liron	Triggers an Emergency Pack	=> No
2020-09-23 15:48	sebastien_liron	Resolution time	=> 1602280800
2020-09-25 11:43	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2020-09-27 16:51	ranjith_qualiantech_com	Status	new => scheduled
2020-09-28 06:49	marvintm	Severity	critical => major
2020-09-28 06:54	hgbot	Note Added: 0123403
2020-09-28 07:17	hgbot	Resolution	open => fixed
2020-09-28 07:17	hgbot	Status	scheduled => closed
2020-09-28 07:17	hgbot	Note Added: 0123406
2020-09-28 07:17	hgbot	Note Added: 0123407