Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0045065
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] A. Platformminorhave not tried2020-08-31 13:322020-09-18 11:59
ReportercaristuView Statuspublic 
Assigned Tocaristu 
PriorityhighResolutionfixedFixed in VersionPR20Q2.2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget VersionPR20Q2.2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0045065: Update fileUpload library

DescriptionCurrent fileUpload library used in core (1.2.2) should be updated to the latest version available (1.4)[1]

[1] https://commons.apache.org/proper/commons-fileupload/ [^]
Steps To Reproduce.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks feature request 0044937 closedcaristu Update fileUpload library 

-  Notes
(0123099)
hgbot (developer)
2020-09-16 11:06

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/169 [^]
(0123215)
hgbot (developer)
2020-09-18 11:59

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 528a2cd7caa1e1b2ce415c92c304ca12fe2c2c6d
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 2020-09-18T09:59:02+00:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/528a2cd7caa1e1b2ce415c92c304ca12fe2c2c6d [^]

fixes BUG-45065: Update Apache Commons FileUpload

  Update Apache Commons FileUpload library to version 1.4. Together with
the library upgrade some minor changes are required:

  - FileItem class is no longer serializable[1]. For this reason with the
commons-fileupload update to version 1.4 we are no longer calling
"setSessionObject(String attribute, Serializable value)" with FileItem
as second argument but "setSessionObject(String attribute, Object value)"
which is deprecated.

  The problem is that with this change the session is no longer serializable
after setting into it a FileItem object. For the moment no additional
actions are going to be applied as this is only happening in
ModuleManagement window. So we are just adding a comment and the
SuppressWarnings annotation.

  - Removed unnecessary @SuppressWarnings("unchecked"). The
ServletFileUpload.parseRequest method does no longer require it as now
it is returning List<FileItem> instead of List.

  - Applied some minor code cleanup: removed commented-out code and use
a logger to log the exception.

[1] https://issues.apache.org/jira/browse/FILEUPLOAD-279 [^]

---
A lib/runtime/commons-fileupload-1.4.jar
M legal/Licensing.txt
M src-core/.classpath
M src-core/src/org/openbravo/base/VariablesBase.java
M src/org/openbravo/erpCommon/ad_forms/ModuleManagement.java
R lib/runtime/commons-fileupload-1.2.2.jar
---
(0123216)
hgbot (developer)
2020-09-18 11:59

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/169 [^]

- Issue History
Date Modified Username Field Change
2020-09-16 11:01 caristu Type feature request => backport
2020-09-16 11:01 caristu Target Version => PR20Q2.2
2020-09-16 11:06 hgbot Note Added: 0123099
2020-09-18 11:59 hgbot Resolution open => fixed
2020-09-18 11:59 hgbot Status scheduled => closed
2020-09-18 11:59 hgbot Fixed in Version => PR20Q2.2
2020-09-18 11:59 hgbot Note Added: 0123215
2020-09-18 11:59 hgbot Note Added: 0123216

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker