Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0044860 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Web POS Hardware Manager | critical | have not tried | 2020-08-20 15:10 | 2020-08-31 13:11 | |||
Reporter | shuehner | View Status | public | |||||
Assigned To | prakashmurugesan88 | |||||||
Priority | urgent | Resolution | fixed | Fixed in Version | RR20Q4 | |||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0044860: DeviceProcessStats.java from hardwaremanager uses Base64 class from itextpdf which is not needed + not correct | |||||||
Description | This file uses Base64 utility class from itxtpdf library ./org.openbravo.retail.poshwmanager.sources/project/src/com/openbravo/pos/monitor/DeviceProcessStats.java:import com.itextpdf.text.pdf.codec.Base64; ./org.openbravo.retail.poshwmanager.sources/project/src/com/openbravo/pos/monitor/DeviceProcessStats.java: json.put("document", Base64.encodeFromFile(content)); That has no functional relation with pdf generation so should not be done. All other code uses Base64 from commons-codec library for example this file in hwmanager: ./org.openbravo.retail.poshwmanager.sources/project/src/com/openbravo/pos/process/PrintPDF.java:import org.apache.commons.codec.binary.Base64; ./org.openbravo.retail.poshwmanager.sources/project/src/com/openbravo/pos/process/PrintPDF.java: byte[] document = Base64.decodeBase64(content.getString("document")); Furthermore the itextpdf library has a very specific licensing only allowing it to be used as dependency of jasperreport and does NOT allow any other usage (while wanting to keep LGPL exception) As that usage above is accidental (probably wrong auto-complete from eclipse) that usage should just be avoided. | |||||||
Steps To Reproduce | legal/iTextpdf_license.txt Check first paragraph disallowing 'manual usage' | |||||||
Proposed Solution | Don't use Base64 utility from itext | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |
Notes | |
(0122281) hgbot (developer) 2020-08-24 11:14 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager/-/merge_requests/6 [^] |
(0122282) hgbot (developer) 2020-08-24 11:15 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager.sources/-/merge_requests/6 [^] |
(0122485) hgbot (developer) 2020-08-31 13:09 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager.sources/-/merge_requests/6 [^] |
(0122486) hgbot (developer) 2020-08-31 13:10 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager.sources [^] Changeset: ca3f6596f6152c38ad0fbbd3f29e66b3fd0ceaa1 Author: Prakash M <prakash@qualiantech.com> Date: 2020-08-24T12:12:41+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager.sources/-/commit/ca3f6596f6152c38ad0fbbd3f29e66b3fd0ceaa1 [^] Fixed BUG-44860: Removed use of Base64 class in DeviceProcessStats as it is not needed --- M project/src/com/openbravo/pos/monitor/DeviceProcessStats.java --- |
(0122487) hgbot (developer) 2020-08-31 13:10 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager.sources [^] Changeset: f4ab1c9dc55c54c894d29284079ddd3a8fde271b Author: Prakash M <prakash@qualiantech.com> Date: 2020-08-25T11:38:13+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager.sources/-/commit/f4ab1c9dc55c54c894d29284079ddd3a8fde271b [^] Fixed BUG-44860: Added Base64 encode in DeviceProcessStats * Uses org.apache.commons.codec.binary.Base64 --- M project/src/com/openbravo/pos/monitor/DeviceProcessStats.java --- |
(0122488) hgbot (developer) 2020-08-31 13:11 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager [^] Changeset: 7f821151531a8d682cc56f538fa6bed534ce2271 Author: Prakash M <prakash@qualiantech.com> Date: 2020-08-24T12:12:12+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager/-/commit/7f821151531a8d682cc56f538fa6bed534ce2271 [^] Fixed BUG-44860: Removed use of Base64 class in DeviceProcessStats as it is not needed --- M bin/poshw.jar --- |
(0122489) hgbot (developer) 2020-08-31 13:11 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager/-/merge_requests/6 [^] |
(0122490) hgbot (developer) 2020-08-31 13:11 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager [^] Changeset: b994346f47417ccc9b0ef2358b514c100c8b01ec Author: Prakash M <prakash@qualiantech.com> Date: 2020-08-25T11:38:45+05:30 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.poshwmanager/-/commit/b994346f47417ccc9b0ef2358b514c100c8b01ec [^] Fixed BUG-44860: Added Base64 encode in DeviceProcessStats * Uses org.apache.commons.codec.binary.Base64 --- M bin/poshw.jar --- |
Issue History | |||
Date Modified | Username | Field | Change |
2020-08-20 15:10 | shuehner | New Issue | |
2020-08-20 15:10 | shuehner | Assigned To | => Retail |
2020-08-20 15:10 | shuehner | Triggers an Emergency Pack | => No |
2020-08-23 16:14 | prakashmurugesan88 | Assigned To | Retail => prakashmurugesan88 |
2020-08-24 08:48 | prakashmurugesan88 | Status | new => scheduled |
2020-08-24 11:14 | hgbot | Note Added: 0122281 | |
2020-08-24 11:15 | hgbot | Note Added: 0122282 | |
2020-08-31 13:09 | hgbot | Resolution | open => fixed |
2020-08-31 13:09 | hgbot | Status | scheduled => closed |
2020-08-31 13:09 | hgbot | Note Added: 0122485 | |
2020-08-31 13:10 | hgbot | Fixed in Version | => RR20Q4 |
2020-08-31 13:10 | hgbot | Note Added: 0122486 | |
2020-08-31 13:10 | hgbot | Note Added: 0122487 | |
2020-08-31 13:11 | hgbot | Note Added: 0122488 | |
2020-08-31 13:11 | hgbot | Note Added: 0122489 | |
2020-08-31 13:11 | hgbot | Note Added: 0122490 |
Copyright © 2000 - 2009 MantisBT Group |