Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0044718

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] A. Platform

minor

always

2020-07-29 19:50

2020-09-28 16:47

Reporter

a_singh

View Status

public

Assigned To

cberner

Priority

normal

Resolution

fixed

Fixed in Version

PR20Q4

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

pi

SCM revision

Merge Request Status

approved

Review Assigned To

OBNetwork customer

No

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0044718: An error display in the openbravo log when hyperlink date field is clicked in the general ledger report

Description

Following error displayed in the openbravo.log, when hyperlink date field is clicked in the general ledger report:

2020-07-29 14:50:13,467 [http-9] ERROR org.openbravo.base.VariablesBase - Input: DIRECT2 not accepted by filter: org.openbravo.base.filter.ValueListFilter@33cc37ec
java.lang.Throwable: null
    at org.openbravo.base.VariablesBase.filterRequest(VariablesBase.java:136) [openbravo-core.jar:?]
    at org.openbravo.base.VariablesBase.getStringParameter(VariablesBase.java:920) [openbravo-core.jar:?]
    at org.openbravo.base.VariablesBase.getStringParameter(VariablesBase.java:693) [openbravo-core.jar:?]
    at org.openbravo.base.VariablesBase.getStringParameter(VariablesBase.java:847) [openbravo-core.jar:?]
    at org.openbravo.erpCommon.security.Menu.getTargetMenu(Menu.java:172) [classes/:?]
    at org.openbravo.erpCommon.security.Menu.doPost(Menu.java:71) [classes/:?]

Steps To Reproduce

Log in as Openbravo/openbravo with default role:F&B International Group Admin
1.Go to Financial Management >> Accounting >> Ananlysis Tools and click on the General Ledger Report
2. Select From Date as 01-01-2019 and To Date as Current Date
3. Select Organization as F&B International Group
4. Select General Ledger as F&B International Group US/A/US Dollar
5. Click the Search button which will display some records and then click on the hyperlinked date field in the search result record which will redirect to the journal entries report window.
6. In the backend, we can check for the above error mentioned in the openbravo.log file.

Tags

No tags attached.

Screenshot from 2020-07-29 23-04-17.png [^] (607,308 bytes) 2020-07-29 19:50

44718_proposed.diff [^] (1,261 bytes) 2020-08-24 08:44 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/erpCommon/security/Menu.java b/src/org/openbravo/erpCommon/security/Menu.java
index e3c5525b8b..974a086620 100644
--- a/src/org/openbravo/erpCommon/security/Menu.java
+++ b/src/org/openbravo/erpCommon/security/Menu.java
@@ -11,7 +11,7 @@
  * under the License. 
  * The Original Code is Openbravo ERP. 
  * The Initial Developer of the Original Code is Openbravo SLU 
- * All portions are Copyright (C) 2001-2019 Openbravo SLU
+ * All portions are Copyright (C) 2001-2020 Openbravo SLU
  * All Rights Reserved. 
  * Contributor(s):  ______________________________________.
  ************************************************************************
@@ -167,7 +167,7 @@ public class Menu extends HttpSecureAppServlet {
   private String getTargetMenu(VariablesSecureApp vars, String queryString)
       throws ServletException {
 
-    final String[] allowedCommands = { "", "DEFAULT", "NEW", "EDIT", "GRID", "DIRECT" };
+    final String[] allowedCommands = { "", "DEFAULT", "NEW", "EDIT", "GRID", "DIRECT", "DIRECT2" };
     final ValueListFilter listFilter = new ValueListFilter(allowedCommands);
     final String command = vars.getStringParameter("Command", listFilter);
     final String url = vars.getStringParameter("url");

Relationships [ Relation Graph ] [ Dependency Graph ]

has duplicate	defect	0025801		closed	eduardo_Argal	In html output of GeneralLedgerReport, clicking on date link error shown in log on the redirect.
related to	defect	0045156		closed	cberner	An error display in the openbravo log when hyperlink date field is clicked in the trial balance report

Notes
(0122677) hgbot (developer) 2020-09-04 10:49	Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/145 [^]

(0122713) hgbot (developer) 2020-09-07 08:14	Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/145 [^]

(0122714) hgbot (developer) 2020-09-07 08:14	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 927150f91cc07ff6901414bf372617cefdc3fd31 Author: Cristian Berner <cristian.berner@openbravo.com> Date: 2020-09-07T06:14:14+00:00 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/927150f91cc07ff6901414bf372617cefdc3fd31 [^] Fixes ISSUE-44718: Allow requests including DIRECT2 command, such as ReportGeneralLedger General Ledger Report was failing when clicking on hyperlinks to subelements becaus a request with DIRECT2 command was being sent to the backend and not accepted by Menu class. It has been added to the allowedCommands so this and other reports using this redirection command work. --- M src/org/openbravo/erpCommon/security/Menu.java ---

Issue History
Date Modified	Username	Field	Change
2020-07-29 19:50	a_singh	New Issue
2020-07-29 19:50	a_singh	Assigned To	=> platform
2020-07-29 19:50	a_singh	File Added: Screenshot from 2020-07-29 23-04-17.png
2020-07-29 19:50	a_singh	OBNetwork customer	=> No
2020-07-29 19:50	a_singh	Modules	=> Core
2020-07-29 19:50	a_singh	Triggers an Emergency Pack	=> No
2020-08-03 07:39	alostale	Assigned To	platform => Triage Finance
2020-08-24 08:44	vmromanos	File Added: 44718_proposed.diff
2020-08-24 08:44	vmromanos	Assigned To	Triage Finance => platform
2020-09-04 10:49	hgbot	Merge Request Status	=> open
2020-09-04 10:49	hgbot	Note Added: 0122677
2020-09-04 10:51	cberner	Assigned To	platform => cberner
2020-09-04 11:16	shuehner	Relationship added	has duplicate 0025801
2020-09-07 08:14	hgbot	Merge Request Status	open => approved
2020-09-07 08:14	hgbot	Note Added: 0122713
2020-09-07 08:14	hgbot	Resolution	open => fixed
2020-09-07 08:14	hgbot	Status	new => closed
2020-09-07 08:14	hgbot	Fixed in Version	=> PR20Q4
2020-09-07 08:14	hgbot	Note Added: 0122714
2020-09-28 16:47	egoitz	Issue cloned	0045156
2020-09-28 16:47	egoitz	Relationship added	related to 0045156

Copyright © 2000 - 2009 MantisBT Group