0044653: Errors while importing POS Data JSONException JSONArray[0]

Description

When you have a fidelity customer on your ticket without coupons you have on JSON you have a field "coupons":[] without data in this case you have the error describe in subject

Steps To Reproduce

step describes above

Proposed Solution

To solve a user can delete the empty field "coupons": [] in the json and save again. You can fix with the patch provided if you want

Tags

No tags attached.

Attached Files

JSONExceptionJSONArray0.patch [^] (1,365 bytes) 2020-07-22 10:18 [Show Content] [Hide Content]

---
 .../bprelated/OrderLoaderHookCouponBPartner.java   | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/src/org/openbravo/retail/discounts/coupons/bprelated/OrderLoaderHookCouponBPartner.java b/src/org/openbravo/retail/discounts/coupons/bprelated/OrderLoaderHookCouponBPartner.java
index d5c6cbf..ef3ee2f 100644
--- a/src/org/openbravo/retail/discounts/coupons/bprelated/OrderLoaderHookCouponBPartner.java
+++ b/src/org/openbravo/retail/discounts/coupons/bprelated/OrderLoaderHookCouponBPartner.java
@@ -38,11 +38,17 @@ public class OrderLoaderHookCouponBPartner implements OrderLoaderHook {
         && !jsonorder.isNull("coupons") && !jsonorder.getString("coupons").equals("null"))) {
       return;
     }
-
     JSONArray jsonCoupons = jsonorder.getJSONArray("coupons");
-    JSONObject jsoncoupon = jsonCoupons.getJSONObject(0);
-    BusinessPartner bp = order.getBusinessPartner();
-    addBusinessPartnerCoupon(bp, jsoncoupon);
+    JSONObject jsoncoupon;
+    try {
+      jsoncoupon = jsonCoupons.getJSONObject(0);
+    } catch (JSONException e) {
+      jsoncoupon = null;
+    }
+    if (jsoncoupon != null) {
+      BusinessPartner bp = order.getBusinessPartner();
+      addBusinessPartnerCoupon(bp, jsoncoupon);
+    }
   }
 
   private void addBusinessPartnerCoupon(BusinessPartner bp, JSONObject jsoncoupon) {
--

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2020-07-22 10:18	cdehen	New Issue
2020-07-22 10:18	cdehen	Assigned To	=> Triage Finance
2020-07-22 10:18	cdehen	File Added: JSONExceptionJSONArray0.patch
2020-07-22 10:18	cdehen	Modules	=> Core
2020-07-22 10:18	cdehen	Triggers an Emergency Pack	=> No
2024-08-05 15:04	aferraz	Status	new => closed
2024-08-05 15:04	aferraz	Resolution	open => unable to reproduce