0044652: Bad display on subject and body on an email

Description

When you send a ticket by email.
You have in the subject 'XXXXX' || null.
And in the body you have 'YYYYY...' || null.

Steps To Reproduce

It is necessary to do a ticket with an invoice. When you send this ticket with invoice you have 2 attachment files in the mail (Sales order and Sales invoice)

The subject of the mail is construct with the template of sales order and the template of invoice, if in the template of invoice you have no subject and no body you obtain the issue describe.

Proposed Solution

You can use the patch provided if you want to solve the problem

Tags

No tags attached.

Attached Files

sendemail.patch [^] (1,441 bytes) 2020-07-22 10:06 [Show Content] [Hide Content]

---
 .../retail/sendemail/classes/OBSMAIL_MailSender.java | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/org/openbravo/retail/sendemail/classes/OBSMAIL_MailSender.java b/src/org/openbravo/retail/sendemail/classes/OBSMAIL_MailSender.java
index 4f11185..79f4594 100644
--- a/src/org/openbravo/retail/sendemail/classes/OBSMAIL_MailSender.java
+++ b/src/org/openbravo/retail/sendemail/classes/OBSMAIL_MailSender.java
@@ -224,8 +224,10 @@ public class OBSMAIL_MailSender {
           bp.getObsmailLanguage());
       if (emailTemplate != null) {
         if (subject != null) {
-          subject += " || ";
-          subject += emailTemplate.getSubject();
+          if (emailTemplate.getSubject() != null && !emailTemplate.getSubject().equals("")) {
+            subject += " || ";
+            subject += emailTemplate.getSubject();
+          }
         } else {
           subject = emailTemplate.getSubject();
         }
@@ -254,8 +256,10 @@ public class OBSMAIL_MailSender {
           bp.getObsmailLanguage());
       if (emailTemplate != null) {
         if (body != null) {
-          body += " || ";
-          body += emailTemplate.getBody();
+          if (emailTemplate.getBody() != null && !emailTemplate.getBody().equals("")) {
+            body += " || ";
+            body += emailTemplate.getBody();
+          }
         } else {
           body = emailTemplate.getBody();
         }
--

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2020-07-22 10:06	cdehen	New Issue
2020-07-22 10:06	cdehen	Assigned To	=> Retail
2020-07-22 10:06	cdehen	File Added: sendemail.patch
2020-07-22 10:06	cdehen	Triggers an Emergency Pack	=> No