0044613: [20Q3] An error about not properly configured simplified invoices is shown even if the context does not use them

Description

When updating from a 20Q2 to a 20Q3 release, at login a message is shown "Document Type for Simplified Invoice is not configured for the Document Type VBS POS Order"

Simplified invoices is not at use in the current Client, so this message should not be shown in this case.

Steps To Reproduce

1. From a 20Q2 release context, update to 20Q3
2. Login with the VBS-1 terminal using vallblanca user
3. An error as described before is shown (check attached screenshot)
4. Login is not possible until the data is fixed in the backoffice.

Proposed Solution

The error should be shown only for the Clients/Terminals that use Simplified Invoices. For the rest, this error could be perceived as a regression.

Tags

No tags attached.

Attached Files

SimplifiedInvoicesError.png [^] (258,451 bytes) 2020-07-15 11:52

44613.diff [^] (2,294 bytes) 2020-07-15 11:54 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/retail/posterminal/InitialValidations.java b/src/org/openbravo/retail/posterminal/InitialValidations.java
index 48d21da8c..a8279836a 100644
--- a/src/org/openbravo/retail/posterminal/InitialValidations.java
+++ b/src/org/openbravo/retail/posterminal/InitialValidations.java
@@ -119,11 +119,13 @@ public class InitialValidations {
     } else if (documentType.getDocumentTypeForInvoice() == null) {
       throw new OBException(String.format(
           OBMessageUtils.messageBD("OBPOS_DocTypeInvoiceNotConfigured"), documentType.getName()));
-    } else if (documentType.getDoctypesimpinvoice() == null) {
+    } else if (documentType.getDoctypesimpinvoice() == null
+        && posTerminal.getObposTerminaltype().isGenerateInvoice()) {
       throw new OBException(
           String.format(OBMessageUtils.messageBD("OBPOS_DocTypeSimplifiedInvoiceNotConfigured"),
               documentType.getName()));
-    } else if (documentType.getDoctypeaggrinvoice() == null) {
+    } else if (documentType.getDoctypeaggrinvoice() == null
+        && posTerminal.getObposTerminaltype().isGroupingOrders()) {
       throw new OBException(
           String.format(OBMessageUtils.messageBD("OBPOS_DocTypeAggregatedInvoiceNotConfigured"),
               documentType.getName()));
@@ -137,11 +139,13 @@ public class InitialValidations {
       throw new OBException(
           String.format(OBMessageUtils.messageBD("OBPOS_DocTypeReturnInvoiceNotConfigured"),
               returnDocumentType.getName()));
-    } else if (returnDocumentType.getDoctypesimpinvoice() == null) {
+    } else if (returnDocumentType.getDoctypesimpinvoice() == null
+        && posTerminal.getObposTerminaltype().isGenerateInvoice()) {
       throw new OBException(String.format(
           OBMessageUtils.messageBD("OBPOS_DocTypeSimplifiedReturnInvoiceNotConfigured"),
           returnDocumentType.getName()));
-    } else if (returnDocumentType.getDoctypeaggrinvoice() == null) {
+    } else if (returnDocumentType.getDoctypeaggrinvoice() == null
+        && posTerminal.getObposTerminaltype().isGroupingOrders()) {
       throw new OBException(String.format(
           OBMessageUtils.messageBD("OBPOS_DocTypeAggregatedReturnInvoiceNotConfigured"),
           returnDocumentType.getName()));

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0121466) aferraz (manager) 2020-07-15 11:55	Possible fix attached

Issue History
Date Modified	Username	Field	Change
2020-07-15 11:52	plujan	New Issue
2020-07-15 11:52	plujan	Assigned To	=> Retail
2020-07-15 11:52	plujan	File Added: SimplifiedInvoicesError.png
2020-07-15 11:52	plujan	Regression level	=> Packaging and release
2020-07-15 11:52	plujan	Triggers an Emergency Pack	=> No
2020-07-15 11:54	aferraz	File Added: 44613.diff
2020-07-15 11:55	aferraz	Note Added: 0121466