Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0044579
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementmajoralways2020-07-08 13:132020-07-23 15:12
ReporterpsarobeView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityurgentResolutionfixedFixed in VersionPR20Q4
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version3.0PR20Q2SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0044579: Button to upload products: Window Discount and Promotions

DescriptionDue to this fix https://issues.openbravo.com/view.php?id=42267 [^]

Now you can to have different products with the same search key but in different legal entities.

Because of that, the button to upload products is failing because it is finding the product more than one time while getting the UUID.
Steps To ReproduceConfiguration:
- You need to have two product with the same search key (P1, P2--> same search key)
- P1 needs to be in legal entity 1 (or in the tree that belongs that legal entity)
- P2 need to be in legal entity 2 (or in the tree that belongs that legal entity)

Steps:
1. Go to discount and promotion winow
2. Create the header and select "price adjustment" as discount type
3. Create a csv file that contains the search key of P1 and P2
4. Upload the file using the button (Not the orange one)

Current behaviour: Gives an error saying non unique product
Expected behaviour: The system should upload the correct product depending on the natural tree of the organization of the header.
Proposed SolutionThe process needs to take into account the organization of the header of the discount and promotion, in fact, the natural tree of the organization of the header.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
causes defect 0044645 closedadrianromero API Change: Changed signature of method getProductIds() in class ImportProductInDiscount 

-  Notes
(0121497)
hgbot (developer)
2020-07-17 06:25

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/106 [^]
(0121498)
hgbot (developer)
2020-07-17 08:29

 Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 2b70f9471dbbf6ed818e366101d551f4b0729c79
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 2020-07-17T09:54:31+05:30
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/2b70f9471dbbf6ed818e366101d551f4b0729c79 [^]

Fixed issue-44579: Product should be filtered before Import in M_Offer_Product table
* Before importing product in M_Offer_Product table, product should be filtered with Client and Org

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/businesslogic/ImportProductInDiscount.java
---
(0121499)
hgbot (developer)
2020-07-17 08:29

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/106 [^]
(0121510)
hgbot (developer)
2020-07-17 14:41

 Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 0b564e7e7da257ff24bc4b9f6a6712585b837092
Author: Adrián Romero <adrian.romero@openbravo.com>
Date: 2020-07-17T14:40:46+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/0b564e7e7da257ff24bc4b9f6a6712585b837092 [^]

Revert "Fixed issue-44579: Product should be filtered before Import in M_Offer_Product table"

This reverts commit 2b70f9471dbbf6ed818e366101d551f4b0729c79.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/businesslogic/ImportProductInDiscount.java
---
(0121513)
ranjith_qualiantech_com (developer)
2020-07-20 04:54

 Changes reverted due to try failure
(0121562)
hgbot (developer)
2020-07-22 11:09

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 25e3cb6fa21dd368dfd2fb0bca55279c79ae1505
Author: Adrián Romero <adrian.romero@openbravo.com>
Date: 2020-07-22T11:07:37+02:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/25e3cb6fa21dd368dfd2fb0bca55279c79ae1505 [^]

Fixed ISSUE-44579: Product should be filtered before Import in M_Offer_Product table
    * Before importing product in M_Offer_Product table, product should be filtered with Client and Org

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/businesslogic/ImportProductInDiscount.java
---

- Issue History
Date Modified Username Field Change
2020-07-08 13:13 psarobe New Issue
2020-07-08 13:13 psarobe Assigned To => marvintm
2020-07-08 13:13 psarobe Triggers an Emergency Pack => No
2020-07-08 13:20 psarobe Steps to Reproduce Updated View Revisions
2020-07-08 13:20 psarobe Proposed Solution updated
2020-07-08 13:22 martinsdan Issue Monitored: martinsdan
2020-07-15 08:56 ranjith_qualiantech_com Assigned To marvintm => ranjith_qualiantech_com
2020-07-15 08:56 ranjith_qualiantech_com Status new => scheduled
2020-07-17 06:25 hgbot Note Added: 0121497
2020-07-17 08:29 hgbot Resolution open => fixed
2020-07-17 08:29 hgbot Status scheduled => closed
2020-07-17 08:29 hgbot Note Added: 0121498
2020-07-17 08:29 hgbot Note Added: 0121499
2020-07-17 14:41 hgbot Note Added: 0121510
2020-07-20 04:54 ranjith_qualiantech_com Note Added: 0121513
2020-07-20 04:54 ranjith_qualiantech_com Status closed => new
2020-07-20 04:54 ranjith_qualiantech_com Resolution fixed => open
2020-07-20 04:54 ranjith_qualiantech_com Status new => scheduled
2020-07-21 11:54 adrianromero Relationship added causes 0044645
2020-07-22 11:09 hgbot Resolution open => fixed
2020-07-22 11:09 hgbot Status scheduled => closed
2020-07-22 11:09 hgbot Fixed in Version => PR20Q4
2020-07-22 11:09 hgbot Note Added: 0121562
2020-07-23 15:03 shuehner Project Retail Modules => Openbravo ERP
2020-07-23 15:04 shuehner Modules => Core
2020-07-23 15:04 shuehner Category Discounts and Promotions => 07. Sales management
2020-07-23 15:04 shuehner version RR20Q2 =>
2020-07-23 15:12 shuehner version => 3.0PR20Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker