Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0044441 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2020-06-22 11:33 | 2022-03-04 11:22 | |||
| Reporter | inigo_lerga | View Status | public | |||||
| Assigned To | Triage Platform Conn | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0044441: Apply new HQL Style in org.openbravo.authorize.net( CIMUtility.java & TransactionstatusDao.java) | |||||||
| Description | Both files have one HQL query each which: - are hard to read because of formatting - and which are mixing txt and i.e PROPERTY_ID constant which is not recommended by default | |||||||
| Steps To Reproduce | - | |||||||
| Proposed Solution | Follow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^] | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
Notes |
|
|
(0135436) hgbot (developer) 2022-03-03 18:00 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.authorize.net/-/merge_requests/2 [^] |
|
(0135463) hgbot (developer) 2022-03-04 11:22 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.authorize.net [^] Changeset: 4fdfe69054895e204dec74c6beb23e6b69346652 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 03-03-2022 17:58:41 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.authorize.net/-/commit/4fdfe69054895e204dec74c6beb23e6b69346652 [^] Fixes ISSUE-44441: Apply new HQL style Apply new HQL style to two queries to make them constant strings and improve readability. --- M src/org/openbravo/authorize/net/process/cim/util/CIMUtility.java M src/org/openbravo/authorize/net/process/transactiondetails/TransactionStatusDao.java --- |
|
(0135464) hgbot (developer) 2022-03-04 11:22 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.authorize.net/-/merge_requests/2 [^] |
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2020-06-22 11:33 | inigo_lerga | New Issue | |
| 2020-06-22 11:33 | inigo_lerga | Assigned To | => inigo_lerga |
| 2020-06-22 11:33 | inigo_lerga | OBNetwork customer | => No |
| 2020-06-22 11:33 | inigo_lerga | Modules | => Core |
| 2020-06-22 11:33 | inigo_lerga | Triggers an Emergency Pack | => No |
| 2020-06-22 11:33 | inigo_lerga | Relationship added | related to 0041287 |
| 2020-06-22 11:34 | inigo_lerga | Status | new => scheduled |
| 2021-11-22 13:19 | shuehner | Assigned To | inigo_lerga => Triage Finance |
| 2022-02-28 13:39 | vmromanos | Assigned To | Triage Finance => Triage Platform Conn |
| 2022-03-03 17:57 | shuehner | Summary | Apply new HQL Style in CIMUtility.java => Apply new HQL Style in org.openbravo.authorize.net( CIMUtility.java & TransactionstatusDao.java) |
| 2022-03-03 17:57 | shuehner | Description Updated | View Revisions |
| 2022-03-03 18:00 | hgbot | Merge Request Status | => open |
| 2022-03-03 18:00 | hgbot | Note Added: 0135436 | |
| 2022-03-04 11:22 | hgbot | Merge Request Status | open => approved |
| 2022-03-04 11:22 | hgbot | Resolution | open => fixed |
| 2022-03-04 11:22 | hgbot | Status | scheduled => closed |
| 2022-03-04 11:22 | hgbot | Note Added: 0135463 | |
| 2022-03-04 11:22 | hgbot | Note Added: 0135464 | |
| Copyright © 2000 - 2009 MantisBT Group |