Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0044163
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Advance Warehouse Operationsminorhave not tried2020-05-22 13:182020-06-04 16:06
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision49ed5718ec7f
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Regression introduced in release
Summary

0044163: Apply new HQL Style in CheckStorageBinsInNonActiveSBGroup.java

DescriptionCheckStorageBinsInNonActiveSBGroup.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to design defect 0041287 acknowledgedplatform Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0120181)
inigo_lerga (developer)
2020-05-22 13:36

--Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are executed#
(0120665)
hgbot (developer)
2020-06-04 16:06

Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 49ed5718ec7f43df5144d0140be4ce7d8def637e
Author: IƱigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri May 22 13:35:48 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/49ed5718ec7f43df5144d0140be4ce7d8def637e [^]

fixes BUG-44163:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckStorageBinsInNonActiveSBGroup.java
---
(0120666)
hgbot (developer)
2020-06-04 16:06

Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 5b0feee0e516afc4ff2a08c5fcfbcfcac2ee2d6a
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jun 04 16:06:07 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/5b0feee0e516afc4ff2a08c5fcfbcfcac2ee2d6a [^]

Related to ISSUE-44163. Format changes to improve redability

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckStorageBinsInNonActiveSBGroup.java
---
(0120667)
dmiguelez (developer)
2020-06-04 16:06

Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-05-22 13:18 inigo_lerga New Issue
2020-05-22 13:18 inigo_lerga Assigned To => inigo_lerga
2020-05-22 13:18 inigo_lerga Relationship added related to 0041287
2020-05-22 13:19 inigo_lerga Status new => scheduled
2020-05-22 13:36 inigo_lerga Note Added: 0120181
2020-06-04 16:06 hgbot Checkin
2020-06-04 16:06 hgbot Note Added: 0120665
2020-06-04 16:06 hgbot Status scheduled => resolved
2020-06-04 16:06 hgbot Resolution open => fixed
2020-06-04 16:06 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/49ed5718ec7f43df5144d0140be4ce7d8def637e [^]
2020-06-04 16:06 hgbot Checkin
2020-06-04 16:06 hgbot Note Added: 0120666
2020-06-04 16:06 dmiguelez Review Assigned To => dmiguelez
2020-06-04 16:06 dmiguelez Note Added: 0120667
2020-06-04 16:06 dmiguelez Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker