Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0044159
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Advanced Warehouse Operationsminorhave not tried2020-05-22 12:182020-06-04 13:53
Reporterinigo_lergaView Statuspublic 
Assigned Toinigo_lerga 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision27cd3e5e8959
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Todmiguelez
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary

0044159: Apply new HQL Style in CheckStorageBinGroupListWithoutActiveStorageBinGroup.java

DescriptionCheckStorageBinGroupListWithoutActiveStorageBinGroup.java has HQL queries with:
- the HQL is hard to read because of formatting
- and it is mixing txt and i.e PROPERTY_ID constant which is not recommended by default
Steps To Reproduce-
Proposed SolutionFollow new format as in http://wiki.openbravo.com/wiki/HQL_Coding_Conventions [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0041287 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Convert HQL to apply new style 

-  Notes
(0120177)
inigo_lerga (viewer)
2020-05-22 12:38

 --Test Plan Mantis HQL--
Beforehand, the environment needs to have AWO modules
installed and working.
Execute the AWOTestSuite.java JUnit tests file.
#In this moment the modified HQLs are executed#
(0120652)
hgbot (developer)
2020-06-04 13:52

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: 27cd3e5e8959d3212fb46687d6eb1174c1e7754a
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Fri May 22 12:55:07 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/27cd3e5e8959d3212fb46687d6eb1174c1e7754a [^]

fixes BUG-44159:Applied new HQL Style

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckStorageBinGroupListWithoutActiveStorageBinGroup.java
---
(0120653)
hgbot (developer)
2020-06-04 13:52

 Repository: erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations
Changeset: fb3d3d7ba031718af99aadd162ec81013d6e56a6
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jun 04 13:52:41 2020 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/fb3d3d7ba031718af99aadd162ec81013d6e56a6 [^]

Related to ISSUE-44159. Format changes to improve redability

---
M src/org/openbravo/warehouse/advancedwarehouseoperations/warehouseconfigurationcheck/implementation/CheckStorageBinGroupListWithoutActiveStorageBinGroup.java
---
(0120654)
dmiguelez (viewer)
2020-06-04 13:53

 Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2020-05-22 12:18 inigo_lerga New Issue
2020-05-22 12:18 inigo_lerga Assigned To => inigo_lerga
2020-05-22 12:18 inigo_lerga OBNetwork customer => No
2020-05-22 12:18 inigo_lerga Relationship added related to 0041287
2020-05-22 12:19 inigo_lerga Status new => scheduled
2020-05-22 12:38 inigo_lerga Note Added: 0120177
2020-06-04 13:52 hgbot Checkin
2020-06-04 13:52 hgbot Note Added: 0120652
2020-06-04 13:52 hgbot Status scheduled => resolved
2020-06-04 13:52 hgbot Resolution open => fixed
2020-06-04 13:52 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.advancedwarehouseoperations/rev/27cd3e5e8959d3212fb46687d6eb1174c1e7754a [^]
2020-06-04 13:52 hgbot Checkin
2020-06-04 13:52 hgbot Note Added: 0120653
2020-06-04 13:53 dmiguelez Review Assigned To => dmiguelez
2020-06-04 13:53 dmiguelez Note Added: 0120654
2020-06-04 13:53 dmiguelez Status resolved => closed
2022-09-06 17:18 caristu Category Advance Warehouse Operations => Advanced Warehouse Operations

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker